Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: remove unnecessary drop #117940

Merged
merged 1 commit into from
Nov 24, 2023
Merged

chore: remove unnecessary drop #117940

merged 1 commit into from
Nov 24, 2023

Conversation

zhiqiangxu
Copy link
Contributor

No need to manually drop since it's implicit.

@rustbot
Copy link
Collaborator

rustbot commented Nov 15, 2023

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @thomcc (or someone else) soon.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Nov 15, 2023
@thomcc
Copy link
Member

thomcc commented Nov 24, 2023

@bors r+

@bors
Copy link
Contributor

bors commented Nov 24, 2023

📌 Commit a355df4 has been approved by thomcc

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 24, 2023
@matthiaskrgr matthiaskrgr mentioned this pull request Nov 24, 2023
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Nov 24, 2023
@bors
Auto merge of rust-lang#118232 - matthiaskrgr:rollup-x8crvm0, r=matth…
f74f700 
…iaskrgr

Rollup of 6 pull requests

Successful merges:

 - rust-lang#116807 (Improve rewind documentation)
 - rust-lang#117656 (Update windows-bindgen and define `INVALID_HANDLE_VALUE` ourselves)
 - rust-lang#117940 (chore: remove unnecessary drop)
 - rust-lang#118028 (Document behavior of `<dyn Any as Any>::type_id()`)
 - rust-lang#118060 (Use an absolute path to the NUL device)
 - rust-lang#118224 (Sort unstable items last in rustdoc, instead of first)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit f38de06 into rust-lang:master Nov 24, 2023
11 checks passed
@rustbot rustbot added this to the 1.76.0 milestone Nov 24, 2023
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Nov 24, 2023
@rust-timer
Unrolled build for rust-lang#117940
92b0527 
Rollup merge of rust-lang#117940 - zhiqiangxu:remove_redundant_drop, r=thomcc

chore: remove unnecessary drop

 No need to manually drop since it's implicit.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@thomcc thomcc

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.76.0
Development

Successfully merging this pull request may close these issues.
4 participants
@zhiqiangxu @rustbot @thomcc @bors