rustdoc: rename issue-\d+.rs tests to have meaningful names (part 4)
#118105
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
fmease
approved these changes
Nov 23, 2023
There was a problem hiding this comment.
This could theoretically be moved into inline_local/.
tests/rustdoc/ice-34423.rs
Outdated
There was a problem hiding this comment.
Preexisting: This would be a better fit for rustdoc-ui/. We could also name it hidden-trait-method-34423.rs? (Nowadays, the bar in the impl is stripped anyways since it inherits the doc(hidden) from the corresp. trait item and the original code path is no longer exercised.)
tests/rustdoc/ice-36031.rs
Outdated
There was a problem hiding this comment.
→ rustdoc-ui/? → inherent-assoc-consts-36031.rs?
tests/rustdoc/ice-apit-46976.rs
Outdated
There was a problem hiding this comment.
→ rustdoc-ui/? → apit-46976.rs? ice- isn't super meaningful.
There was a problem hiding this comment.
→ rustdoc-ui/? → super-glob-40936.rs?
tests/rustdoc/tuple-struct-34928.rs
Outdated
There was a problem hiding this comment.
→ tuple-struct-with-where-clause-34928.rs?
fmease
added
S-waiting-on-author
notriddle
added
S-waiting-on-review
|
Cool, thanks! |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
Finished benchmarking commit (eab8c7d): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)This benchmark run did not return any relevant results for this metric. CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 675.686s -> 675.697s (0.00%) |
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 14, 2024
rustdoc: rename `issue-\d+.rs` tests to have meaningful names (part 5) Follow up * rust-lang#116214 * rust-lang#116432 * rust-lang#116824 * rust-lang#118105
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Jan 14, 2024
rustdoc: rename `issue-\d+.rs` tests to have meaningful names (part 5) Follow up * rust-lang#116214 * rust-lang#116432 * rust-lang#116824 * rust-lang#118105
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jan 14, 2024
Rollup merge of rust-lang#119561 - notriddle:master, r=fmease rustdoc: rename `issue-\d+.rs` tests to have meaningful names (part 5) Follow up * rust-lang#116214 * rust-lang#116432 * rust-lang#116824 * rust-lang#118105
GuillaumeGomez
added a commit
to GuillaumeGomez/rust
that referenced
this pull request
Apr 16, 2024
rustdoc: rename `issue-\d+.rs` tests to have meaningful names (part 6) Follow up * rust-lang#116214 * rust-lang#116432 * rust-lang#116824 * rust-lang#118105 * rust-lang#119561
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 16, 2024
Rollup merge of rust-lang#123574 - notriddle:notriddle/issue-d, r=fmease rustdoc: rename `issue-\d+.rs` tests to have meaningful names (part 6) Follow up * rust-lang#116214 * rust-lang#116432 * rust-lang#116824 * rust-lang#118105 * rust-lang#119561
fmease
added a commit
to fmease/rust
that referenced
this pull request
May 22, 2024
rustdoc: rename `issue-\d+.rs` tests to have meaningful names (part 7) Follow up * rust-lang#116214 * rust-lang#116432 * rust-lang#116824 * rust-lang#118105 * rust-lang#119561 * rust-lang#123574 As always, it's easier to review the commits one at a time. Don't use the Files Changed tab. It's confusing.
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 22, 2024
Rollup merge of rust-lang#125382 - notriddle:notriddle/issue-d, r=fmease rustdoc: rename `issue-\d+.rs` tests to have meaningful names (part 7) Follow up * rust-lang#116214 * rust-lang#116432 * rust-lang#116824 * rust-lang#118105 * rust-lang#119561 * rust-lang#123574 As always, it's easier to review the commits one at a time. Don't use the Files Changed tab. It's confusing.
github-actions bot
pushed a commit
to rust-lang/miri
that referenced
this pull request
May 23, 2024
rustdoc: rename `issue-\d+.rs` tests to have meaningful names (part 7) Follow up * rust-lang/rust#116214 * rust-lang/rust#116432 * rust-lang/rust#116824 * rust-lang/rust#118105 * rust-lang/rust#119561 * rust-lang/rust#123574 As always, it's easier to review the commits one at a time. Don't use the Files Changed tab. It's confusing.
jhpratt
added a commit
to jhpratt/rust
that referenced
this pull request
Jul 13, 2024
…k-Simulacrum rustdoc: rename `issue-\d+.rs` tests to have meaningful names (part 8) Follow up * rust-lang#116214 * rust-lang#116432 * rust-lang#116824 * rust-lang#118105 * rust-lang#119561 * rust-lang#123574 * rust-lang#125382 As always, it's easier to review the commits one at a time. Don't use the Files Changed tab. It's confusing.
workingjubilee
added a commit
to workingjubilee/rustc
that referenced
this pull request
Jul 14, 2024
…k-Simulacrum rustdoc: rename `issue-\d+.rs` tests to have meaningful names (part 8) Follow up * rust-lang#116214 * rust-lang#116432 * rust-lang#116824 * rust-lang#118105 * rust-lang#119561 * rust-lang#123574 * rust-lang#125382 As always, it's easier to review the commits one at a time. Don't use the Files Changed tab. It's confusing.
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 14, 2024
Rollup merge of rust-lang#127671 - notriddle:notriddle/issue-d, r=Mark-Simulacrum rustdoc: rename `issue-\d+.rs` tests to have meaningful names (part 8) Follow up * rust-lang#116214 * rust-lang#116432 * rust-lang#116824 * rust-lang#118105 * rust-lang#119561 * rust-lang#123574 * rust-lang#125382 As always, it's easier to review the commits one at a time. Don't use the Files Changed tab. It's confusing.
lnicola
pushed a commit
to lnicola/rust-analyzer
that referenced
this pull request
Jul 16, 2024
rustdoc: rename `issue-\d+.rs` tests to have meaningful names (part 8) Follow up * rust-lang/rust#116214 * rust-lang/rust#116432 * rust-lang/rust#116824 * rust-lang/rust#118105 * rust-lang/rust#119561 * rust-lang/rust#123574 * rust-lang/rust#125382 As always, it's easier to review the commits one at a time. Don't use the Files Changed tab. It's confusing.
Zalathar
added a commit
to Zalathar/rust
that referenced
this pull request
Sep 13, 2024
…youxu rustdoc: rename `issue-\d+.rs` tests to have meaningful names (part 9) Follow up * rust-lang#116214 * rust-lang#116432 * rust-lang#116824 * rust-lang#118105 * rust-lang#119561 * rust-lang#123574 * rust-lang#125382 * rust-lang#127671 As always, it's easier to review the commits one at a time. Don't use the Files Changed tab. It's confusing.
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Sep 13, 2024
Rollup merge of rust-lang#130287 - notriddle:notriddle/issue-d, r=jieyouxu rustdoc: rename `issue-\d+.rs` tests to have meaningful names (part 9) Follow up * rust-lang#116214 * rust-lang#116432 * rust-lang#116824 * rust-lang#118105 * rust-lang#119561 * rust-lang#123574 * rust-lang#125382 * rust-lang#127671 As always, it's easier to review the commits one at a time. Don't use the Files Changed tab. It's confusing.
github-actions bot
pushed a commit
to rust-lang/miri
that referenced
this pull request
Sep 14, 2024
rustdoc: rename `issue-\d+.rs` tests to have meaningful names (part 9) Follow up * rust-lang/rust#116214 * rust-lang/rust#116432 * rust-lang/rust#116824 * rust-lang/rust#118105 * rust-lang/rust#119561 * rust-lang/rust#123574 * rust-lang/rust#125382 * rust-lang/rust#127671 As always, it's easier to review the commits one at a time. Don't use the Files Changed tab. It's confusing.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up
issue-\d+.rstests to have meaningful names #116214issue-\d+.rstests to have meaningful names (part 2) #116432issue-\d+.rstests to have meaningful names (part 3) #116824