-
Notifications
You must be signed in to change notification settings - Fork 12.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Subtree update of rust-analyzer
#118365
Subtree update of rust-analyzer
#118365
Commits on Oct 28, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 3e4de96 - Browse repository at this point
Copy the full SHA 3e4de96View commit details
Commits on Nov 7, 2023
-
Configuration menu - View commit details
-
Copy full SHA for c566136 - Browse repository at this point
Copy the full SHA c566136View commit details
Commits on Nov 10, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 0647b64 - Browse repository at this point
Copy the full SHA 0647b64View commit details
Commits on Nov 13, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 6705860 - Browse repository at this point
Copy the full SHA 6705860View commit details
Commits on Nov 15, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 0d147b3 - Browse repository at this point
Copy the full SHA 0d147b3View commit details -
Update editors/code/package.json
Co-authored-by: Lukas Wirth <lukastw97@gmail.com>
Configuration menu - View commit details
-
Copy full SHA for 9c8727e - Browse repository at this point
Copy the full SHA 9c8727eView commit details
Commits on Nov 16, 2023
-
Configuration menu - View commit details
-
Copy full SHA for cfc881a - Browse repository at this point
Copy the full SHA cfc881aView commit details -
Configuration menu - View commit details
-
Copy full SHA for e95ec55 - Browse repository at this point
Copy the full SHA e95ec55View commit details -
Configuration menu - View commit details
-
Copy full SHA for 59f5d51 - Browse repository at this point
Copy the full SHA 59f5d51View commit details
Commits on Nov 17, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 6a0e02d - Browse repository at this point
Copy the full SHA 6a0e02dView commit details -
Auto merge of rust-lang#15917 - lnicola:sync-from-rust, r=lnicola
internal: Sync from downstream
Configuration menu - View commit details
-
Copy full SHA for bc97821 - Browse repository at this point
Copy the full SHA bc97821View commit details -
Configuration menu - View commit details
-
Copy full SHA for 808f668 - Browse repository at this point
Copy the full SHA 808f668View commit details -
Configuration menu - View commit details
-
Copy full SHA for 1cbda61 - Browse repository at this point
Copy the full SHA 1cbda61View commit details -
Configuration menu - View commit details
-
Copy full SHA for a54c0da - Browse repository at this point
Copy the full SHA a54c0daView commit details -
Auto merge of rust-lang#15925 - lnicola:pathres-nodebug, r=lnicola
internal: Remove debugging code in path resolution Closes rust-lang#15924
Configuration menu - View commit details
-
Copy full SHA for 255eed4 - Browse repository at this point
Copy the full SHA 255eed4View commit details
Commits on Nov 20, 2023
-
Auto merge of rust-lang#15885 - RunDevelopment:patch-1, r=lnicola
Fix typo in highlight_related.rs While reading the user manual, I noticed a random tick, so I went ahead and fixed it. The `await` keyword should be properly rendered as inline code. ![image](https://github.com/rust-lang/rust-analyzer/assets/20878432/f134a4c9-e539-4635-97ac-506790893869)
Configuration menu - View commit details
-
Copy full SHA for 3751429 - Browse repository at this point
Copy the full SHA 3751429View commit details -
Auto merge of rust-lang#15911 - Young-Flash:fix_missing_assoc_item, r…
…=lnicola fix: handle default constant values in `trait_impl_missing_assoc_item` diagnostic A patch of rust-lang/rust-analyzer#15895, close rust-lang/rust-analyzer#15909 cc `@Veykril`
Configuration menu - View commit details
-
Copy full SHA for 1a5cee1 - Browse repository at this point
Copy the full SHA 1a5cee1View commit details
Commits on Nov 21, 2023
-
Auto merge of rust-lang#15940 - pascalkuthe:fix_rename, r=Veykril
ensure renames happen after edit This is a bugfix for an issue I fould while working on helix. Rust-analyzer currently always sends any filesystem edits (rename/file creation) before any other edits. When renaming a file that is also being edited that would mean that the edit would be discarded and therefore an incomplete/incorrect refactor (or even cause the creation of a new file in helix altough that is probably a pub on our side). Example: * create a module: `mod foo` containing a `pub sturct Bar;` * reexport the struct uneder a different name in the `foo` module using a *fully qualified path*: `pub use crate::foo::Bar as Bar2`. * rename the `foo` module to `foo2` using rust-analyzer * obsereve that the path is not correctly updated (rust-analyer first sends a rename `foo.rs` to `foo2.rs` and then edits `foo.rs` after) This PR fixes that issue by simply executing all rename operations after all edit operations (while still executing file creation operations first). I also added a testcase similar to the example above. Relevent excerpt from the LSP standard: > Since version 3.13.0 a workspace edit can contain resource operations (create, delete or rename files and folders) as well. If resource operations are present clients need to execute the operations in the order in which they are provided. So a workspace edit for example can consist of the following two changes: (1) create file a.txt and (2) a text document edit which insert text into file a.txt. An invalid sequence (e.g. (1) delete file a.txt and (2) insert text into file a.txt) will cause failure of the operation. How the client recovers from the failure is described by the client capability: workspace.workspaceEdit.failureHandling
Configuration menu - View commit details
-
Copy full SHA for 2e7e8cc - Browse repository at this point
Copy the full SHA 2e7e8ccView commit details -
Auto merge of rust-lang#15825 - Austaras:master, r=flodiebold
fix: better resolve assoc item with type bound Closes rust-lang#15772
Configuration menu - View commit details
-
Copy full SHA for 8d3522e - Browse repository at this point
Copy the full SHA 8d3522eView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9f8191b - Browse repository at this point
Copy the full SHA 9f8191bView commit details -
Auto merge of rust-lang#15944 - brunobell:patch-1, r=lnicola
Update Arch Linux package URL in manual.adoc The old URL returns 404 now.
Configuration menu - View commit details
-
Copy full SHA for 91b3148 - Browse repository at this point
Copy the full SHA 91b3148View commit details -
Auto merge of rust-lang#15921 - Young-Flash:tmp, r=Veykril
chore: add use case for `PathSegment::qualifying_trait` add use case for `PathSegment::qualifying_trait`, which introduced in rust-lang/rust-analyzer#15875
Configuration menu - View commit details
-
Copy full SHA for 4513651 - Browse repository at this point
Copy the full SHA 4513651View commit details -
This commit provides additional initialization methods to Connection in order to support CTRL + C sigterm handling.
Configuration menu - View commit details
-
Copy full SHA for 81c2d35 - Browse repository at this point
Copy the full SHA 81c2d35View commit details
Commits on Nov 22, 2023
-
Auto merge of rust-lang#15894 - schrieveslaach:cancelable-initializat…
…ion, r=Veykril Cancelable Initialization This commit provides additional initialization methods to Connection in order to support CTRL + C sigterm handling. In the process of adding LSP to Nushell (see nushell/nushell#10941) this gap has been identified.
Configuration menu - View commit details
-
Copy full SHA for 7ceefc7 - Browse repository at this point
Copy the full SHA 7ceefc7View commit details
Commits on Nov 23, 2023
-
Relaxation for crate graph mergin
Partially fixes rust-lang#15656 . When a crate graph is extended which is the case when new workspaces are added to the project the rules for deduplication were too strict. One problem that arises from this is that in certain conditions when we see the same crate having different `CrateOrigin`s the first form would be maintained. This approach however results in some unwanted results such as making renaming forbidden as this has been recently only made available for local crates. The given example in rust-lang#15656 can still not be resolved with this PR as that involves taking inconsistencies between dependencies into consideration. This will be addressed in a future PR.
Configuration menu - View commit details
-
Copy full SHA for 886eaa0 - Browse repository at this point
Copy the full SHA 886eaa0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 7e4aad5 - Browse repository at this point
Copy the full SHA 7e4aad5View commit details -
Configuration menu - View commit details
-
Copy full SHA for 25e990d - Browse repository at this point
Copy the full SHA 25e990dView commit details -
Update test data for crate deduping
Make data reflect a case where dev deps are existent. base-db::CrateGraph::extend now adds dev dependencies for a crate in case of its upgrading from a CrateOrigin::Lib kind of a crate to a CrateOrigin::Local one.
Configuration menu - View commit details
-
Copy full SHA for 74d8fdc - Browse repository at this point
Copy the full SHA 74d8fdcView commit details -
Configuration menu - View commit details
-
Copy full SHA for f79e818 - Browse repository at this point
Copy the full SHA f79e818View commit details -
Configuration menu - View commit details
-
Copy full SHA for 736994f - Browse repository at this point
Copy the full SHA 736994fView commit details -
Configuration menu - View commit details
-
Copy full SHA for ba1b080 - Browse repository at this point
Copy the full SHA ba1b080View commit details -
Auto merge of rust-lang#15754 - alibektas:15656/linked_projects_are_l…
…ocal_too, r=Veykril fix: Dedup duplicate crates with differing origins in CrateGraph construction Partially fixes rust-lang#15656 . Until now the condition for deduplication in crate graphs were the strict equality of two crates. One problem that arises from this is that in certain conditions when we see the same crate having different `CrateOrigin`s the first occurrence would be kept. This approach however results in some unwanted results such as making renaming forbidden as this has been recently only made available for local crates. The given example in rust-lang#15656 can still not be resolved with this PR as that involves taking inconsistencies between dependencies into consideration. This will be addressed in a future PR.
Configuration menu - View commit details
-
Copy full SHA for cccc7ca - Browse repository at this point
Copy the full SHA cccc7caView commit details
Commits on Nov 24, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 615abb3 - Browse repository at this point
Copy the full SHA 615abb3View commit details -
Configuration menu - View commit details
-
Copy full SHA for f0adf8c - Browse repository at this point
Copy the full SHA f0adf8cView commit details -
Auto merge of rust-lang#15956 - ahlinc:label-detail, r=lnicola
Improve completion label details display This PR improves completion label details display by separating trait and alias info from the `label` LSP field to an additional existing `label_detail` field. Changes look like the following: ### Before ![Screenshot from 2023-11-24 12-03-08](https://github.com/rust-lang/rust-analyzer/assets/14666676/74066f0d-f1ac-4e99-8be5-c5141d513d23) ### After ![Screenshot from 2023-11-24 12-21-57](https://github.com/rust-lang/rust-analyzer/assets/14666676/45fca112-4612-40a3-81b9-07ff12de0962) _All existing tests are passed without any changes in test themselves logic._
Configuration menu - View commit details
-
Copy full SHA for 8733728 - Browse repository at this point
Copy the full SHA 8733728View commit details -
Auto merge of rust-lang#15846 - jprochazk:disable-error-notification,…
… r=Veykril editor/code: add option to suppress error notifications Fixes rust-lang/rust-analyzer#14193 - Added the `rust-analyzer.showRequestFailedErrorNotification` configuration option, which defaults to `true` - If `rust-analyzer.showRequestFailedErrorNotification` is set to `true`, the current behavior is preserved. - If `rust-analyzer.showRequestFailedErrorNotification` is set to `false`, no error toasts will be displayed for any of the failed requests caused by panics in r-a. This _only_ applies to events that are triggered "implicitly", such as `textDocument/hover`. To test this, you can manually introduce a panic in one of the language server LSP handlers for non-command events. I added an explicit `panic!()` in the `textDocument/hover` event handler: #### `rust-analyzer.showRequestFailedErrorNotification` set to `true` (default) [2023-11-07 17-17-48.webm](https://github.com/rust-lang/rust-analyzer/assets/1665677/d0408ab8-79d1-42cf-a4e7-94e99d9783ec) #### `rust-analyzer.showRequestFailedErrorNotification` set to `false` [2023-11-07 17-16-49.webm](https://github.com/rust-lang/rust-analyzer/assets/1665677/0496d8d0-fb53-4bc6-a279-1a47f412dbdb)
Configuration menu - View commit details
-
Copy full SHA for fec3828 - Browse repository at this point
Copy the full SHA fec3828View commit details -
Configuration menu - View commit details
-
Copy full SHA for b68f531 - Browse repository at this point
Copy the full SHA b68f531View commit details -
Auto merge of rust-lang#15960 - dtolnay-contrib:issomeand, r=lnicola
Replace `option.map(cond) == Some(true)` with `option.is_some_and(cond)` Extracted from rust-lang#118253.
Configuration menu - View commit details
-
Copy full SHA for 34cffbf - Browse repository at this point
Copy the full SHA 34cffbfView commit details
Commits on Nov 25, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 94cea46 - Browse repository at this point
Copy the full SHA 94cea46View commit details -
Auto merge of rust-lang#15962 - ahlinc:label-datail2, r=lnicola
fix: add fallback for completion label details This PR adds a fallback to a previous implementation in a case when the label detail field isn't supported by LSP client and the support isn't reported by the LSP initialize request. In this case additional info about trait and aliases would be merged into the label field as it was before the rust-lang#15956 PR.
Configuration menu - View commit details
-
Copy full SHA for 35da60a - Browse repository at this point
Copy the full SHA 35da60aView commit details -
Configuration menu - View commit details
-
Copy full SHA for fa74ac8 - Browse repository at this point
Copy the full SHA fa74ac8View commit details -
Configuration menu - View commit details
-
Copy full SHA for c01679e - Browse repository at this point
Copy the full SHA c01679eView commit details -
Configuration menu - View commit details
-
Copy full SHA for aadeb66 - Browse repository at this point
Copy the full SHA aadeb66View commit details -
Configuration menu - View commit details
-
Copy full SHA for fc880be - Browse repository at this point
Copy the full SHA fc880beView commit details -
Auto merge of rust-lang#15964 - lnicola:bump-deps, r=lnicola
minor: Bump rustc deps and chalk This finally upgrades `ra-ap-rustc_parse_format` (even though it's probably a no-op?).
Configuration menu - View commit details
-
Copy full SHA for 79ec2c5 - Browse repository at this point
Copy the full SHA 79ec2c5View commit details
Commits on Nov 26, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 3ccde00 - Browse repository at this point
Copy the full SHA 3ccde00View commit details -
Auto merge of rust-lang#15967 - lnicola:salsa-fork, r=lnicola
internal: Switch to our own `salsa` fork This gets rid of `syn` 1, among others.
Configuration menu - View commit details
-
Copy full SHA for 237712f - Browse repository at this point
Copy the full SHA 237712fView commit details
Commits on Nov 27, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 0c96252 - Browse repository at this point
Copy the full SHA 0c96252View commit details -
Configuration menu - View commit details
-
Copy full SHA for d036daa - Browse repository at this point
Copy the full SHA d036daaView commit details