rustdoc-search: allow spaces around :: in path query
#118452
Conversation
This restriction made sense back when spaces separated function parameters, but now that they separate path components, there's no real ambiguity any more. Additionally, the Rust language allows it.
This is already covered by the normal unexpected char path.
This way, most of the parsing code doesn't need to be designed to handle it, since they should always be treated exactly the same anyhow.
|
r? @jsha (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
S-waiting-on-review
|
Some changes occurred in HTML/CSS/JS. cc @GuillaumeGomez, @jsha |
notriddle
changed the title
:: and :::: in path query
|
I don't agree with this change. I think not allowing whitespace characters in paths makes more sense:
|
Rust allows you to put spaces around the More important than consistency with Rust, though, is consistency with itself. The search engine already allows
It's a search query. Most of the time, nobody but the person who writes the query will ever see it. |
|
I agree with @notriddle on this. |
I didn't know that. Then I'm all in favour for this change. 👍 |
|
I'm not sure if an FCP is needed here. I'll let you decide on this. r=me otherwise. |
|
@bors r=GuillaumeGomez,jsha |
bors
added
S-waiting-on-bors
…iaskrgr Rollup of 5 pull requests Successful merges: - rust-lang#118452 (rustdoc-search: allow spaces around `::` in path query) - rust-lang#118453 (Tweak message on ADT with private fields building) - rust-lang#118456 (rustc_span: Remove unused symbols.) - rust-lang#118458 (rustdoc: remove small from `small-section-header`) - rust-lang#118464 (Dispose llvm::TargetMachines prior to llvm::Context being disposed) r? `@ghost` `@rustbot` modify labels: rollup
Rollup merge of rust-lang#118452 - notriddle:coloncolonspace, r=GuillaumeGomez,jsha rustdoc-search: allow spaces around `::` in path query This restriction made sense back when spaces separated function parameters, but now that they separate path components, there's no real ambiguity any more. Additionally, the Rust language allows it. The other two commits are misc code cleanup.
This restriction made sense back when spaces separated function parameters, but now that they separate path components, there's no real ambiguity any more.
Additionally, the Rust language allows it.
The other two commits are misc code cleanup.