fix jobserver ICE "jobserver check should have been called earlier"

[oksbsb]

Fix #118588

[rustbot]

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @WaffleLapkin (or someone else) soon.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

• @rustbot author: the review is finished, PR author should check the comments and take action accordingly
• @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

[SparrowLii]

@oksbsb Thanks! It looks like #113730 has made the parallel frontend completely unusable : ( Hoping this to land as soon as possible

[petrochenkov]

I'll r+ after #118589 (comment) and #118589 (comment) are addressed, and the tidy issue #118589 (comment) is fixed (x.py test --bless tidy).

r? @petrochenkov
@rustbot author

[petrochenkov]

@oksbsb
It would be good to fix this today if you have time, because the issue seems critical.
If not, then it's also fine, I'll just resubmit the fix myself tomorrow.

[petrochenkov]

While we are at here, could you also introduce

impl EarlyErrorHandler {
    pub fn initialize_checked_jobserver(&self) {
        jobserver::check(|err| {
            self.early_warn_with_note(err, "the build environment is likely misconfigured")
        });
    }
}

to share the code?

(The current setup exists because jobserver lives in rustc_data_structures and therefore cannot use the error handler types.)

[petrochenkov]

r=me after making CI green and squashing commits into one.

[oksbsb]

@petrochenkov updated, thanks a lot.

[oksbsb]

@bors r=petrochenkov

[bors]

@oksbsb: 🔑 Insufficient privileges: Not in reviewers

[SparrowLii]

@bors r=petrochenkov

[bors]

📌 Commit 4f5355a has been approved by petrochenkov

It is now in the queue for this repository.

[bors]

🔒 Merge conflict

This pull request and the master branch diverged in a way that cannot be automatically merged. Please rebase on top of the latest master branch, and let the reviewer approve again.

How do I rebase?

Assuming self is your fork and upstream is this repository, you can resolve the conflict following these steps:

1. git checkout master (switch to your branch)
2. git fetch upstream master (retrieve the latest master)
3. git rebase upstream/master -p (rebase on top of it)
4. Follow the on-screen instruction to resolve conflicts (check git status if you got lost).
5. git push self master --force-with-lease (update this PR)

You may also read Git Rebasing to Resolve Conflicts by Drew Blessing for a short tutorial.

Please avoid the "Resolve conflicts" button on GitHub. It uses git merge instead of git rebase which makes the PR commit history more difficult to read.

Sometimes step 4 will complete without asking for resolution. This is usually due to difference between how Cargo.lock conflict is handled during merge and rebase. This is normal, and you should still perform step 5 to update this PR.

Error message

Auto-merging compiler/rustc_session/src/session.rs
CONFLICT (content): Merge conflict in compiler/rustc_session/src/session.rs
Auto-merging compiler/rustc_interface/src/tests.rs
Auto-merging compiler/rustc_interface/src/interface.rs
Automatic merge failed; fix conflicts and then commit the result.

[WaffleLapkin]

@oksbsb try not to push after closing a PR but before reopening it, github is somewhat broken with this IIRC