Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set TaKO8Ki off from review rotation #118601

Closed
wants to merge 1 commit into from
Closed

Set TaKO8Ki off from review rotation #118601

wants to merge 1 commit into from

Conversation

apiraino
Copy link
Contributor

@apiraino apiraino commented Dec 4, 2023 •
edited
Loading

If my understanding is correct, user @TaKO8Ki is not actively reviewing pull requests at this time, so it should be safe to remove them from the rotation.

Am I correct @TaKO8Ki ?

Thanks

@rustbot
Copy link
Collaborator

rustbot commented Dec 4, 2023

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @Mark-Simulacrum (or someone else) soon.

Please see the contribution instructions for more information. Namely, in order to ensure the minimum review times lag, PR authors and assigned reviewers should ensure that the review label (S-waiting-on-review and S-waiting-on-author) stays updated, invoking these commands when appropriate:

  • @rustbot author: the review is finished, PR author should check the comments and take action accordingly
  • @rustbot review: the author is ready for a review, this PR will be queued again in the reviewer's queue

@rustbot rustbot added A-meta Area: Issues & PRs about the rust-lang/rust repository itself S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 4, 2023
@TaKO8Ki
Copy link
Member

TaKO8Ki commented Dec 4, 2023 •
edited
Loading

@apiraino I'm currently actively reviewing pull requests.

ref:

@TaKO8Ki TaKO8Ki added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 4, 2023
@petrochenkov
Copy link
Contributor

@apiraino
The surface issue here is that TaKO8Ki is assigned too often, but the root issue is that the most of other compiler team/contributors are permanently on review vacation.

I'd ideally want to put all currently active people from this https://www.rust-lang.org/governance/teams/compiler#Compiler%20team and this https://www.rust-lang.org/governance/teams/compiler#Compiler%20team%20contributors list on review rotation, including those who are too busy and important to do reviews. That would solve a lot of problems.
I was trying to raise this issue maybe once every year, but maybe not actively enough.

@apiraino
Copy link
Contributor Author

apiraino commented Dec 4, 2023

wow I totally missed the context, I should have checked better.

thanks @TaKO8Ki for clarifying and sorry about that!

@petrochenkov agree. yeah, that's exactly the issue I'm actively working to improve 🙂

closing this patch as not needed

@apiraino apiraino closed this Dec 4, 2023
@apiraino apiraino deleted the set-TaKO8Ki-off-from-review-rotation branch December 4, 2023 16:33
@apiraino apiraino removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
A-meta Area: Issues & PRs about the rust-lang/rust repository itself
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@apiraino @rustbot @TaKO8Ki @petrochenkov @Mark-Simulacrum