-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 6 pull requests #118780
Rollup of 6 pull requests #118780
Commits on Dec 4, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 199098b - Browse repository at this point
Copy the full SHA 199098bView commit details
Commits on Dec 6, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 856b55f - Browse repository at this point
Copy the full SHA 856b55fView commit details -
Identify impossible cases in
ascii_escapes_should_be_ascii
.Raw strings (of all kinds) don't support escapes, so this function should never be called on them.
Configuration menu - View commit details
-
Copy full SHA for e290582 - Browse repository at this point
Copy the full SHA e290582View commit details -
Configuration menu - View commit details
-
Copy full SHA for c6bbb37 - Browse repository at this point
Copy the full SHA c6bbb37View commit details
Commits on Dec 7, 2023
-
Configuration menu - View commit details
-
Copy full SHA for f312775 - Browse repository at this point
Copy the full SHA f312775View commit details -
It is used just once. With it removed, the relevant code is a little boilerplate-y but much easier to read, and is the same length. Overall I think it's an improvement.
Configuration menu - View commit details
-
Copy full SHA for 60e7c68 - Browse repository at this point
Copy the full SHA 60e7c68View commit details -
This results in two non-generic types being used: `BorrowckResults` and `BorrowckFlowState`. It's a net reduction in lines of code, and a little easier to read.
Configuration menu - View commit details
-
Copy full SHA for 0158404 - Browse repository at this point
Copy the full SHA 0158404View commit details -
`GenKillAnalysis` has five methods that take a transfer function arg: - `statement_effect` - `before_statement_effect` - `terminator_effect` - `before_terminator_effect` - `call_return_effect` All the transfer function args have type `&mut impl GenKill<Self::Idx>`, except for `terminator_effect`, which takes the simpler `Self::Domain`. But only the first two need to be `impl GenKill`. The other three can all be `Self::Domain`, just like `Analysis`. So this commit changes the last two to take `Self::Domain`, making `GenKillAnalysis` and `Analysis` more similar. (Another idea would be to make all these methods `impl GenKill`. But that doesn't work: `MaybeInitializedPlaces::terminator_effect` requires the arg be `Self::Domain` so that `self_is_unwind_dead(place, state)` can be called on it.)
Configuration menu - View commit details
-
Copy full SHA for 4b364b6 - Browse repository at this point
Copy the full SHA 4b364b6View commit details
Commits on Dec 8, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 08b8ba0 - Browse repository at this point
Copy the full SHA 08b8ba0View commit details -
Remove explicit
\n
and\t
handling inunescape_str_common
.The fallback `_` case works for these chars, no need to treat them specially.
Configuration menu - View commit details
-
Copy full SHA for f883762 - Browse repository at this point
Copy the full SHA f883762View commit details -
Eliminate
is_byte: bool
args in unescaping code.These don't really make sense since C string literals were added. This commit removes them in favour for `mode: Mode` args. `ascii_check` still has a `characters_should_be_ascii: bool` arg. Also, `characters_should_be_ascii` is renamed to be shorter.
Configuration menu - View commit details
-
Copy full SHA for 119b1d0 - Browse repository at this point
Copy the full SHA 119b1d0View commit details -
The `empty!` macro calls should be outside the `cfg(FALSE)` function.
Configuration menu - View commit details
-
Copy full SHA for 9741dba - Browse repository at this point
Copy the full SHA 9741dbaView commit details -
Configuration menu - View commit details
-
Copy full SHA for adc46e5 - Browse repository at this point
Copy the full SHA adc46e5View commit details -
- Add `use Mode::*` to avoid all the qualifiers. - Reorder the variants. The existing order makes no particular sense, which has bugged me for some time. I've chosen an order that makes sense to me.
Configuration menu - View commit details
-
Copy full SHA for 0a401b6 - Browse repository at this point
Copy the full SHA 0a401b6View commit details
Commits on Dec 9, 2023
-
Configuration menu - View commit details
-
Copy full SHA for 3818fc0 - Browse repository at this point
Copy the full SHA 3818fc0View commit details -
Configuration menu - View commit details
-
Copy full SHA for 97de8fb - Browse repository at this point
Copy the full SHA 97de8fbView commit details -
Configuration menu - View commit details
-
Copy full SHA for c980fae - Browse repository at this point
Copy the full SHA c980faeView commit details -
Configuration menu - View commit details
-
Copy full SHA for bba9862 - Browse repository at this point
Copy the full SHA bba9862View commit details -
Avoid target_os and target_arch in some check-cfg tests
as they unnecessarily clutter the diagnostic output and make the experience of adding a new target to the compiler more painful than it should be. target_os and target_arch are still being tested in the well-known-values.rs test, but in one place.
Configuration menu - View commit details
-
Copy full SHA for 4c16716 - Browse repository at this point
Copy the full SHA 4c16716View commit details -
Add simd_masked_{load,store} platform-intrinsics
This maps to the LLVM intrinsics: llvm.masked.load and llvm.masked.store
Configuration menu - View commit details
-
Copy full SHA for 97ae509 - Browse repository at this point
Copy the full SHA 97ae509View commit details -
Rollup merge of rust-lang#117953 - farnoy:masked-load-store, r=workin…
…gjubilee Add more SIMD platform-intrinsics - [x] simd_masked_load - [x] LLVM codegen - llvm.masked.load - [x] cranelift codegen - implemented but untested - [ ] simd_masked_store - [x] LLVM codegen - llvm.masked.store - [ ] cranelift codegen Also added a run-pass test to test both intrinsics, and additional build-fail & check-fail to cover validation for both intrinsics
Configuration menu - View commit details
-
Copy full SHA for c57b054 - Browse repository at this point
Copy the full SHA c57b054View commit details -
Rollup merge of rust-lang#118057 - bvanjoi:fix-118048, r=cjgillot
dedup for duplicate suggestions Fixes rust-lang#118048 An easy fix.
Configuration menu - View commit details
-
Copy full SHA for 0865eef - Browse repository at this point
Copy the full SHA 0865eefView commit details -
Rollup merge of rust-lang#118638 - nnethercote:rustc_mir_dataflow-mor…
…e, r=cjgillot More `rustc_mir_dataflow` cleanups r? `@cjgillot`
Configuration menu - View commit details
-
Copy full SHA for 546643c - Browse repository at this point
Copy the full SHA 546643cView commit details -
Rollup merge of rust-lang#118702 - Urgau:check-cfg-strengthen-well-kn…
…own, r=nnethercote Strengthen well known check-cfg names and values test rust-lang#118494 is changing the implementation of how we expect well known check-cfg names and values, but we currently don't have a test that checks every well known only some of them. This PR therefore strengthen our well known names/values test to include all of the configs to at least avoid unintended regressions and validate new entry. *this PR also contains some drive-by consolidation of unexpected `target_os`, `target_arch` into a single file* r? `@nnethercote` (maybe? feel free to re-assign)
Configuration menu - View commit details
-
Copy full SHA for 78d2c8e - Browse repository at this point
Copy the full SHA 78d2c8eView commit details -
Rollup merge of rust-lang#118734 - nnethercote:literal-cleanups, r=fe…
…e1-dead Unescaping cleanups Minor improvements I found while working on rust-lang#118699. r? `@fee1-dead`
Configuration menu - View commit details
-
Copy full SHA for a1c252f - Browse repository at this point
Copy the full SHA a1c252fView commit details -
Rollup merge of rust-lang#118766 - compiler-errors:lower-spans, r=spa…
…storino Lower some forgotten spans I wrote a HIR visitor that visited all of the spans in the HIR, and made it ICE when we have a unlowered span. That led me to discover these unlowered spans.
Configuration menu - View commit details
-
Copy full SHA for fd60c5a - Browse repository at this point
Copy the full SHA fd60c5aView commit details