Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the function body span to StableMIR #119100

Merged
merged 1 commit into from
Dec 19, 2023
Merged

Conversation

celinval
Copy link
Contributor

We were missing the body span, which differs from the function definition span, since it covers the entire function body.

r? @ouz-a

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 19, 2023
@rustbot
Copy link
Collaborator

rustbot commented Dec 19, 2023

This PR changes Stable MIR

cc @oli-obk, @celinval, @spastorino, @ouz-a

@compiler-errors
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Dec 19, 2023

📌 Commit 36bb79f has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 19, 2023
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 19, 2023
…iaskrgr

Rollup of 4 pull requests

Successful merges:

 - rust-lang#119087 (Update books)
 - rust-lang#119091 (Use alias-eq in structural normalization)
 - rust-lang#119098 (Adjust the ignore-compare-mode-next-solver for hangs)
 - rust-lang#119100 (Add the function body span to StableMIR)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 739364b into rust-lang:master Dec 19, 2023
11 checks passed
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Dec 19, 2023
Rollup merge of rust-lang#119100 - celinval:smir-body-span, r=compiler-errors

Add the function body span to StableMIR

We were missing the body span, which differs from the function definition span, since it covers the entire function body.

r? `@ouz-a`
@rustbot rustbot added this to the 1.76.0 milestone Dec 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants