Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

avoid generalization inside of aliases #119106

Merged
merged 6 commits into from
Feb 26, 2024
Merged

avoid generalization inside of aliases #119106

merged 6 commits into from
Feb 26, 2024

Commits on Feb 26, 2024

  1. add additional logging

    @lcnr
    lcnr committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    eeeb9b4 View commit details
    Browse the repository at this point in the history

  2. always emit AliasRelate goals when relating aliases 

    Add `StructurallyRelateAliases` to allow instantiating infer vars with rigid aliases.
Change `instantiate_query_response` to be infallible in the new solver. This requires canonicalization to not hide any information used by the query, so weaken
universe compression. It also modifies `term_is_fully_unconstrained` to allow
region inference variables in a higher universe.
    @lcnr
    lcnr committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    1b3164f View commit details
    Browse the repository at this point in the history

  3. use fulfillment in `Coerce::unify' 

    only checking whether nested goals hold means that we don't consider
their inference constraints. Given that we now emit `AliasRelate` when relating
aliases and infer vars, this previously resulted in an "unconstrained" inference var
in `coerce_unsized`.
    @lcnr
    lcnr committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    a788be0 View commit details
    Browse the repository at this point in the history

  4. update tests

    @lcnr
    lcnr committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    2c7ede8 View commit details
    Browse the repository at this point in the history

  5. add regression tests

    @lcnr
    lcnr committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    1c264ca View commit details
    Browse the repository at this point in the history

  6. consider placeholders in fn term_is_fully_unconstrained

    @lcnr
    lcnr committed Feb 26, 2024
    Configuration menu
    Copy the full SHA
    3b3514a View commit details
    Browse the repository at this point in the history