Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tests: fix overaligned-constant to not over-specify getelementptr instr #119201

Merged
merged 1 commit into from
Dec 22, 2023

Conversation

durin42
Copy link
Contributor

@durin42 durin42 commented Dec 21, 2023

On LLVM 18 we get slightly different arguments here, so it's easier to just regex those away. The important details are all still asserted as I understand things.

Fixes #119193.

@rustbot label: +llvm-main

On LLVM 18 we get slightly different arguments here, so it's easier to
just regex those away. The important details are all still asserted as I
understand things.

Fixes rust-lang#119193.

@rustbot label: +llvm-main
@rustbot
Copy link
Collaborator

rustbot commented Dec 21, 2023

r? @Mark-Simulacrum

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. llvm-main Marks PRs that are making Rust work with LLVM main (this label is consumed by CI tooling) labels Dec 21, 2023
@Mark-Simulacrum
Copy link
Member

Sounds right to me. @bors r+

@bors
Copy link
Contributor

bors commented Dec 22, 2023

📌 Commit 58fdbd1 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 22, 2023
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 22, 2023
…iaskrgr

Rollup of 5 pull requests

Successful merges:

 - rust-lang#117601 (Add support for hexagon-unknown-none-elf as target)
 - rust-lang#119169 (Rid the AST & HIR pretty printer of cruft)
 - rust-lang#119194 (Run fuchsia tests only on nightly)
 - rust-lang#119201 (tests: fix overaligned-constant to not over-specify getelementptr instr)
 - rust-lang#119215 (Emits error if has bound regions)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 41fbd25 into rust-lang:master Dec 22, 2023
11 checks passed
@rustbot rustbot added this to the 1.77.0 milestone Dec 22, 2023
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Dec 22, 2023
Rollup merge of rust-lang#119201 - durin42:overaligned-constant, r=Mark-Simulacrum

tests: fix overaligned-constant to not over-specify getelementptr instr

On LLVM 18 we get slightly different arguments here, so it's easier to just regex those away. The important details are all still asserted as I understand things.

Fixes rust-lang#119193.

`@rustbot` label: +llvm-main
@durin42 durin42 deleted the overaligned-constant branch April 12, 2024 15:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
llvm-main Marks PRs that are making Rust work with LLVM main (this label is consumed by CI tooling) S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

New test from #119056 fails on LLVM 18, might be okay?
4 participants