-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add missing feature gate for sanitizer CFI cfgs #119235
Merged
bors
merged 2 commits into
rust-lang:master
from
Urgau:missing-feature-gate-sanitizer-cfi-cfgs
Dec 26, 2023
Merged
Add missing feature gate for sanitizer CFI cfgs #119235
bors
merged 2 commits into
rust-lang:master
from
Urgau:missing-feature-gate-sanitizer-cfi-cfgs
Dec 26, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
r? @wesleywiser (rustbot has picked a reviewer for you, use r? to override) |
rustbot
added
O-unix
Operating system: Unix-like
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
T-libs
Relevant to the library team, which will review and decide on the PR/issue.
labels
Dec 22, 2023
This comment has been minimized.
This comment has been minimized.
Urgau
force-pushed
the
missing-feature-gate-sanitizer-cfi-cfgs
branch
from
December 23, 2023 00:00
6a0a0c2
to
157c6c1
Compare
Urgau
force-pushed
the
missing-feature-gate-sanitizer-cfi-cfgs
branch
from
December 23, 2023 00:01
157c6c1
to
c88b021
Compare
Noratrieb
approved these changes
Dec 26, 2023
@bors r+ rollup |
bors
added
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Dec 26, 2023
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 26, 2023
…mpiler-errors Rollup of 5 pull requests Successful merges: - rust-lang#119235 (Add missing feature gate for sanitizer CFI cfgs) - rust-lang#119240 (Make some non-diagnostic-affecting `QPath::LangItem` into regular `QPath`s) - rust-lang#119297 (Pass DeadItem and lint as consistent group in dead-code.) - rust-lang#119307 (Clean up some lifetimes in `rustc_pattern_analysis`) - rust-lang#119323 (add test for coercing never to infinite type) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Dec 26, 2023
Rollup merge of rust-lang#119235 - Urgau:missing-feature-gate-sanitizer-cfi-cfgs, r=Nilstrieb Add missing feature gate for sanitizer CFI cfgs Found during the review of rust-lang#118494 in rust-lang#118494 (comment). cc `@rcvalle`
Thank you for your time and for working on this, @Urgau! Much appreciated. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
O-unix
Operating system: Unix-like
PG-exploit-mitigations
Project group: Exploit mitigations
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
T-libs
Relevant to the library team, which will review and decide on the PR/issue.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Found during the review of #118494 in #118494 (comment).
cc @rcvalle