Make `negative_bounds` internal & fix some of its issues #119354

fmease · 2023-12-27T18:00:20Z

r? compiler-errors

fmease · 2023-12-27T18:01:04Z

tests/ui/traits/negative-bounds/associated-constraints.rs

@@ -17,4 +16,7 @@ fn test3<T: !Trait<Assoc: Send>>() {}
 fn test4<T>() where T: !Trait<Assoc: Send> {}
 //~^ ERROR associated type constraints not allowed on negative bounds

+fn test5<T>() where T: !Fn() -> i32 {}


This one used to ice with no errors encountered even though `span_delayed_bug` issued // negative trait bounds should not have bindings.

fmease · 2023-12-27T18:03:18Z

tests/ui/traits/negative-bounds/opaque-type-unsatisfied-bound.rs

+fn weird0() -> impl Sized + !Sized {}
+//~^ ERROR mismatched types
+//~| ERROR type mismatch resolving `() == impl !Sized`
+fn weird1() -> impl Sized + !Sized {}
+//~^ ERROR mismatched types
+//~| ERROR type mismatch resolving `() == impl !Sized`
+fn weird2() -> impl !Sized + Sized {}


We elaborate !Sized to !Sized + Sized which is odd and which I guess we should change?

In the pretty printer, I “unelaborate” any Sized bounds even if we have a !Sized bound to mirror rustc_hir_analysis's elab.

!Sized should opt out implicit sized bounds like ?Sized

fmease · 2023-12-28T13:40:19Z

compiler/rustc_hir_analysis/src/astconv/bounds.rs

-            // There was in fact a `?Sized` bound, return without doing anything
-        } else {
-            // There was no `?Sized` bound; add implicitly sized if `Sized` is available.
+        if seen_sized_unbound || seen_negative_sized_bound {


I wonder if I should reject !Sized + ?Sized: (kinda) “redundant ?Sized bound” // “!Sized already opts out of Sized”.

compiler-errors · 2024-01-04T15:37:31Z

@bors r+

bors · 2024-01-04T15:37:35Z

📌 Commit 977546d has been approved by compiler-errors

It is now in the queue for this repository.

compiler-errors · 2024-01-04T22:25:29Z

@bors rollup

…mpiler-errors Make `negative_bounds` internal & fix some of its issues r? compiler-errors

…iaskrgr Rollup of 9 pull requests Successful merges: - rust-lang#117556 (Disallow reference to `static mut` and adding `static_mut_ref` lint) - rust-lang#119354 (Make `negative_bounds` internal & fix some of its issues) - rust-lang#119420 (Handle ForeignItem as TAIT scope.) - rust-lang#119506 (Use `resolutions(()).effective_visiblities` to avoid cycle errors in `report_object_error`) - rust-lang#119566 (Remove `-Zdump-mir-spanview`) - rust-lang#119567 (Remove `-Zreport-delayed-bugs`.) - rust-lang#119577 (Migrate memory overlap check from validator to lint) - rust-lang#119586 ([rustdoc] Fix invalid handling for static method calls in jump to definition feature) - rust-lang#119588 (Move `i586-unknown-netbsd` from tier 2 to tier 3 platform support table) r? `@ghost` `@rustbot` modify labels: rollup

…mpiler-errors Make `negative_bounds` internal & fix some of its issues r? compiler-errors

…llaumeGomez Rollup of 10 pull requests Successful merges: - rust-lang#119354 (Make `negative_bounds` internal & fix some of its issues) - rust-lang#119414 (bootstrap: Move -Clto= setting from Rustc::run to rustc_cargo) - rust-lang#119420 (Handle ForeignItem as TAIT scope.) - rust-lang#119506 (Use `resolutions(()).effective_visiblities` to avoid cycle errors in `report_object_error`) - rust-lang#119538 (Cleanup error handlers: round 5) - rust-lang#119566 (Remove `-Zdump-mir-spanview`) - rust-lang#119567 (Remove `-Zreport-delayed-bugs`.) - rust-lang#119577 (Migrate memory overlap check from validator to lint) - rust-lang#119586 ([rustdoc] Fix invalid handling for static method calls in jump to definition feature) - rust-lang#119588 (Move `i586-unknown-netbsd` from tier 2 to tier 3 platform support table) r? `@ghost` `@rustbot` modify labels: rollup

…mpiler-errors Make `negative_bounds` internal & fix some of its issues r? compiler-errors

…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#118680 (Add support for shell argfiles) - rust-lang#119151 (Hide foreign `#[doc(hidden)]` paths in import suggestions) - rust-lang#119350 (Imply outlives-bounds on lazy type aliases) - rust-lang#119354 (Make `negative_bounds` internal & fix some of its issues) - rust-lang#119506 (Use `resolutions(()).effective_visiblities` to avoid cycle errors in `report_object_error`) - rust-lang#119554 (Fix scoping for let chains in match guards) - rust-lang#119563 (Check yield terminator's resume type in borrowck) - rust-lang#119589 (cstore: Remove unnecessary locking from `CrateMetadata`) r? `@ghost` `@rustbot` modify labels: rollup

…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#119151 (Hide foreign `#[doc(hidden)]` paths in import suggestions) - rust-lang#119350 (Imply outlives-bounds on lazy type aliases) - rust-lang#119354 (Make `negative_bounds` internal & fix some of its issues) - rust-lang#119506 (Use `resolutions(()).effective_visiblities` to avoid cycle errors in `report_object_error`) - rust-lang#119554 (Fix scoping for let chains in match guards) - rust-lang#119563 (Check yield terminator's resume type in borrowck) - rust-lang#119589 (cstore: Remove unnecessary locking from `CrateMetadata`) - rust-lang#119622 (never patterns: Document behavior of never patterns with macros-by-example) r? `@ghost` `@rustbot` modify labels: rollup

Rollup merge of rust-lang#119354 - fmease:negative_bounds-fixes, r=compiler-errors Make `negative_bounds` internal & fix some of its issues r? compiler-errors

rustbot assigned compiler-errors Dec 27, 2023

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 27, 2023

fmease commented Dec 27, 2023

View reviewed changes

fmease changed the title ~~Tweak negative_bound's impl & mark it as internal~~ Tweak negative_bounds's impl & mark it as internal Dec 27, 2023

This comment was marked as resolved.

Sign in to view

This comment has been minimized.

Sign in to view

fmease changed the title ~~Tweak negative_bounds's impl & mark it as internal~~ Tweak negative_bounds's impl & mark the feature as internal Dec 27, 2023

fmease changed the title ~~Tweak negative_bounds's impl & mark the feature as internal~~ Some fixes for negative_bounds & mark the feature as internal Dec 27, 2023

rust-lang deleted a comment from rustbot Dec 27, 2023

fmease force-pushed the negative_bounds-fixes branch from 1ec73ce to 66ab625 Compare December 27, 2023 19:14

fmease added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 27, 2023

fmease force-pushed the negative_bounds-fixes branch from 66ab625 to 9512f23 Compare December 27, 2023 23:36

fmease added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Dec 27, 2023

fmease changed the title ~~Some fixes for negative_bounds & mark the feature as internal~~ Make negative_bounds internal & fix some of its issues Dec 27, 2023

rust-lang deleted a comment from rustbot Dec 27, 2023

fmease added 3 commits December 28, 2023 00:43

Make feature negative_bounds internal

5f56465

Deny parenthetical notation for negative bounds

a251974

Don't elaborate !Sized to !Sized + Sized

32cea61

fmease force-pushed the negative_bounds-fixes branch from 9512f23 to 0f6fc44 Compare December 27, 2023 23:50

rustc_middle: Pretty-print negative bounds correctly

977546d

fmease force-pushed the negative_bounds-fixes branch from 0f6fc44 to 977546d Compare December 27, 2023 23:59

fmease commented Dec 28, 2023

View reviewed changes

compiler-errors approved these changes Jan 4, 2024

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 4, 2024

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jan 5, 2024

Rollup merge of rust-lang#119354 - fmease:negative_bounds-fixes, r=co…

7843807

…mpiler-errors Make `negative_bounds` internal & fix some of its issues r? compiler-errors

matthiaskrgr mentioned this pull request Jan 5, 2024

Rollup of 10 pull requests #119602

Closed

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jan 5, 2024

Rollup merge of rust-lang#119354 - fmease:negative_bounds-fixes, r=co…

eef7457

…mpiler-errors Make `negative_bounds` internal & fix some of its issues r? compiler-errors

matthiaskrgr mentioned this pull request Jan 5, 2024

Rollup of 9 pull requests #119604

Closed

GuillaumeGomez added a commit to GuillaumeGomez/rust that referenced this pull request Jan 5, 2024

Rollup merge of rust-lang#119354 - fmease:negative_bounds-fixes, r=co…

98c9d72

…mpiler-errors Make `negative_bounds` internal & fix some of its issues r? compiler-errors

GuillaumeGomez mentioned this pull request Jan 5, 2024

Rollup of 10 pull requests #119611

Closed

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jan 5, 2024

Rollup merge of rust-lang#119354 - fmease:negative_bounds-fixes, r=co…

81baab6

…mpiler-errors Make `negative_bounds` internal & fix some of its issues r? compiler-errors

matthiaskrgr mentioned this pull request Jan 5, 2024

Rollup of 8 pull requests #119623

Closed

matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jan 5, 2024

Rollup merge of rust-lang#119354 - fmease:negative_bounds-fixes, r=co…

e0c86de

…mpiler-errors Make `negative_bounds` internal & fix some of its issues r? compiler-errors

matthiaskrgr mentioned this pull request Jan 5, 2024

Rollup of 8 pull requests #119630

Closed

matthiaskrgr mentioned this pull request Jan 5, 2024

Rollup of 8 pull requests #119634

Merged

bors merged commit ea61290 into rust-lang:master Jan 5, 2024
11 checks passed

rustbot added this to the 1.77.0 milestone Jan 5, 2024

fmease deleted the negative_bounds-fixes branch January 5, 2024 23:48

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Make `negative_bounds` internal & fix some of its issues #119354

Make `negative_bounds` internal & fix some of its issues #119354

fmease commented Dec 27, 2023 •

edited

Loading

fmease Dec 27, 2023 •

edited

Loading

fmease Dec 27, 2023 •

edited

Loading

compiler-errors Dec 27, 2023

This comment was marked as resolved.

This comment has been minimized.

fmease Dec 28, 2023

compiler-errors commented Jan 4, 2024

bors commented Jan 4, 2024

compiler-errors commented Jan 4, 2024

Make negative_bounds internal & fix some of its issues #119354

Make negative_bounds internal & fix some of its issues #119354

Conversation

fmease commented Dec 27, 2023 • edited Loading

fmease Dec 27, 2023 • edited Loading

Choose a reason for hiding this comment

fmease Dec 27, 2023 • edited Loading

Choose a reason for hiding this comment

compiler-errors Dec 27, 2023

Choose a reason for hiding this comment

This comment was marked as resolved.

This comment has been minimized.

fmease Dec 28, 2023

Choose a reason for hiding this comment

compiler-errors commented Jan 4, 2024

bors commented Jan 4, 2024

compiler-errors commented Jan 4, 2024

Make `negative_bounds` internal & fix some of its issues #119354

Make `negative_bounds` internal & fix some of its issues #119354

fmease commented Dec 27, 2023 •

edited

Loading

fmease Dec 27, 2023 •

edited

Loading

fmease Dec 27, 2023 •

edited

Loading