Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify Parser::ident_or_error #119359

Merged
merged 1 commit into from
Dec 28, 2023
Merged

Simplify Parser::ident_or_error #119359

merged 1 commit into from
Dec 28, 2023

Conversation

DaniPopes
Copy link
Contributor

@DaniPopes DaniPopes commented Dec 27, 2023

Avoid a nested Result<T, PResult<T>>.

@rustbot
Copy link
Collaborator

rustbot commented Dec 27, 2023

r? @cjgillot

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Dec 27, 2023
Avoid a nested `Result<T, PResult<T>>`.
@compiler-errors
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Dec 27, 2023

📌 Commit 826269e has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 27, 2023
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Dec 27, 2023
…-errors

Simplify Parser::ident_or_error

Avoid a nested `Result<T, PResult<T>>`.
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 27, 2023
…iaskrgr

Rollup of 3 pull requests

Successful merges:

 - rust-lang#119336 (coverage: Unexpand spans with `find_ancestor_inside_same_ctxt`)
 - rust-lang#119349 (refactor(liveness): move walk_expr outside of every match branch)
 - rust-lang#119359 (Simplify Parser::ident_or_error)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors
Copy link
Contributor

bors commented Dec 28, 2023

⌛ Testing commit 826269e with merge ac8316e...

bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 28, 2023
…rrors

Simplify Parser::ident_or_error

Avoid a nested `Result<T, PResult<T>>`.
@bors
Copy link
Contributor

bors commented Dec 28, 2023

💥 Test timed out

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Dec 28, 2023
@rust-log-analyzer
Copy link
Collaborator

A job failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@compiler-errors
Copy link
Member

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Dec 28, 2023
bors added a commit to rust-lang-ci/rust that referenced this pull request Dec 28, 2023
…iaskrgr

Rollup of 5 pull requests

Successful merges:

 - rust-lang#119331 (rustdoc-search: count path edits with separate edit limit)
 - rust-lang#119359 (Simplify Parser::ident_or_error)
 - rust-lang#119376 (Add regression test for rust-lang#106630)
 - rust-lang#119379 (Update `parse_seq` doc)
 - rust-lang#119380 (Don't suggest writing a bodyless arm if the pattern can never be a never pattern)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 54bcb07 into rust-lang:master Dec 28, 2023
11 of 12 checks passed
@rustbot rustbot added this to the 1.77.0 milestone Dec 28, 2023
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Dec 28, 2023
Rollup merge of rust-lang#119359 - DaniPopes:ident-or-err, r=compiler-errors

Simplify Parser::ident_or_error

Avoid a nested `Result<T, PResult<T>>`.
@DaniPopes DaniPopes deleted the ident-or-err branch December 28, 2023 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants