Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix error counting #119986

Merged
merged 3 commits into from
Jan 22, 2024
Merged

Fix error counting #119986

merged 3 commits into from
Jan 22, 2024

Commits on Jan 21, 2024

  1. Clarify comments about diagnostic count fields.

    @nnethercote
    nnethercote committed Jan 21, 2024
    Configuration menu
    Copy the full SHA
    f00c088 View commit details
    Browse the repository at this point in the history

  2. Count "unused extern" errors as lints rather than normal errors.

    @nnethercote
    nnethercote committed Jan 21, 2024
    Configuration menu
    Copy the full SHA
    807c868 View commit details
    Browse the repository at this point in the history

  3. Tweak error counting. 

    We have several methods indicating the presence of errors, lint errors,
and delayed bugs. I find it frustrating that it's very unclear which one
you should use in any particular spot. This commit attempts to instill a
basic principle of "use the least general one possible", because that
reflects reality in practice -- `has_errors` is the least general one
and has by far the most uses (esp. via `abort_if_errors`).

Specifics:
- Add some comments giving some usage guidelines.
- Prefer `has_errors` to comparing `err_count` to zero.
- Remove `has_errors_or_span_delayed_bugs` because it's a weird one: in
  the cases where we need to count delayed bugs, we should really be
  counting lint errors as well.
- Rename `is_compilation_going_to_fail` as
  `has_errors_or_lint_errors_or_span_delayed_bugs`, for consistency with
  `has_errors` and `has_errors_or_lint_errors`.
- Change a few other `has_errors_or_lint_errors` calls to `has_errors`,
  as per the "least general" principle.

This didn't turn out to be as neat as I hoped when I started, but I
think it's still an improvement.
    @nnethercote
    nnethercote committed Jan 21, 2024
    Configuration menu
    Copy the full SHA
    1f9fa23 View commit details
    Browse the repository at this point in the history