Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Experiment: lint resetting mut bindings #120095

Closed
wants to merge 3 commits into from
Closed

Experiment: lint resetting mut bindings #120095

wants to merge 3 commits into from

Conversation

Nadrieril
Copy link
Member

We would like to fix #105647 in rust 2024. To evaluate the breakage, I wrote a lint that detects the cases where there would be a difference between now and rust 2024.

I'd like to request a crater run with dereferencing_mut_binding set to deny to see how many crates would be affected.

@rustbot
Copy link
Collaborator

rustbot commented Jan 18, 2024

r? @b-naber

(rustbot has picked a reviewer for you, use r? to override)

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Jan 18, 2024
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@rust-log-analyzer

This comment has been minimized.

Sign in to view
@Noratrieb
Copy link
Member

@bors try

bors added a commit to rust-lang-ci/rust that referenced this pull request Jan 18, 2024
@bors
Auto merge of rust-lang#120095 - Nadrieril:lint-resetting-mut, r=<try>
047472f 
Experiment: lint resetting `mut` bindings

We would like to fix rust-lang#105647 in rust 2024. To evaluate the breakage, I wrote a lint that detects the cases where there would be a difference between now and rust 2024.

I'd like to request a crater run with `dereferencing_mut_binding` set to `deny` to see how many crates would be affected.
@bors
Copy link
Contributor

bors commented Jan 18, 2024

⌛ Trying commit ce7328b with merge 047472f...

@bors
Copy link
Contributor

bors commented Jan 18, 2024

☀️ Try build successful - checks-actions
Build commit: 047472f (047472f299946caf090d1b5608ae4bd9f0416256)

@Nadrieril
Copy link
Member Author

@craterbot run mode=check-only start=master#8424f8e8cdf07010967a57584fd647b30e930d4d end=try#047472f299946caf090d1b5608ae4bd9f0416256+rustflags=-Ddereferencing_mut_binding

@craterbot
Copy link
Collaborator

👌 Experiment pr-120095 created and queued.
🔍 You can check out the queue and this experiment's details.

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-crater Status: Waiting on a crater run to be completed. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 18, 2024
@craterbot
Copy link
Collaborator

🚧 Experiment pr-120095 is now running

ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot
Copy link
Collaborator

🎉 Experiment pr-120095 is completed!
📊 397 regressed and 3 fixed (409084 total)
📰 Open the full report.

⚠️ If you notice any spurious failure please add them to the blacklist!
ℹ️ Crater is a tool to run experiments across parts of the Rust ecosystem. Learn more

@craterbot craterbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-crater Status: Waiting on a crater run to be completed. labels Jan 21, 2024
@Nadrieril
Copy link
Member Author

Looking through it, that's indeed ~400 failures due to the lint, and seems to be a decent number failing because they depend on a failing crate. I don't know if that's a lot all things considered. I expected worse

@Nadrieril Nadrieril mentioned this pull request Feb 11, 2024
Open
@Nadrieril Nadrieril removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 4, 2024
@Jules-Bertholet Jules-Bertholet mentioned this pull request Mar 24, 2024
Closed
11 tasks
@Dylan-DPC Dylan-DPC added the S-experimental Status: Ongoing experiment that does not require reviewing and won't be merged in its current state. label Apr 24, 2024
@Nadrieril
Copy link
Member Author

Superceded by #123076

@Nadrieril Nadrieril closed this May 2, 2024
@Nadrieril Nadrieril deleted the lint-resetting-mut branch July 20, 2024 10:38
SifraiTeam pushed a commit to grandinetech/grandine that referenced this pull request Sep 6, 2024
@weekday-grandine-io
Rust 1.79.0: Enable new rustc lints
43a1e53 
dereferencing_mut_binding was added in Rust 1.79.0 as an experiment and removed in Rust 1.80.0.
See:
- https://doc.rust-lang.org/1.79.0/rustc/lints/listing/allowed-by-default.html#dereferencing-mut-binding
- rust-lang/rust#120095
- rust-lang/rust#123076
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@b-naber b-naber

Labels
S-experimental Status: Ongoing experiment that does not require reviewing and won't be merged in its current state. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

mut keyword alone unexpectedly dereferences value in pattern matching
8 participants
@Nadrieril @rustbot @rust-log-analyzer @Noratrieb @bors @craterbot @b-naber @Dylan-DPC