Bump Fuchsia, build tests, and use 8 core bots #120358

tmandry · 2024-01-26T00:46:22Z

Build Fuchsia on 8 cores instead of 16
Skip building cranelift for Fuchsia
Bump Fuchsia (includes building tests)

This includes a change to the upstream build_fuchsia_from_rust_ci script that builds a minimal set of tests, to improve coverage on this builder. This would have caught rust-lang/rust-clippy#11952 and #119593.

See prior discussion on #119400 about building on 8 cores instead of 16. This PR combines changes from that and #119399, plus clean up.

r? @Mark-Simulacrum

tmandry · 2024-01-26T00:46:47Z

@bors try

Bump Fuchsia, build tests, and use 8 core bots - Build Fuchsia on 8 cores instead of 16 - Skip building cranelift for Fuchsia - Bump Fuchsia (includes building tests) This includes a change to the upstream build_fuchsia_from_rust_ci script that builds a minimal set of tests, to improve coverage on this builder. See prior discussion on rust-lang#119400 about building on 8 cores instead of 16. This PR combines changes from that and rust-lang#119399, plus clean up. r? `@Mark-Simulacrum`

src/ci/docker/host-x86_64/x86_64-gnu-integration/Dockerfile

This refactors run.sh to never override an explicit $CODEGEN_BACKENDS if set in the build.

This includes a change to the upstream build_fuchsia_from_rust_ci script that builds a minimal set of tests, to improve coverage on this builder.

tmandry · 2024-01-26T21:10:00Z

@bors try

bors · 2024-01-26T21:11:11Z

⌛ Trying commit 4adc382 with merge 4134524...

Bump Fuchsia, build tests, and use 8 core bots - Build Fuchsia on 8 cores instead of 16 - Skip building cranelift for Fuchsia - Bump Fuchsia (includes building tests) This includes a change to the upstream build_fuchsia_from_rust_ci script that builds a minimal set of tests, to improve coverage on this builder. See prior discussion on rust-lang#119400 about building on 8 cores instead of 16. This PR combines changes from that and rust-lang#119399, plus clean up. r? `@Mark-Simulacrum`

bors · 2024-01-26T22:26:25Z

☀️ Try build successful - checks-actions
Build commit: 4134524 (41345246f62a323d44ebd8d55f3298f1bdb5f8ca)

tmandry · 2024-01-26T23:14:38Z

This should be ready. The job now takes about 1hr 15m, which is at least 30m less than the long pole.

tmandry · 2024-01-26T23:20:41Z

@rustbot ready

Mark-Simulacrum · 2024-01-27T16:06:45Z

@bors r+

bors · 2024-01-27T16:06:47Z

📌 Commit afd5edc has been approved by Mark-Simulacrum

It is now in the queue for this repository.

…ark-Simulacrum Bump Fuchsia, build tests, and use 8 core bots - Build Fuchsia on 8 cores instead of 16 - Skip building cranelift for Fuchsia - Bump Fuchsia (includes building tests) This includes a change to the upstream build_fuchsia_from_rust_ci script that builds a minimal set of tests, to improve coverage on this builder. This would have caught rust-lang/rust-clippy#11952 and rust-lang#119593. See prior discussion on rust-lang#119400 about building on 8 cores instead of 16. This PR combines changes from that and rust-lang#119399, plus clean up. r? `@Mark-Simulacrum`

…iaskrgr Rollup of 7 pull requests Successful merges: - rust-lang#120172 (bootstrap: add more unit tests) - rust-lang#120266 (Improve documentation for [A]Rc::into_inner) - rust-lang#120358 (Bump Fuchsia, build tests, and use 8 core bots) - rust-lang#120373 (Adjust Behaviour of `read_dir` and `ReadDir` in Windows Implementation: Check Whether Path to Search In Exists) - rust-lang#120376 (Update codegen test for LLVM 18) - rust-lang#120420 (Stop using derivative in rustc_pattern_analysis) - rust-lang#120425 (Remove unnecessary unit returns in query declarations) r? `@ghost` `@rustbot` modify labels: rollup

…ark-Simulacrum Bump Fuchsia, build tests, and use 8 core bots - Build Fuchsia on 8 cores instead of 16 - Skip building cranelift for Fuchsia - Bump Fuchsia (includes building tests) This includes a change to the upstream build_fuchsia_from_rust_ci script that builds a minimal set of tests, to improve coverage on this builder. This would have caught rust-lang/rust-clippy#11952 and rust-lang#119593. See prior discussion on rust-lang#119400 about building on 8 cores instead of 16. This PR combines changes from that and rust-lang#119399, plus clean up. r? ``@Mark-Simulacrum``

…ark-Simulacrum Bump Fuchsia, build tests, and use 8 core bots - Build Fuchsia on 8 cores instead of 16 - Skip building cranelift for Fuchsia - Bump Fuchsia (includes building tests) This includes a change to the upstream build_fuchsia_from_rust_ci script that builds a minimal set of tests, to improve coverage on this builder. This would have caught rust-lang/rust-clippy#11952 and rust-lang#119593. See prior discussion on rust-lang#119400 about building on 8 cores instead of 16. This PR combines changes from that and rust-lang#119399, plus clean up. r? ```@Mark-Simulacrum```

…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#116677 (References refer to allocated objects) - rust-lang#120232 (Add support for custom JSON targets when using build-std.) - rust-lang#120266 (Improve documentation for [A]Rc::into_inner) - rust-lang#120358 (Bump Fuchsia, build tests, and use 8 core bots) - rust-lang#120373 (Adjust Behaviour of `read_dir` and `ReadDir` in Windows Implementation: Check Whether Path to Search In Exists) - rust-lang#120402 (Make the coroutine def id of an async closure the child of the closure def id) - rust-lang#120420 (Stop using derivative in rustc_pattern_analysis) - rust-lang#120425 (Remove unnecessary unit returns in query declarations) r? `@ghost` `@rustbot` modify labels: rollup

…ark-Simulacrum Bump Fuchsia, build tests, and use 8 core bots - Build Fuchsia on 8 cores instead of 16 - Skip building cranelift for Fuchsia - Bump Fuchsia (includes building tests) This includes a change to the upstream build_fuchsia_from_rust_ci script that builds a minimal set of tests, to improve coverage on this builder. This would have caught rust-lang/rust-clippy#11952 and rust-lang#119593. See prior discussion on rust-lang#119400 about building on 8 cores instead of 16. This PR combines changes from that and rust-lang#119399, plus clean up. r? ````@Mark-Simulacrum````

…iaskrgr Rollup of 5 pull requests Successful merges: - rust-lang#120358 (Bump Fuchsia, build tests, and use 8 core bots) - rust-lang#120402 (Make the coroutine def id of an async closure the child of the closure def id) - rust-lang#120420 (Stop using derivative in rustc_pattern_analysis) - rust-lang#120425 (Remove unnecessary unit returns in query declarations) - rust-lang#120428 (hir: Two preparatory changes for rust-lang#120206) r? `@ghost` `@rustbot` modify labels: rollup

…ark-Simulacrum Bump Fuchsia, build tests, and use 8 core bots - Build Fuchsia on 8 cores instead of 16 - Skip building cranelift for Fuchsia - Bump Fuchsia (includes building tests) This includes a change to the upstream build_fuchsia_from_rust_ci script that builds a minimal set of tests, to improve coverage on this builder. This would have caught rust-lang/rust-clippy#11952 and rust-lang#119593. See prior discussion on rust-lang#119400 about building on 8 cores instead of 16. This PR combines changes from that and rust-lang#119399, plus clean up. r? `````@Mark-Simulacrum`````

…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#116677 (References refer to allocated objects) - rust-lang#118533 (Suppress unhelpful diagnostics for unresolved top level attributes) - rust-lang#119991 (Reject infinitely-sized reads from io::Repeat) - rust-lang#120232 (Add support for custom JSON targets when using build-std.) - rust-lang#120358 (Bump Fuchsia, build tests, and use 8 core bots) - rust-lang#120424 (raw pointer metadata API: data address -> data pointer) - rust-lang#120434 (Revert outdated version of "Add the wasm32-wasi-preview2 target") - rust-lang#120443 (Fixes footnote handling in rustdoc) r? `@ghost` `@rustbot` modify labels: rollup

…iaskrgr Rollup of 5 pull requests Successful merges: - rust-lang#120358 (Bump Fuchsia, build tests, and use 8 core bots) - rust-lang#120402 (Make the coroutine def id of an async closure the child of the closure def id) - rust-lang#120420 (Stop using derivative in rustc_pattern_analysis) - rust-lang#120425 (Remove unnecessary unit returns in query declarations) - rust-lang#120428 (hir: Two preparatory changes for rust-lang#120206) r? `@ghost` `@rustbot` modify labels: rollup

bors · 2024-01-31T07:40:05Z

⌛ Testing commit afd5edc with merge cdaa12e...

bors · 2024-01-31T09:43:52Z

☀️ Test successful - checks-actions
Approved by: Mark-Simulacrum
Pushing cdaa12e to master...

rust-timer · 2024-01-31T10:58:11Z

Finished benchmarking commit (cdaa12e): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-2.6%	[-2.6%, -2.6%]	1
Improvements ✅ (secondary)	-2.2%	[-2.7%, -1.4%]	5
All ❌✅ (primary)	-2.6%	[-2.6%, -2.6%]	1

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.0%	[1.0%, 1.0%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	1.0%	[1.0%, 1.0%]	1

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 661.023s -> 661.871s (0.13%)
Artifact size: 308.12 MiB -> 308.09 MiB (-0.01%)

rustbot assigned Mark-Simulacrum Jan 26, 2024

rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-infra Relevant to the infrastructure team, which will review and decide on the PR/issue. labels Jan 26, 2024

This was referenced Jan 26, 2024

Build Fuchsia tests in CI #119399

Closed

Build Fuchsia on 8 cores instead of 16 #119400

Closed

This comment was marked as outdated.

Sign in to view

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jan 26, 2024

bjorn3 reviewed Jan 26, 2024

View reviewed changes

src/ci/docker/host-x86_64/x86_64-gnu-integration/Dockerfile Show resolved Hide resolved

tmandry added 3 commits January 26, 2024 13:09

Build Fuchsia on 8 cores instead of 16

40f5e68

Skip building cranelift for Fuchsia

53bf511

This refactors run.sh to never override an explicit $CODEGEN_BACKENDS if set in the build.

Bump Fuchsia (includes building tests)

afd5edc

This includes a change to the upstream build_fuchsia_from_rust_ci script that builds a minimal set of tests, to improve coverage on this builder.

tmandry force-pushed the bump-fuchsia-8c-tests branch from 3ff836e to 4adc382 Compare January 26, 2024 21:09

tmandry force-pushed the bump-fuchsia-8c-tests branch from 4adc382 to afd5edc Compare January 26, 2024 23:13

tmandry marked this pull request as ready for review January 26, 2024 23:13

rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jan 26, 2024

bors removed the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jan 27, 2024

bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jan 27, 2024

matthiaskrgr mentioned this pull request Jan 27, 2024

Rollup of 7 pull requests #120429

Closed

matthiaskrgr mentioned this pull request Jan 27, 2024

Rollup of 10 pull requests #120431

Closed

matthiaskrgr mentioned this pull request Jan 27, 2024

Rollup of 8 pull requests #120432

Closed

matthiaskrgr mentioned this pull request Jan 28, 2024

Rollup of 5 pull requests #120437

Closed

matthiaskrgr mentioned this pull request Jan 28, 2024

Rollup of 8 pull requests #120448

Closed

bors added the merged-by-bors This PR was explicitly merged by bors. label Jan 31, 2024

bors merged commit cdaa12e into rust-lang:master Jan 31, 2024
12 checks passed

rustbot added this to the 1.77.0 milestone Jan 31, 2024

tmandry deleted the bump-fuchsia-8c-tests branch February 1, 2024 18:02

workingjubilee added the O-fuchsia Operating system: Fuchsia label May 4, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Bump Fuchsia, build tests, and use 8 core bots #120358

Bump Fuchsia, build tests, and use 8 core bots #120358

tmandry commented Jan 26, 2024 •

edited

Loading

tmandry commented Jan 26, 2024

This comment was marked as outdated.

This comment was marked as outdated.

tmandry commented Jan 26, 2024

bors commented Jan 26, 2024

bors commented Jan 26, 2024

tmandry commented Jan 26, 2024

tmandry commented Jan 26, 2024

Mark-Simulacrum commented Jan 27, 2024

bors commented Jan 27, 2024

bors commented Jan 31, 2024

bors commented Jan 31, 2024

rust-timer commented Jan 31, 2024

Bump Fuchsia, build tests, and use 8 core bots #120358

Bump Fuchsia, build tests, and use 8 core bots #120358

Conversation

tmandry commented Jan 26, 2024 • edited Loading

tmandry commented Jan 26, 2024

This comment was marked as outdated.

This comment was marked as outdated.

tmandry commented Jan 26, 2024

bors commented Jan 26, 2024

bors commented Jan 26, 2024

tmandry commented Jan 26, 2024

tmandry commented Jan 26, 2024

Mark-Simulacrum commented Jan 27, 2024

bors commented Jan 27, 2024

bors commented Jan 31, 2024

bors commented Jan 31, 2024

rust-timer commented Jan 31, 2024

Overall result: no relevant changes - no action needed

Instruction count

Max RSS (memory usage)

Cycles

Binary size

tmandry commented Jan 26, 2024 •

edited

Loading