-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Give some intrinsics fallback bodies #121192
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot has assigned @Mark-Simulacrum. Use r? to explicitly pick a reviewer |
rustbot
added
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
T-libs
Relevant to the library team, which will review and decide on the PR/issue.
labels
Feb 16, 2024
r? WaffleLapkin |
oli-obk
force-pushed
the
intrinsics2.0
branch
from
February 16, 2024 21:01
7b17521
to
e722949
Compare
This comment has been minimized.
This comment has been minimized.
oli-obk
force-pushed
the
intrinsics2.0
branch
from
February 16, 2024 22:26
e722949
to
dd40a80
Compare
WaffleLapkin
approved these changes
Feb 16, 2024
@bors r+ rollup |
bors
added
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Feb 16, 2024
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 17, 2024
Rollup of 8 pull requests Successful merges: - rust-lang#119032 (Use a hardcoded constant instead of calling OpenProcessToken.) - rust-lang#120932 (const_mut_refs: allow mutable pointers to statics) - rust-lang#121059 (Add and use a simple extension trait derive macro in the compiler) - rust-lang#121135 (coverage: Discard spans that fill the entire function body) - rust-lang#121187 (Add examples to document the return type of quickselect functions) - rust-lang#121191 (Add myself to review rotation (and a rustbot ping)) - rust-lang#121192 (Give some intrinsics fallback bodies) - rust-lang#121197 (Ensure `./configure` works when `configure.py` path contains spaces) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 17, 2024
Rollup merge of rust-lang#121192 - oli-obk:intrinsics2.0, r=WaffleLapkin Give some intrinsics fallback bodies cc rust-lang#93145
celinval
added a commit
to celinval/rust-dev
that referenced
this pull request
Jul 4, 2024
Move a few more intrinsic functions to the convention added in rust-lang#121192 where they have Rust abi but are tagged with `rustc_intrinsic`. Additionally, document their safety requirements.
celinval
added a commit
to celinval/rust-dev
that referenced
this pull request
Jul 4, 2024
Move a few more intrinsic functions to the convention added in rust-lang#121192 where they have Rust abi but are tagged with `rustc_intrinsic`.
celinval
added a commit
to celinval/rust-dev
that referenced
this pull request
Jul 4, 2024
Move a few more intrinsic functions to the convention added in rust-lang#121192 where they have Rust abi but are tagged with `rustc_intrinsic`.
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Jul 17, 2024
…i-obk Move a few intrinsics to Rust abi Move a few more intrinsic functions to the convention added in rust-lang#121192. In the second commit, I added documentation about their safety requirements. Let me know if you would like me to move the second commit to a different PR. Note: I kept the same signature of `pref_align_of`, but I was wondering why this function is considered unsafe?
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 18, 2024
Rollup merge of rust-lang#127337 - celinval:intrinsics-fallback, r=oli-obk Move a few intrinsics to Rust abi Move a few more intrinsic functions to the convention added in rust-lang#121192. In the second commit, I added documentation about their safety requirements. Let me know if you would like me to move the second commit to a different PR. Note: I kept the same signature of `pref_align_of`, but I was wondering why this function is considered unsafe?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
T-compiler
Relevant to the compiler team, which will review and decide on the PR/issue.
T-libs
Relevant to the library team, which will review and decide on the PR/issue.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
cc #93145