-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bump some deps #121265
bump some deps #121265
Conversation
rustbot has assigned @Mark-Simulacrum. Use r? to explicitly pick a reviewer |
These commits modify the If this was unintentional then you should revert the changes before this PR is merged. |
// FIXME can panic here | ||
CloseHandle(self.0).unwrap(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Previously error here was ignored, now unwrap
s, still better.
// FIXME can panic here | ||
ReleaseMutex((self.0).0).unwrap(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same.
This comment has been minimized.
This comment has been minimized.
The list of allowed third-party dependencies may have been modified! You must ensure that any new dependencies have compatible licenses before merging. |
@bors r+ rollup=iffy |
☀️ Test successful - checks-actions |
Finished benchmarking commit (c9c83cc): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 640.087s -> 641.367s (0.20%) |
First commit dedupes darling* crates and remove one more syn 1.* dep
Second one bumps windows crate to 0.52