Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delayed bug audit #121285

Merged
merged 7 commits into from
Feb 27, 2024
Merged

Delayed bug audit #121285

merged 7 commits into from
Feb 27, 2024

Commits on Feb 27, 2024

  1. Remove an unnecessary span_delayed_bug call.

    The existing code calls a function that returns `Result<_,
    ErrorGuaranteed>`, and then calls `span_delayed_bug` pointlessly in the
    `Err` case.
    nnethercote committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    2fc94ce View commit details
    Browse the repository at this point in the history
  2. Refactor LoweringContext::get_delegation_sig_id.

    I find the function much easier to read this way. Thanks to @kadiwa4 for
    the suggestion.
    nnethercote committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    c743e4a View commit details
    Browse the repository at this point in the history
  3. Remove an unnecessary span_delayed_bug in `Resolver::valid_res_from…

    …_ribs`.
    
    `Resolver::report_error` always emits (this commit makes that clearer),
    so the `span_delayed_bug` is unnecessary.
    nnethercote committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    d0267cb View commit details
    Browse the repository at this point in the history
  4. Avoid span_delayed_bug on one path in AdtDef::eval_explicit_discr.

    Also change its return type to `Result`.
    nnethercote committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    b2d1d6f View commit details
    Browse the repository at this point in the history
  5. Avoid a span_delayed_bug in TypeErrCtxt::report_region_errors.

    By returning error guarantees from a few functions it relies on.
    nnethercote committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    9f82563 View commit details
    Browse the repository at this point in the history
  6. Avoid a span_delayed_bug in compute_regions.

    By storing error guarantees in `RegionErrors`.
    nnethercote committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    62b4e55 View commit details
    Browse the repository at this point in the history
  7. Refactor take_for_recovery call sites.

    To make them more concise and similar to each other.
    nnethercote committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    a8a486c View commit details
    Browse the repository at this point in the history