Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reduce alignment of TypeId to u64 alignment #121358

Merged
merged 3 commits into from
Mar 9, 2024
Merged

Reduce alignment of TypeId to u64 alignment #121358

merged 3 commits into from
Mar 9, 2024

Conversation

GnomedDev
Copy link
Contributor

Closes #115620

@rustbot
Copy link
Collaborator

rustbot commented Feb 20, 2024

r? @Mark-Simulacrum

rustbot has assigned @Mark-Simulacrum.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Feb 20, 2024
Noratrieb
Noratrieb reviewed Feb 20, 2024
View reviewed changes
library/core/src/any.rs Outdated Show resolved Hide resolved
@GnomedDev @Noratrieb
Add extra detail to field comment
aa25c48 
Co-authored-by: Nilstrieb <48135649+Nilstrieb@users.noreply.github.com>
@lygstate
Copy link
Contributor

we can use (u32,u32,u32,u32) to reduce more alignment

@Mark-Simulacrum
Copy link
Member

I think two u64s is probably as far as I'd want to go with this, rather than e.g. [u8; 16].

@Mark-Simulacrum Mark-Simulacrum added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 24, 2024
@GnomedDev
Copy link
Contributor Author

Fixed the Hash impl not following the comment. @rustbot review

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Feb 25, 2024
@Mark-Simulacrum
Copy link
Member

@bors r+ rollup

@bors
Copy link
Contributor

bors commented Mar 9, 2024

📌 Commit f142476 has been approved by Mark-Simulacrum

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 9, 2024
@matthiaskrgr matthiaskrgr mentioned this pull request Mar 9, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Mar 9, 2024
@bors
Auto merge of rust-lang#122241 - matthiaskrgr:rollup-r8q87ok, r=matth…
8401645 
…iaskrgr

Rollup of 12 pull requests

Successful merges:

 - rust-lang#121358 (Reduce alignment of TypeId to u64 alignment)
 - rust-lang#121813 (Misc improvements to non local defs lint implementation)
 - rust-lang#122160 (Eagerly translate `HelpUseLatestEdition` in parser diagnostics)
 - rust-lang#122178 (ci: add a runner for vanilla LLVM 18)
 - rust-lang#122187 (Move metadata header and version checks together)
 - rust-lang#122209 (fix incorrect path resolution in tidy)
 - rust-lang#122215 (Some tweaks to the parallel query cycle handler)
 - rust-lang#122223 (Fix typo in `VisitorResult`)
 - rust-lang#122224 (Add missing regression tests)
 - rust-lang#122232 (library/core: fix a comment, and a cfg(miri) warning)
 - rust-lang#122233 (miri: do not apply aliasing restrictions to Box with custom allocator)
 - rust-lang#122237 (Remove `Ord` from `ClosureKind`)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit a1f6191 into rust-lang:master Mar 9, 2024
11 checks passed
@rustbot rustbot added this to the 1.78.0 milestone Mar 9, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Mar 9, 2024
@rust-timer
Unrolled build for rust-lang#121358
23bd32c 
Rollup merge of rust-lang#121358 - GnomedDev:lower-align-typeid, r=Mark-Simulacrum

Reduce alignment of TypeId to u64 alignment

Closes rust-lang#115620
@GnomedDev GnomedDev deleted the lower-align-typeid branch March 9, 2024 19:19
tgross35 added a commit to tgross35/rust that referenced this pull request Jun 29, 2024
@tgross35
Print TypeId as a u128 for Debug
15a6488 
Since <rust-lang#121358>, `TypeId` is
represented as a `(u64, u64)`. This also made the debug implementation a
lot larger, which is especially apparent with pretty formatting.

Change this to convert the inner value back to a `u128` and then print
as a tuple struct to make this less noisy.

Current:

    TypeId { t: (1403077013027291752, 4518903163082958039) }
    TypeId {
        t: (
            1403077013027291752,
            4518903163082958039,
        ),
    }

New:

    TypeId(25882202575019293479932656973818029271)
    TypeId(
        25882202575019293479932656973818029271,
    )
tgross35 added a commit to tgross35/rust that referenced this pull request Jun 29, 2024
@tgross35
Print TypeId as a u128 for Debug
158ea64 
Since <rust-lang#121358>, `TypeId` is
represented as a `(u64, u64)`. This also made the debug implementation a
lot larger, which is especially apparent with pretty formatting.

Change this to convert the inner value back to a `u128` and then print
as a tuple struct to make this less noisy.

Current:

    TypeId { t: (1403077013027291752, 4518903163082958039) }
    TypeId {
        t: (
            1403077013027291752,
            4518903163082958039,
        ),
    }

New:

    TypeId(25882202575019293479932656973818029271)
    TypeId(
        25882202575019293479932656973818029271,
    )
tgross35 added a commit to tgross35/rust that referenced this pull request Jun 29, 2024
@tgross35
Print TypeId as a u128 for Debug
8d5b4ef 
Since <rust-lang#121358>, `TypeId` is
represented as a `(u64, u64)`. This also made the debug implementation a
lot larger, which is especially apparent with pretty formatting.

Change this to convert the inner value back to a `u128` and then print
as a tuple struct to make this less noisy.

Current:

    TypeId { t: (1403077013027291752, 4518903163082958039) }
    TypeId {
        t: (
            1403077013027291752,
            4518903163082958039,
        ),
    }

New:

    TypeId(25882202575019293479932656973818029271)
    TypeId(
        25882202575019293479932656973818029271,
    )
tgross35 added a commit to tgross35/rust that referenced this pull request Jun 29, 2024
@tgross35
Print TypeId as a u128 for Debug
682e7c1 
Since <rust-lang#121358>, `TypeId` is
represented as a `(u64, u64)`. This also made the debug implementation a
lot larger, which is especially apparent with pretty formatting.

Make this less noisy by converting the inner value back to a `u128` then
printing as a tuple struct.

Current:

    TypeId { t: (1403077013027291752, 4518903163082958039) }
    TypeId {
        t: (
            1403077013027291752,
            4518903163082958039,
        ),
    }

New:

    TypeId(25882202575019293479932656973818029271)
    TypeId(
        25882202575019293479932656973818029271,
    )
@tgross35 tgross35 mentioned this pull request Jun 29, 2024
Merged
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jun 30, 2024
@matthiaskrgr
Rollup merge of rust-lang#127134 - tgross35:typeid-debug, r=Nilstrieb
865788e 
Print `TypeId` as a `u128` for `Debug`

Since <rust-lang#121358>, `TypeId` is represented as a `(u64, u64)`. This also made the debug implementation a lot larger, which is especially apparent with pretty formatting.

Change this to convert the inner value back to a `u128` and then print as a tuple struct to make this less noisy.

Current:

    TypeId { t: (1403077013027291752, 4518903163082958039) }
    TypeId {
        t: (
            1403077013027291752,
            4518903163082958039,
        ),
    }

New:

    TypeId(25882202575019293479932656973818029271)
    TypeId(
        25882202575019293479932656973818029271,
    )
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jun 30, 2024
@matthiaskrgr
Rollup merge of rust-lang#127134 - tgross35:typeid-debug, r=Nilstrieb
5d7da40 
Print `TypeId` as a `u128` for `Debug`

Since <rust-lang#121358>, `TypeId` is represented as a `(u64, u64)`. This also made the debug implementation a lot larger, which is especially apparent with pretty formatting.

Change this to convert the inner value back to a `u128` and then print as a tuple struct to make this less noisy.

Current:

    TypeId { t: (1403077013027291752, 4518903163082958039) }
    TypeId {
        t: (
            1403077013027291752,
            4518903163082958039,
        ),
    }

New:

    TypeId(25882202575019293479932656973818029271)
    TypeId(
        25882202575019293479932656973818029271,
    )
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Jun 30, 2024
@matthiaskrgr
Rollup merge of rust-lang#127134 - tgross35:typeid-debug, r=Nilstrieb
f2c287f 
Print `TypeId` as a `u128` for `Debug`

Since <rust-lang#121358>, `TypeId` is represented as a `(u64, u64)`. This also made the debug implementation a lot larger, which is especially apparent with pretty formatting.

Change this to convert the inner value back to a `u128` and then print as a tuple struct to make this less noisy.

Current:

    TypeId { t: (1403077013027291752, 4518903163082958039) }
    TypeId {
        t: (
            1403077013027291752,
            4518903163082958039,
        ),
    }

New:

    TypeId(25882202575019293479932656973818029271)
    TypeId(
        25882202575019293479932656973818029271,
    )
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Jun 30, 2024
@rust-timer
Unrolled build for rust-lang#127134
62545d6 
Rollup merge of rust-lang#127134 - tgross35:typeid-debug, r=Nilstrieb

Print `TypeId` as a `u128` for `Debug`

Since <rust-lang#121358>, `TypeId` is represented as a `(u64, u64)`. This also made the debug implementation a lot larger, which is especially apparent with pretty formatting.

Change this to convert the inner value back to a `u128` and then print as a tuple struct to make this less noisy.

Current:

    TypeId { t: (1403077013027291752, 4518903163082958039) }
    TypeId {
        t: (
            1403077013027291752,
            4518903163082958039,
        ),
    }

New:

    TypeId(25882202575019293479932656973818029271)
    TypeId(
        25882202575019293479932656973818029271,
    )
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Noratrieb Noratrieb Noratrieb left review comments

@Mark-Simulacrum Mark-Simulacrum Mark-Simulacrum left review comments

Assignees

@Mark-Simulacrum Mark-Simulacrum

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.78.0
Development

Successfully merging this pull request may close these issues.

TypeId should be (u64, u64) instead of u128 to save space
6 participants
@GnomedDev @rustbot @lygstate @Mark-Simulacrum @bors @Noratrieb