Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move as many tests from tests/ui/numbers-arithmetic to tests/ui/lint as possible #121432

Merged
merged 2 commits into from
Feb 23, 2024
Merged

Move as many tests from tests/ui/numbers-arithmetic to tests/ui/lint as possible #121432

merged 2 commits into from
Feb 23, 2024

Conversation

mj10021
Copy link
Contributor

@mj10021 mj10021 commented Feb 22, 2024

Fixes #119851 , and also consolidates as many individual tests as possible from numbers-arithmetic. I might have moved the tests in too aggressively, so let me know

@rustbot
Copy link
Collaborator

rustbot commented Feb 22, 2024

r? @nnethercote

rustbot has assigned @nnethercote.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added A-testsuite Area: The testsuite used to check the correctness of rustc S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Feb 22, 2024
nnethercote
nnethercote reviewed Feb 22, 2024
View reviewed changes
tests/ui/numbers-arithmetic/overflowing-neg.rs
#![allow(arithmetic_overflow)]

fn main() {
let _x = -i8::MIN;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this one was missed?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise, everything else looks ok.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

isn't that one on line 225/226?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

True! Not sure how I overlooked that.

@rust-log-analyzer

This comment has been minimized.

Sign in to view
@nnethercote
Copy link
Contributor

@bors r+

@bors
Copy link
Contributor

bors commented Feb 22, 2024

📌 Commit 669f891 has been approved by nnethercote

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Feb 22, 2024
@bors
Copy link
Contributor

bors commented Feb 23, 2024

⌛ Testing commit 669f891 with merge dda102c...

@bors
Copy link
Contributor

bors commented Feb 23, 2024

☀️ Test successful - checks-actions
Approved by: nnethercote
Pushing dda102c to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Feb 23, 2024
@bors bors merged commit dda102c into rust-lang:master Feb 23, 2024
12 checks passed
@rustbot rustbot added this to the 1.78.0 milestone Feb 23, 2024
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (dda102c): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 2.3% [2.3%, 2.3%] 1
Regressions ❌
(secondary)		 4.2% [2.2%, 5.5%] 3
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -6.7% [-6.7%, -6.7%] 1
All ❌✅ (primary) 2.3% [2.3%, 2.3%] 1

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 650.172s -> 650.47s (0.05%)
Artifact size: 310.96 MiB -> 310.92 MiB (-0.01%)

@RalfJung RalfJung mentioned this pull request Feb 23, 2024
Merged
matthiaskrgr added a commit to matthiaskrgr/rust that referenced this pull request Feb 23, 2024
@matthiaskrgr
Rollup merge of rust-lang#121510 - RalfJung:lint-overflowing-ops, r=o…
06e54f8 
…li-obk

lint-overflowing-ops: unify cases and remove redundancy

Follow-up to rust-lang#121432
r? `@oli-obk`
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Feb 23, 2024
@rust-timer
Unrolled build for rust-lang#121510
44bdb09 
Rollup merge of rust-lang#121510 - RalfJung:lint-overflowing-ops, r=oli-obk

lint-overflowing-ops: unify cases and remove redundancy

Follow-up to rust-lang#121432
r? `@oli-obk`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nnethercote nnethercote nnethercote left review comments

Assignees

@nnethercote nnethercote

Labels
A-testsuite Area: The testsuite used to check the correctness of rustc merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-bootstrap Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap) T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.78.0
Development

Successfully merging this pull request may close these issues.

Review tests in tests/ui/numbers-arithmetic for duplicates
6 participants
@mj10021 @rustbot @rust-log-analyzer @nnethercote @bors @rust-timer