Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Diagnostic renaming #121489

Merged
merged 10 commits into from
Feb 28, 2024
Merged

Diagnostic renaming #121489

merged 10 commits into from
Feb 28, 2024

Commits on Feb 27, 2024

  1. Rename Diagnostic as DiagInner. 

    I started by changing it to `DiagData`, but that didn't feel right.
`DiagInner` felt much better.
    @nnethercote
    nnethercote committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    6588f5b View commit details
    Browse the repository at this point in the history

  2. Rename DelayedDiagnostic as DelayedDiagInner.

    @nnethercote
    nnethercote committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    366536b View commit details
    Browse the repository at this point in the history

  3. Rename SubDiagnostic as Subdiag. 

    Note the change of the `D` to `d`, to match all the other names that
have `Subdiag` in them, such as `SubdiagnosticMessage` and
`derive(Subdiagnostic)`.
    @nnethercote
    nnethercote committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    4e1f9bd View commit details
    Browse the repository at this point in the history

  4. Rename DiagnosticBuilder as Diag. 

    Much better!

Note that this involves renaming (and updating the value of)
`DIAGNOSTIC_BUILDER` in clippy.
    @nnethercote
    nnethercote committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    899cb40 View commit details
    Browse the repository at this point in the history

  5. Rename DiagnosticArg{,Map,Name,Value} as DiagArg{,Map,Name,Value}.

    @nnethercote
    nnethercote committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    8199632 View commit details
    Browse the repository at this point in the history

  6. Rename DiagnosticArgFromDisplay as DiagArgFromDisplay.

    @nnethercote
    nnethercote committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    d0ef108 View commit details
    Browse the repository at this point in the history

  7. Rename DiagnosticLocation as DiagLocation.

    @nnethercote
    nnethercote committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    e3c19a2 View commit details
    Browse the repository at this point in the history

  8. Rename DiagnosticSymbolList as DiagSymbolList.

    @nnethercote
    nnethercote committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    6280a8c View commit details
    Browse the repository at this point in the history

  9. Rename DiagnosticStyledString as DiagStyledString.

    @nnethercote
    nnethercote committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    9b3520e View commit details
    Browse the repository at this point in the history

  10. Rename DiagnosticImportance as DiagImportance.

    @nnethercote
    nnethercote committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    8f3b007 View commit details
    Browse the repository at this point in the history