rename 'try' intrinsic to 'catch_unwind' #121598
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
|
Some changes occurred in compiler/rustc_codegen_gcc The Miri subtree was changed cc @rust-lang/miri Some changes occurred in compiler/rustc_codegen_cranelift cc @bjorn3 |
RalfJung
force-pushed
the
catch_unwind
branch
from
5ec97e5
to
65126d8
Compare
This comment has been minimized.
This comment has been minimized.
RalfJung
force-pushed
the
catch_unwind
branch
from
65126d8
to
2536953
Compare
This comment has been minimized.
This comment has been minimized.
RalfJung
force-pushed
the
catch_unwind
branch
from
2536953
to
a27f81f
Compare
This comment has been minimized.
This comment has been minimized.
RalfJung
force-pushed
the
catch_unwind
branch
from
a27f81f
to
00e063a
Compare
|
r? @oli-obk |
oli-obk
reviewed
Feb 26, 2024
oli-obk
reviewed
Feb 26, 2024
oli-obk
approved these changes
Feb 26, 2024
RalfJung
force-pushed
the
catch_unwind
branch
from
00e063a
to
a3c0f3a
Compare
|
@bors r=oli-obk |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 27, 2024
…iaskrgr Rollup of 4 pull requests Successful merges: - rust-lang#121598 (rename 'try' intrinsic to 'catch_unwind') - rust-lang#121639 (Update books) - rust-lang#121648 (Update Vec and String `{from,into}_raw_parts`-family docs) - rust-lang#121651 (Properly emit `expected ;` on `#[attr] expr`) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Feb 27, 2024
Rollup merge of rust-lang#121598 - RalfJung:catch_unwind, r=oli-obk rename 'try' intrinsic to 'catch_unwind' The intrinsic has nothing to do with `try` blocks, and corresponds to the stable `catch_unwind` function, so this makes a lot more sense IMO. Also rename Miri's special function while we are at it, to reflect the level of abstraction it works on: it's an unwinding mechanism, on which Rust implements panics.
taiki-e
added a commit
to taiki-e/unwinding
that referenced
this pull request
Feb 28, 2024
intrinsics::try has been renamed in rust-lang/rust#121598.
nbdd0121
pushed a commit
to nbdd0121/unwinding
that referenced
this pull request
Feb 28, 2024
intrinsics::try has been renamed in rust-lang/rust#121598.
This was referenced Mar 1, 2024
adpaco-aws
added a commit
to model-checking/kani
that referenced
this pull request
Mar 4, 2024
Upgrades the Rust toolchain to `nightly-2024-03-01`. The Rust compiler PRs that triggered changes in this upgrades are: * rust-lang/rust#121516 * rust-lang/rust#121598 * rust-lang/rust#121489 * rust-lang/rust#121783
bjorn3
pushed a commit
to bjorn3/rust
that referenced
this pull request
Mar 8, 2024
rename 'try' intrinsic to 'catch_unwind' The intrinsic has nothing to do with `try` blocks, and corresponds to the stable `catch_unwind` function, so this makes a lot more sense IMO. Also rename Miri's special function while we are at it, to reflect the level of abstraction it works on: it's an unwinding mechanism, on which Rust implements panics.
bjorn3
pushed a commit
to bjorn3/rust
that referenced
this pull request
Mar 8, 2024
…iaskrgr Rollup of 4 pull requests Successful merges: - rust-lang#121598 (rename 'try' intrinsic to 'catch_unwind') - rust-lang#121639 (Update books) - rust-lang#121648 (Update Vec and String `{from,into}_raw_parts`-family docs) - rust-lang#121651 (Properly emit `expected ;` on `#[attr] expr`) r? `@ghost` `@rustbot` modify labels: rollup
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The intrinsic has nothing to do with
tryblocks, and corresponds to the stablecatch_unwindfunction, so this makes a lot more sense IMO.Also rename Miri's special function while we are at it, to reflect the level of abstraction it works on: it's an unwinding mechanism, on which Rust implements panics.