Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 10 pull requests #121705

Closed
wants to merge 26 commits into from

Commits on Jan 18, 2024

  1. Add display method to OsStr

    Add `display` method to `OsStr` for lossy display of an `OsStr` which may contain invalid unicode.
    
    Invalid Unicode sequences are replaced with `U+FFFD REPLACEMENT CHARACTER`.
    
    This change also makes the `std::ffi::os_str` module public.
    riverbl committed Jan 18, 2024
    Configuration menu
    Copy the full SHA
    a0fcc8e View commit details
    Browse the repository at this point in the history

Commits on Feb 23, 2024

  1. tests: Fix typo unix_sigpipe-error.rs -> unix_sigpipe-sig_ign.rs

    There is no error expected. It's simply the "regular" test for sig_ign.
    So rename it.
    Enselic committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    e060274 View commit details
    Browse the repository at this point in the history
  2. tests: Rename unix_sigpipe.rs to unix_sigpipe-bare.rs for clarity

    The test is for the "bare" variant of the attribute that looks like this:
    
        #[unix_sigpipe]
    
    which is not allowed, because it must look like this:
    
        #[unix_sigpipe = "sig_ign"]
    Enselic committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    a1cb3db View commit details
    Browse the repository at this point in the history
  3. tests: Combine unix_sigpipe-not-used.rs and unix_sigpipe-only-feature.rs

    The only difference between the files is the presence/absence of
    
        #![feature(unix_sigpipe)]
    
    attribute. Avoid duplication by using revisions instead.
    Enselic committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    d14f158 View commit details
    Browse the repository at this point in the history
  4. tests: Add unix_sigpipe-different-duplicates.rs test variant

    To make sure that
    
        #[unix_sigpipe = "x"]
        #[unix_sigpipe = "y"]
    
    behaves like
    
        #[unix_sigpipe = "x"]
        #[unix_sigpipe = "x"]
    Enselic committed Feb 23, 2024
    Configuration menu
    Copy the full SHA
    948b1d6 View commit details
    Browse the repository at this point in the history

Commits on Feb 24, 2024

  1. Configuration menu
    Copy the full SHA
    0da1b71 View commit details
    Browse the repository at this point in the history

Commits on Feb 25, 2024

  1. Configuration menu
    Copy the full SHA
    3bcef2d View commit details
    Browse the repository at this point in the history

Commits on Feb 27, 2024

  1. Changing some attributes to only_local.

    Modified according to rust-lang/compiler-team#505.
    
    By running test cases, I found that modifying the attribute's only_local tag sometimes causes some unintuitive error reports, so I tend to split it into multiple PRs and edit a small number of attributes each time to prevent too many changes at once. Prevent possible subsequent difficulties in locating problems.
    surechen committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    03a10a9 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    8719b74 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    4dd05e6 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    5df9593 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    1feef44 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    b57ddfe View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    8a6d353 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    e9dbf44 View commit details
    Browse the repository at this point in the history
  9. CFI: Fix typo in test file names

    Fixes typo (i.e., saniziter) in test file names.
    rcvalle committed Feb 27, 2024
    Configuration menu
    Copy the full SHA
    c7476f8 View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#120051 - riverbl:os-str-display, r=m-ou-se

    Add `display` method to `OsStr`
    
    Add `display` method to `OsStr` for lossy display of an `OsStr` which may contain invalid unicode.
    
    Invalid Unicode sequences are replaced with `U+FFFD REPLACEMENT CHARACTER`.
    
    This change also makes the `std::ffi::os_str` module public (see rust-lang/libs-team#326 (comment)).
    
    - ACP: rust-lang/libs-team#326
    - Tracking issue: rust-lang#120048
    matthiaskrgr authored Feb 27, 2024
    Configuration menu
    Copy the full SHA
    aaa5889 View commit details
    Browse the repository at this point in the history
  11. Rollup merge of rust-lang#121226 - chenyukang:yukang-fix-import-alias…

    …, r=davidtwco
    
    Fix issues in suggesting importing extern crate paths
    
    Fixes rust-lang#121168
    
    r? ```@petrochenkov```
    matthiaskrgr authored Feb 27, 2024
    Configuration menu
    Copy the full SHA
    8270a6b View commit details
    Browse the repository at this point in the history
  12. Rollup merge of rust-lang#121527 - Enselic:unix_sigpipe-tests-fixes, …

    …r=davidtwco
    
    unix_sigpipe: Simple fixes and improvements in tests
    
    In rust-lang#120832 I included 5 preparatory commits.
    
    It will take a while before discussions there and in rust-lang#62569 is settled, so here is a PR that splits out 4 of the commits that are easy to review, to get them out of the way.
    
    r? ```@davidtwco``` who already approved these commits in rust-lang#120832 (but I have tweaked them a bit and rebased them since then).
    
    For the convenience of my reviewer, here are the full commit messages of the commits:
    <details>
    <summary>Click to expand</summary>
    
    ```
    commit 948b1d6 (HEAD -> unix_sigpipe-tests-fixes, origin/unix_sigpipe-tests-fixes)
    Author: Martin Nordholts <martin.nordholts@codetale.se>
    Date:   Fri Feb 9 07:57:27 2024 +0100
    
        tests: Add unix_sigpipe-different-duplicates.rs test variant
    
        To make sure that
    
            #[unix_sigpipe = "x"]
            #[unix_sigpipe = "y"]
    
        behaves like
    
            #[unix_sigpipe = "x"]
            #[unix_sigpipe = "x"]
    
    commit d14f158
    Author: Martin Nordholts <martin.nordholts@codetale.se>
    Date:   Fri Feb 9 08:47:47 2024 +0100
    
        tests: Combine unix_sigpipe-not-used.rs and unix_sigpipe-only-feature.rs
    
        The only difference between the files is the presence/absence of
    
            #![feature(unix_sigpipe)]
    
        attribute. Avoid duplication by using revisions instead.
    
    commit a1cb3db
    Author: Martin Nordholts <martin.nordholts@codetale.se>
    Date:   Fri Feb 9 06:44:56 2024 +0100
    
        tests: Rename unix_sigpipe.rs to unix_sigpipe-bare.rs for clarity
    
        The test is for the "bare" variant of the attribute that looks like this:
    
            #[unix_sigpipe]
    
        which is not allowed, because it must look like this:
    
            #[unix_sigpipe = "sig_ign"]
    
    commit e060274
    Author: Martin Nordholts <martin.nordholts@codetale.se>
    Date:   Fri Feb 9 05:48:24 2024 +0100
    
        tests: Fix typo unix_sigpipe-error.rs -> unix_sigpipe-sig_ign.rs
    
        There is no error expected. It's simply the "regular" test for sig_ign.
        So rename it.
    ```
    
    </details>
    
    Tracking issue: rust-lang#97889
    matthiaskrgr authored Feb 27, 2024
    Configuration menu
    Copy the full SHA
    719a0bd View commit details
    Browse the repository at this point in the history
  13. Rollup merge of rust-lang#121572 - notriddle:notriddle/test-case-1211…

    …06, r=GuillaumeGomez
    
    Add test case for primitive links in alias js
    
    Follow up rust-lang#121490
    
    CC rust-lang#121106
    matthiaskrgr authored Feb 27, 2024
    Configuration menu
    Copy the full SHA
    7a1092e View commit details
    Browse the repository at this point in the history
  14. Rollup merge of rust-lang#121661 - surechen:change_attribute_to_local…

    …_20240226, r=lcnr
    
    Changing some attributes to only_local.
    
    Modified according to rust-lang/compiler-team#505.
    
    By running test cases, I found that modifying the attribute's only_local tag sometimes causes some unintuitive error reports, so I tend to split it into multiple PRs and edit a small number of attributes each time to prevent too many changes at once. Prevent possible subsequent difficulties in locating problems.
    
    r? ```@lcnr```
    matthiaskrgr authored Feb 27, 2024
    Configuration menu
    Copy the full SHA
    9b84cbf View commit details
    Browse the repository at this point in the history
  15. Rollup merge of rust-lang#121680 - GuillaumeGomez:foreign-macro-jump-…

    …to-def, r=notriddle
    
    Fix link generation for foreign macro in jump to definition feature
    
    The crate name is already added to the link so it shouldn't be added a second time for local foreign macros.
    
    r? ``@notriddle``
    matthiaskrgr authored Feb 27, 2024
    Configuration menu
    Copy the full SHA
    a45045d View commit details
    Browse the repository at this point in the history
  16. Rollup merge of rust-lang#121686 - compiler-errors:rpitit-printing, r…

    …=lcnr
    
    Adjust printing for RPITITs
    
    1. Call RPITITs `{synthetic#N}` instead of `{opaque#N}`.
    2. Fall back to printing the RPITIT like an opaque even when printed as an `AliasTy`, just like we do for `ty::Alias`.
    
    You could argue that (2.) is misleading, but I believe it's more consistent than naming `{synthetic#N}`, which I assume approximately nobody knows where that def path name comes from.
    
    r? lcnr
    matthiaskrgr authored Feb 27, 2024
    Configuration menu
    Copy the full SHA
    81b164c View commit details
    Browse the repository at this point in the history
  17. Rollup merge of rust-lang#121689 - GuillaumeGomez:rustdoc-highlightin…

    …g-whitespace, r=notriddle
    
    [rustdoc] Prevent inclusion of whitespace character after macro_rules ident
    
    Discovered this bug randomly when looking at:
    
    ![image](https://github.com/rust-lang/rust/assets/3050060/dca38047-9085-4377-bfac-f98890224be4)
    
    We were too eagerly trying to merge tokens that shouldn't be merged together (for example if you have a code comment followed by a code comment, we merge them in one attribute to reduce the DOM size).
    
    r? ``@notriddle``
    matthiaskrgr authored Feb 27, 2024
    Configuration menu
    Copy the full SHA
    98e1b7b View commit details
    Browse the repository at this point in the history
  18. Rollup merge of rust-lang#121695 - oli-obk:split_ty_utils, r=compiler…

    …-errors
    
    Split rustc_type_ir to avoid rustc_ast from depending on it
    
    unblocks rust-lang#121576
    
    and resolves a FIXME in `rustc_ast`'s `Cargo.toml`
    
    The new crate is tiny, but it will get bigger in rust-lang#121576
    matthiaskrgr authored Feb 27, 2024
    Configuration menu
    Copy the full SHA
    901148c View commit details
    Browse the repository at this point in the history
  19. Rollup merge of rust-lang#121698 - rcvalle:rust-cfi-fix-typo, r=compi…

    …ler-errors
    
    CFI: Fix typo in test file names
    
    Fixes typo (i.e., saniziter) in test file names.
    matthiaskrgr authored Feb 27, 2024
    Configuration menu
    Copy the full SHA
    8899f96 View commit details
    Browse the repository at this point in the history