Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Diagnostic renaming 2 #121780

Merged
merged 11 commits into from
Mar 5, 2024
Merged

Diagnostic renaming 2 #121780

merged 11 commits into from
Mar 5, 2024
+609 −639

Commits on Mar 5, 2024

  1. Disable tests/ui-fulldeps/internal-lints/diagnostics.rs on stage 1. 

    When you make a change to the diagnostic lints, it uses the old version
of the lints with stage 1 and the new version with stage 2, which often
leads to failures in stage 1. Let's just stick to stage 2.
    @nnethercote
    nnethercote committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    d849f5c View commit details
    Browse the repository at this point in the history

  2. Rename DiagnosticMessage as DiagMessage.

    @nnethercote
    nnethercote committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    18715c9 View commit details
    Browse the repository at this point in the history

  3. Fix some out-of-date comments.

    @nnethercote
    nnethercote committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    f16a8d0 View commit details
    Browse the repository at this point in the history

  4. Rename SubdiagnosticMessage as SubdiagMessage.

    @nnethercote
    nnethercote committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    60ea6e2 View commit details
    Browse the repository at this point in the history

  5. Rename SubdiagnosticMessageOp as SubdiagMessageOp.

    @nnethercote
    nnethercote committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    573267c View commit details
    Browse the repository at this point in the history

  6. Rename DiagnosticMode as DiagMode.

    @nnethercote
    nnethercote committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    d0e9bab View commit details
    Browse the repository at this point in the history

  7. Rename DiagnosticExt as DiagExt.

    @nnethercote
    nnethercote committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    d98ad0a View commit details
    Browse the repository at this point in the history

  8. Rename BuiltinLintDiagnostics as BuiltinLintDiag. 

    Not the dropping of the trailing `s` -- this type describes a single
diagnostic and its name should be singular.
    @nnethercote
    nnethercote committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    7aa0eea View commit details
    Browse the repository at this point in the history

  9. Rename StructuredDiagnostic as StructuredDiag.

    @nnethercote
    nnethercote committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    f842939 View commit details
    Browse the repository at this point in the history

  10. Rename DiagnosticMetadata as DiagMetadata.

    @nnethercote
    nnethercote committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    5cce287 View commit details
    Browse the repository at this point in the history

  11. Adjust Diag::new signature. 

    Make it use `impl Into<DiagMessage>` like all the other methods nearby.
    @nnethercote
    nnethercote committed Mar 5, 2024
    Configuration menu
    Copy the full SHA
    1cd9574 View commit details
    Browse the repository at this point in the history