never patterns: suggest ! patterns on non-exhaustive matches
#121823
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
5 tasks
| @@ -1020,6 +1020,14 @@ fn report_non_exhaustive_match<'p, 'tcx>( | |||
|
|
|||
| let mut suggestion = None; | |||
| let sm = cx.tcx.sess.source_map(); | |||
| let suggested_arm = if witnesses.len() < 4 | |||
There was a problem hiding this comment.
Because that's also the limit used above to choose whether to report patterns or _. You're right this should be made clear, let me clean this
There was a problem hiding this comment.
I just find it strange that this applies to only the never branch, since the other half of the if could suffer from the same problem?
There was a problem hiding this comment.
There were actually three places using this magic threshold ^^' Fixed in the last commit
There was a problem hiding this comment.
If there are more than 4 witnesses we suggest _ => todo!(), it doesn't make sense to remove the todo!() then. And I can't just suggest ! either because the type might not be empty.
Nadrieril
force-pushed
the
never-witnesses
branch
from
d49229f
to
1b31e14
Compare
|
@bors r+ |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Mar 18, 2024
…ler-errors never patterns: suggest `!` patterns on non-exhaustive matches When a match is non-exhaustive we now suggest never patterns whenever it makes sense. r? `@compiler-errors`
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 18, 2024
…iaskrgr Rollup of 12 pull requests Successful merges: - rust-lang#121258 (Reject overly generic assoc const binding types) - rust-lang#121823 (never patterns: suggest `!` patterns on non-exhaustive matches) - rust-lang#122060 (Stabilize `imported_main`) - rust-lang#122158 (Provide structured suggestion for `#![feature(foo)]`) - rust-lang#122642 (Improve wording of `Vec::swap_remove`) - rust-lang#122675 (core: document default attribute stabilization) - rust-lang#122687 (`NormalizesTo`: return nested goals to caller) - rust-lang#122691 (Fix ICE: `global_asm!()` Don't Panic When Unable to Evaluate Constant) - rust-lang#122693 (Fix heading anchors in doc pages.) - rust-lang#122699 (Fix a typo in the 1.77.0 relnotes) - rust-lang#122700 (Remove redundant files, rename base riscv32 file) - rust-lang#122701 (Detect allocator for box in `must_not_suspend` lint) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 18, 2024
…iaskrgr Rollup of 11 pull requests Successful merges: - rust-lang#121258 (Reject overly generic assoc const binding types) - rust-lang#121823 (never patterns: suggest `!` patterns on non-exhaustive matches) - rust-lang#122060 (Stabilize `imported_main`) - rust-lang#122158 (Provide structured suggestion for `#![feature(foo)]`) - rust-lang#122642 (Improve wording of `Vec::swap_remove`) - rust-lang#122675 (core: document default attribute stabilization) - rust-lang#122687 (`NormalizesTo`: return nested goals to caller) - rust-lang#122693 (Fix heading anchors in doc pages.) - rust-lang#122699 (Fix a typo in the 1.77.0 relnotes) - rust-lang#122700 (Remove redundant files, rename base riscv32 file) - rust-lang#122701 (Detect allocator for box in `must_not_suspend` lint) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 18, 2024
Rollup merge of rust-lang#121823 - Nadrieril:never-witnesses, r=compiler-errors never patterns: suggest `!` patterns on non-exhaustive matches When a match is non-exhaustive we now suggest never patterns whenever it makes sense. r? ``@compiler-errors``
|
This caused a small regression. I'm surprised because a far as I can tell this only touches error paths (except when |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When a match is non-exhaustive we now suggest never patterns whenever it makes sense.
r? @compiler-errors