Give deadlock handler access to GlobalCtxt
#121971
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
Zoxc
reviewed
Mar 4, 2024
oli-obk
force-pushed
the
lrc_gcx
branch
2 times, most recently
from
1f3976a
to
bcaca33
Compare
|
You might need to opt |
Zoxc
reviewed
Mar 8, 2024
| @@ -311,6 +318,12 @@ impl Compiler { | |||
| { | |||
| // Must declare `_timer` first so that it is dropped after `queries`. | |||
| let mut _timer = None; | |||
| let _guard = rustc_data_structures::defer(|| { | |||
There was a problem hiding this comment.
I think it would make more sense for this to be declared after queries so that we store null before the destructor of GlobalCtxt gains unique access, even though it offers no synchronization.
|
☔ The latest upstream changes (presumably #122241) made this pull request unmergeable. Please resolve the merge conflicts. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Doesn't work yet, because we try to share a
Compileracross thread boundaries, which mostly doesn't work because some things likeFreezeLockare notSync, but onlyDynSync.intended as a replacement for #115220
cc @Zoxc do you think this is doable once we nuke the non-parallel-compiler cfgs and do some cleanups by using the thread safe sync primitives everywhere?