Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 10 pull requests #122273

Closed
wants to merge 23 commits into from

Commits on Feb 22, 2024

  1. Configuration menu
    Copy the full SHA
    1ea6cd7 View commit details
    Browse the repository at this point in the history

Commits on Feb 27, 2024

  1. Configuration menu
    Copy the full SHA
    70639c8 View commit details
    Browse the repository at this point in the history

Commits on Feb 29, 2024

  1. add myself to rotation

    fee1-dead committed Feb 29, 2024
    Configuration menu
    Copy the full SHA
    3e675bd View commit details
    Browse the repository at this point in the history

Commits on Mar 2, 2024

  1. Configuration menu
    Copy the full SHA
    c3954b3 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    d88c7ff View commit details
    Browse the repository at this point in the history

Commits on Mar 6, 2024

  1. Dynamically size sigaltstk in std

    On modern Linux with Intel AMX and 1KiB matrices,
    Arm SVE with potentially 2KiB vectors,
    and RISCV Vectors with up to 16KiB vectors,
    we must handle dynamic signal stack sizes.
    
    We can do so unconditionally by using getauxval,
    but assuming it may return 0 as an answer,
    thus falling back to the old constant if needed.
    workingjubilee committed Mar 6, 2024
    Configuration menu
    Copy the full SHA
    9da004e View commit details
    Browse the repository at this point in the history

Commits on Mar 7, 2024

  1. Revert back to Git-for-Windows for MinGW CI builds

    In rust-lang#121182 the mingw build was
    changed to use MSYS2's version of Git. This commit reverts that, as
    it was considered too slow.
    majaha committed Mar 7, 2024
    Configuration menu
    Copy the full SHA
    c7a48a5 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    1195518 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    25ab1c7 View commit details
    Browse the repository at this point in the history

Commits on Mar 9, 2024

  1. Configuration menu
    Copy the full SHA
    7843e46 View commit details
    Browse the repository at this point in the history
  2. review

    Nadrieril committed Mar 9, 2024
    Configuration menu
    Copy the full SHA
    594cf1d View commit details
    Browse the repository at this point in the history
  3. fix: remove memory leak due to missing drop implementation for local …

    …waker. Also, fix some
    
    of the stability attributes of LocalWaker's methods.
    tvallotton committed Mar 9, 2024
    Configuration menu
    Copy the full SHA
    092a1ab View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    ff1459a View commit details
    Browse the repository at this point in the history

Commits on Mar 10, 2024

  1. Rollup merge of rust-lang#112136 - clarfonthey:ffi-c_str, r=cuviper

    Add std::ffi::c_str module
    
    ACP: rust-lang/libs-team#134
    
    `std::ffi` docs before change:
    ![Structs: VaList, VaListImpl, CStr, CString, FromBytesWithNulError, FromVecWithNulError, IntoStringError, NulError, OsStr, OsString](https://github.com/rust-lang/rust/assets/15850505/b2cf3534-30f9-4ef0-a655-bacdc3a19e17)
    
    `std::ffi` docs after change:
    ![Re-exports: self::c_str::{FromBytesWithNulError, FromBytesUntilNulError, FromVecWithNulError, NulError, IntoStringError} ; Modules: c_str ; Structs: VaList, VaListImpl, CStr, CString, OsStr, OsString](https://github.com/rust-lang/rust/assets/15850505/23aa6964-da7a-4942-bbf7-42bde2146f9e)
    
    (note: I'm omitting the `c_int`, etc. stuff from the screenshots since it's the same in both. this doesn't just delete those types)
    matthiaskrgr committed Mar 10, 2024
    Configuration menu
    Copy the full SHA
    c2c4e1e View commit details
    Browse the repository at this point in the history
  2. Rollup merge of rust-lang#113525 - workingjubilee:handle-dynamic-mins…

    …igstksz, r=m-ou-se
    
    Dynamically size sigaltstk in std
    
    On modern Linux with Intel AMX and 1KiB matrices,
    Arm SVE with potentially 2KiB vectors,
    and RISCV Vectors with up to 16KiB vectors,
    we must handle dynamic signal stack sizes.
    
    We can do so unconditionally by using getauxval,
    but assuming it may return 0 as an answer,
    thus falling back to the old constant if needed.
    
    Fixes rust-lang#107795
    matthiaskrgr committed Mar 10, 2024
    Configuration menu
    Copy the full SHA
    263f329 View commit details
    Browse the repository at this point in the history
  3. Rollup merge of rust-lang#121685 - fortanix:raoul/shellcheck_on_lvi_t…

    …est_script, r=Mark-Simulacrum
    
    Fixing shellcheck comments on lvi test script
    
    Running `shellcheck` on `tests/run-make/x86_64-fortanix-unknown-sgx-lvi/script.sh` gives plenty of warnings. This PR fixes those issues. For completeness: rust-lang#121683 fixes another warning as well
    matthiaskrgr committed Mar 10, 2024
    Configuration menu
    Copy the full SHA
    6588bff View commit details
    Browse the repository at this point in the history
  4. Rollup merge of rust-lang#121833 - kornelski:parent_include, r=estebank

    Suggest correct path in include_bytes!
    
    `include_bytes!` paths are relative, and I'm often not sure how nested is the `.rs` file that I'm editing, so I have to guess the number of `"../.."`. This change searches `..` and `../..` for the given file and offers corrected path as a suggestion.
    
    I wasn't sure how to get the right span, and how to properly escape it.
    
    ```text
    error: couldn't read src/file.txt: No such file or directory (os error 2)
     --> src/main.rs:2:13
      |
    2 |     let x = include_bytes!("file.txt");
      |             ^^^^^^^^^^^^^^^----------^
      |                            |
      |                            help: it's in a parent directory: `"../../file.txt"`
    ```
    matthiaskrgr committed Mar 10, 2024
    Configuration menu
    Copy the full SHA
    a34519b View commit details
    Browse the repository at this point in the history
  5. Rollup merge of rust-lang#121860 - mu001999:master, r=Nilstrieb

    Add a tidy check that checks whether the fluent slugs only appear once
    
    As ```@Nilstrieb``` said in rust-lang#121828 (comment):
    > Might make sense to have a tidy check that checks whether the fluent slugs only appear once in the source code and lint for that
    there's a tidy check already for sorting
    
    We can get the tidy check error:
    ```
    tidy check
    tidy error: /path/to/rust/compiler/rustc_const_eval/messages.ftl: message `const_eval_invalid_align` is not used
    tidy error: /path/to/rust/compiler/rustc_lint/messages.ftl: message `lint_trivial_untranslatable_diag` is not used
    tidy error: /path/to/rust/compiler/rustc_parse/messages.ftl: message `parse_invalid_literal_suffix` is not used
    tidy error: /path/to/rust/compiler/rustc_infer/messages.ftl: message `infer_need_type_info_in_coroutine` is not used
    tidy error: /path/to/rust/compiler/rustc_passes/messages.ftl: message `passes_expr_not_allowed_in_context` is not used
    tidy error: /path/to/rust/compiler/rustc_passes/messages.ftl: message `passes_layout` is not used
    tidy error: /path/to/rust/compiler/rustc_parse/messages.ftl: message `parse_not_supported` is not used
    ```
    
    r? ```@Nilstrieb```
    matthiaskrgr committed Mar 10, 2024
    Configuration menu
    Copy the full SHA
    b36afe4 View commit details
    Browse the repository at this point in the history
  6. Rollup merge of rust-lang#122125 - majaha:mingw_ci_new, r=Mark-Simula…

    …crum
    
    Revert back to Git-for-Windows for MinGW CI builds
    
    Following discussion in rust-lang#121182 it was decided to revert using MSYS2 Git for mingw builds.
    matthiaskrgr committed Mar 10, 2024
    Configuration menu
    Copy the full SHA
    3a5abff View commit details
    Browse the repository at this point in the history
  7. Rollup merge of rust-lang#122221 - Nadrieril:patextradata, r=oli-obk

    match lowering: define a convenient struct
    
    Small refactor PR: `bindings` and `ascriptions` always come together so I made a struct for them. I'll have one or two fields to add to it in a later PR as well.
    matthiaskrgr committed Mar 10, 2024
    Configuration menu
    Copy the full SHA
    5902d4e View commit details
    Browse the repository at this point in the history
  8. Rollup merge of rust-lang#122244 - tvallotton:local_waker_leak_fix, r…

    …=Nilstrieb
    
    fix: LocalWaker memory leak and some stability attributes
    
    fixes rust-lang#122180.
    matthiaskrgr committed Mar 10, 2024
    Configuration menu
    Copy the full SHA
    55674a8 View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#122251 - jieyouxu:unused-lifetimes-dedup-te…

    …st, r=Nadrieril
    
    Add test to check unused_lifetimes don't duplicate "parameter is never used" error
    
    Closes rust-lang#72587.
    matthiaskrgr committed Mar 10, 2024
    Configuration menu
    Copy the full SHA
    0c16308 View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#122264 - fee1-dead-contrib:add, r=fee1-dead

    add myself to rotation
    
    Won't have too much capacity, but I am able to contribute something. Will be rotating reviews if I run out of capacity :)
    
    r? ``@ghost``
    ``@bors`` r+ rollup
    matthiaskrgr committed Mar 10, 2024
    Configuration menu
    Copy the full SHA
    fa0f5b0 View commit details
    Browse the repository at this point in the history