Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update backtrace submodule to 0.3.70 #122306

Merged
merged 1 commit into from
Mar 10, 2024
Merged

Update backtrace submodule to 0.3.70 #122306

merged 1 commit into from
Mar 10, 2024

Conversation

workingjubilee
Copy link
Member

r? @ghost

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 10, 2024
@workingjubilee
Copy link
Member Author

@bors r+ rollup=never p=1

@bors
Copy link
Contributor

bors commented Mar 10, 2024

📌 Commit caae03c has been approved by workingjubilee

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 10, 2024
@workingjubilee workingjubilee linked an issue Mar 10, 2024 that may be closed by this pull request
Backtrace crashes in Wine with target i686-pc-windows-gnu #122154
Closed
@bors
Copy link
Contributor

bors commented Mar 10, 2024

⌛ Testing commit caae03c with merge 3b1717c...

@bors
Copy link
Contributor

bors commented Mar 10, 2024

☀️ Test successful - checks-actions
Approved by: workingjubilee
Pushing 3b1717c to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Mar 10, 2024
@bors bors merged commit 3b1717c into rust-lang:master Mar 10, 2024
12 checks passed
@rustbot rustbot added this to the 1.78.0 milestone Mar 10, 2024
@workingjubilee workingjubilee deleted the backtrace-0.3.70 branch March 10, 2024 23:01
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (3b1717c): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -2.7% [-3.0%, -2.4%] 2
All ❌✅ (primary) - - 0

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)		 - - 0
Regressions ❌
(secondary)		 - - 0
Improvements ✅
(primary)		 - - 0
Improvements ✅
(secondary)		 -3.0% [-3.0%, -3.0%] 1
All ❌✅ (primary) - - 0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 647.057s -> 648.293s (0.19%)
Artifact size: 309.92 MiB -> 309.98 MiB (0.02%)

@michaelwoerister michaelwoerister mentioned this pull request Mar 12, 2024
Merged
@matthiaskrgr matthiaskrgr mentioned this pull request Sep 15, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Milestone
1.78.0
Development

Successfully merging this pull request may close these issues.

Backtrace crashes in Wine with target i686-pc-windows-gnu
4 participants
@workingjubilee @bors @rust-timer @rustbot