Rollup of 15 pull requests #122338

workingjubilee · 2024-03-11T16:29:39Z

Successful merges:

Allow codegen backends to opt-out of parallel codegen #116791 (Allow codegen backends to opt-out of parallel codegen)
Allow targets to override default codegen backend #116793 (Allow targets to override default codegen backend)
LLVM Bitcode Linker: A self contained linker for nvptx and other targets #117458 (LLVM Bitcode Linker: A self contained linker for nvptx and other targets)
Fix type resolution of associated const equality bounds (take 2) #119385 (Fix type resolution of associated const equality bounds (take 2))
std support for wasm32 panic=unwind #121438 (std support for wasm32 panic=unwind)
Add tests (and a bit of cleanup) for interior mut handling in promotion and const-checking #121893 (Add tests (and a bit of cleanup) for interior mut handling in promotion and const-checking)
Clarity improvements to DropTree #122080 (Clarity improvements to DropTree)
Improve diagnostics for parenthesized type arguments #122152 (Improve diagnostics for parenthesized type arguments)
Remove the unused field_remapping field from TypeLowering #122166 (Remove the unused field_remapping field from TypeLowering)
interpret: do not call machine read hooks during validation #122249 (interpret: do not call machine read hooks during validation)
Store backtrace for must_produce_diag #122299 (Store backtrace for must_produce_diag)
Revision-related tweaks for next-solver tests #122318 (Revision-related tweaks for next-solver tests)
Use ptradd for vtable indexing #122320 (Use ptradd for vtable indexing)
unix_sigpipe: Replace inherit with sig_dfl in syntax tests #122328 (unix_sigpipe: Replace inherit with sig_dfl in syntax tests)
bootstrap readme: fix, improve, update #122330 (bootstrap readme: fix, improve, update)

r? @ghost
@rustbot modify labels: rollup

…n of unions

This clarifies that we're adding an "entry point", not just adding an "entry" of some kind.

This allows us to use real field names instead of tuple element numbers. Renaming `previous_drops` to `existing_drops_map` clarifies that "previous" was unrelated to drop order.

Like field offsets, these are always constant.

The `sig_dfl` variant of the attribute is the most likely variant to be stabilized first, and thus to become the "most allowed" variant of the attribute. Because of this, it is the most appropriate variant to use in syntax tests, because even if the most allowed variant is used, the compiler shall still emit errors if it e.g. is used in the wrong places.

workingjubilee · 2024-03-11T16:29:52Z

@bors r+ rollup=never p=15

bors · 2024-03-11T16:29:54Z

📌 Commit 7fa6fa4 has been approved by workingjubilee

It is now in the queue for this repository.

bors · 2024-03-11T16:51:59Z

⌛ Testing commit 7fa6fa4 with merge 6554a56...

workingjubilee · 2024-03-11T17:12:00Z

🧿 🧿 🧿 🧿 🧿 🧿 🧿
🧿 🧿 🧿 🧿 🧿 🧿 🧿 🧿
🧿 🧿 🧿 🧿 🧿 🧿

bors · 2024-03-11T19:00:09Z

☀️ Test successful - checks-actions
Approved by: workingjubilee
Pushing 6554a56 to master...

rust-timer · 2024-03-11T19:04:23Z

📌 Perf builds for each rolled up PR:

PR#	Message	Perf Build Sha
#116791	Allow codegen backends to opt-out of parallel codegen	`a89ef7b52f5412da5f4a6d1c335cf683358f4c52` (link)
#116793	Allow targets to override default codegen backend	`6c910a961d3975c09caad98b4a3cf17056e7f85b` (link)
#117458	LLVM Bitcode Linker: A self contained linker for nvptx and …	`4a922e7cb31f076292c369cf8393e53fa8fbcc91` (link)
#119385	Fix type resolution of associated const equality bounds (ta…	`64fcfca30418c3aae9578b5eaa7959efcfca651a` (link)
#121438	std support for wasm32 panic=unwind	`08711d54d5557a4e799f4103b6c5c987398c8296` (link)
#121893	Add tests (and a bit of cleanup) for interior mut handling …	`0a3d279358a8c1566b8c40613e2d52d2be64174b` (link)
#122080	Clarity improvements to `DropTree`	`e36d64068edc0c1f872a76fbe0ec849ae633c2e6` (link)
#122152	Improve diagnostics for parenthesized type arguments	`c656bd646152d9301e25681a3df4ae4a1185366d` (link)
#122166	Remove the unused `field_remapping` field from `TypeLowerin…	`febd6c8ca4c1459d6cf48eea1179311ba9a64d7d` (link)
#122249	interpret: do not call machine read hooks during validation	`c39ad27214a40bd2ad8c235f90ede77c494c6402` (link)
#122299	Store backtrace for `must_produce_diag`	`ba8809b89587bc460571d001527f63595496dce0` (link)
#122318	Revision-related tweaks for next-solver tests	`189cbe2d88be1be0352fff66d485e98beb46350a` (link)
#122320	Use ptradd for vtable indexing	`2b188cc7cdf52ad7ac653006cce8ce7395519d5c` (link)
#122328	unix_sigpipe: Replace `inherit` with `sig_dfl` in syntax te…	`e331cbe51ef4c5922e295ac714d11a903c4152d5` (link)
#122330	bootstrap readme: fix, improve, update	`b7706a6fa2815e8c83b9d29baf1b56cf083add53` (link)

previous master: 65cd843ae0

In the case of a perf regression, run the following command for each PR you suspect might be the cause: @rust-timer build $SHA

rust-timer · 2024-03-11T21:34:01Z

Finished benchmarking commit (6554a56): comparison URL.

Overall result: ✅ improvements - no action needed

@rustbot label: -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-1.2%	[-1.2%, -1.1%]	4
Improvements ✅ (secondary)	-0.8%	[-1.2%, -0.4%]	13
All ❌✅ (primary)	-1.2%	[-1.2%, -1.1%]	4

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	3.0%	[2.8%, 3.3%]	2
Improvements ✅ (primary)	-2.0%	[-3.1%, -0.1%]	4
Improvements ✅ (secondary)	-3.8%	[-7.0%, -2.2%]	8
All ❌✅ (primary)	-2.0%	[-3.1%, -0.1%]	4

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 652.28s -> 669.92s (2.70%)
Artifact size: 309.94 MiB -> 309.97 MiB (0.01%)

klensy · 2024-03-12T08:03:40Z

Can #122320 be rerun here for perf?

workingjubilee · 2024-03-12T16:06:10Z

I don't think we'll produce meaningfully different results, but why not:

@rust-timer build 2b188cc

rust-timer · 2024-03-12T19:33:22Z

Finished benchmarking commit (2b188cc): comparison URL.

Overall result: no relevant changes - no action needed

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	2.5%	[2.5%, 2.5%]	1
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-	-	0
All ❌✅ (primary)	2.5%	[2.5%, 2.5%]	1

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	-	-	0
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-	-	0
Improvements ✅ (secondary)	-2.6%	[-2.9%, -2.3%]	3
All ❌✅ (primary)	-	-	0

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 652.28s -> 651.81s (-0.07%)
Artifact size: 309.94 MiB -> 309.95 MiB (0.00%)

WaffleLapkin and others added 30 commits February 14, 2024 23:43

Allow targets to override default codegen backend

a03d19e

Refactor out a repeating pattern with get_or_default_sysroot

5441523

Rename -Zno_parallel_llvm -> -Zno_parallel_backend

9a77ec9

Allow codegen backends to opt-out of parallel codegen

f368922

Propagate the resolved type of assoc const bindings via query feeding

8bb49e2

Refactor out another repeating pattern

6d115f5

Use existing query feeding workarounds

b94498a

std support for wasm32 panic=unwind

3908a93

Fix llvm hang

861c7e7

Unconditionally pass -wasm-enable-eh

658a0a2

Use Itanium ABI for thrown exceptions

125b26a

Don't codegen wasm.throw unless with -Zbuild-std

c7fcf43

Slightly simplify feeding of assoc const eq bounds

858d336

add comment and test: we do not do value-based reasoning for promotio…

d9a2886

…n of unions

Rename DropTreeBuilder::add_entry to link_entry_point

30fa6a8

Assert that link_entry_point sees the expected dummy terminator

3bd8df9

Rename DropTree::add_entry to add_entry_point

fbdac30

This clarifies that we're adding an "entry point", not just adding an "entry" of some kind.

Replace tuples in DropTree with named structs

5ba70bd

This allows us to use real field names instead of tuple element numbers. Renaming `previous_drops` to `existing_drops_map` clarifies that "previous" was unrelated to drop order.

Remove the unused field_remapping field from TypeLowering

d673fd8

interpret: do not call machine read hooks during validation

bf47df8

Improve diagnostics for parenthesized type arguments

58f6aaa

Ignore tests w/ current/next revisions from compare-mode=next-solver

3830510

use ptradd for vtable indexing

a7cd803

Like field offsets, these are always constant.

Store backtrace for must_produce_diag

73fc170

Mark some next-solver-behavior tests explicitly with revisions

01e6b43

bootstrap readme: fix, improve, update

816dc96

LLVM_TOOLS: Include llvm-link as a llvm tool

ed252e9

LLVM Bitcode Linker: Added crate

222ce4f

NVPTX: Enable self-contained for the nvptx target

af42d2a

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 11, 2024

workingjubilee mentioned this pull request Mar 11, 2024

Rollup of 11 pull requests #122337

Closed

bors added the merged-by-bors This PR was explicitly merged by bors. label Mar 11, 2024

bors merged commit 6554a56 into rust-lang:master Mar 11, 2024
12 checks passed

rustbot added this to the 1.78.0 milestone Mar 11, 2024

This was referenced Mar 11, 2024

Implement -L KIND=@RUSTC_BUILTIN/... #121843

Merged

[bootstrap] Move the split-debuginfo setting to the per-target section #121754

Merged

bors mentioned this pull request Mar 11, 2024

Eagerly instantiate closure/coroutine-like bounds with placeholders to deal with binders correctly #122267

Merged

workingjubilee deleted the rollup-xzpt4v4 branch March 11, 2024 21:17

mati865 mentioned this pull request Mar 11, 2024

Use ptradd for vtable indexing #122320

Merged

This comment has been minimized.

Sign in to view

matthiaskrgr mentioned this pull request Sep 15, 2024

ICE: asked to assemble auto trait candidates of unexpected type: FreshTy(0) #130411

Open

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Rollup of 15 pull requests #122338

Rollup of 15 pull requests #122338

workingjubilee commented Mar 11, 2024

workingjubilee commented Mar 11, 2024

bors commented Mar 11, 2024

bors commented Mar 11, 2024

workingjubilee commented Mar 11, 2024

bors commented Mar 11, 2024

rust-timer commented Mar 11, 2024

rust-timer commented Mar 11, 2024

klensy commented Mar 12, 2024

workingjubilee commented Mar 12, 2024

This comment has been minimized.

rust-timer commented Mar 12, 2024

Rollup of 15 pull requests #122338

Rollup of 15 pull requests #122338

Conversation

workingjubilee commented Mar 11, 2024

workingjubilee commented Mar 11, 2024

bors commented Mar 11, 2024

bors commented Mar 11, 2024

workingjubilee commented Mar 11, 2024

bors commented Mar 11, 2024

rust-timer commented Mar 11, 2024

rust-timer commented Mar 11, 2024

Overall result: ✅ improvements - no action needed

klensy commented Mar 12, 2024

workingjubilee commented Mar 12, 2024

This comment has been minimized.

rust-timer commented Mar 12, 2024

Overall result: no relevant changes - no action needed