Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Various cleanups around the const eval query providers #122397

Merged
merged 12 commits into from
Mar 14, 2024
Merged

Various cleanups around the const eval query providers #122397

merged 12 commits into from
Mar 14, 2024

Commits on Mar 14, 2024

  1. Fix accidental re-addition of removed code in a previous PR

    @oli-obk
    oli-obk committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    71f1943 View commit details
    Browse the repository at this point in the history

  2. Generalize eval_in_interpreter with a helper trait

    @oli-obk
    oli-obk committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    d6c9997 View commit details
    Browse the repository at this point in the history

  3. Move only usage of take_static_root_alloc to its definition and inl… 

    …ine it
    @oli-obk
    oli-obk committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    93888cd View commit details
    Browse the repository at this point in the history

  4. Move error handling into const_validate_mplace

    @oli-obk
    oli-obk committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    8b8efd1 View commit details
    Browse the repository at this point in the history

  5. Move InterpCx into eval_in_interpreter

    @oli-obk
    oli-obk committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    6b936b6 View commit details
    Browse the repository at this point in the history

  6. Move generate_stacktrace_from_stack away from InterpCx to avoid havin… 

    …g to know the `Machine` type
    @oli-obk
    oli-obk committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    d2d2bd2 View commit details
    Browse the repository at this point in the history

  7. Directly pass in the stack instead of computing it from a machine

    @oli-obk
    oli-obk committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    d3b7b55 View commit details
    Browse the repository at this point in the history

  8. Remove an argument that can be computed cheaply

    @oli-obk
    oli-obk committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    02a0ac8 View commit details
    Browse the repository at this point in the history

  9. Share the InterpCx creation between static and const evaluation

    @oli-obk
    oli-obk committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    cc7e0b2 View commit details
    Browse the repository at this point in the history

  10. Move validation into eval_body_using_ecx

    @oli-obk
    oli-obk committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    2e6c490 View commit details
    Browse the repository at this point in the history

  11. Move the entire success path into eval_body_using_ecx

    @oli-obk
    oli-obk committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    16046c7 View commit details
    Browse the repository at this point in the history

  12. Rename some things around validation error reporting to signal that i… 

    …t is in fact about validation failures
    @oli-obk
    oli-obk committed Mar 14, 2024
    Configuration menu
    Copy the full SHA
    a316c21 View commit details
    Browse the repository at this point in the history