Register LLVM handlers for bad-alloc / OOM #122574
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LLVM's default bad-alloc handler may throw if exceptions are enabled, and `operator new` isn't hooked at all by default. Now we register our own handler that prints a message similar to fatal errors, then aborts. We also call the function that registers the C++ `std::new_handler`.
rustbot
added
S-waiting-on-review
This comment has been minimized.
This comment has been minimized.
|
Oops, the bad-alloc installer had its assertion fixed in llvm/llvm-project#83160 -- but I think it will work if we just register that before the fatal error handler... |
The bad-alloc installer was incorrectly asserting that the other handler isn't set yet, instead of checking its own, but we can avoid that by changing the order we install them. Ref: llvm/llvm-project#83040
|
@bors r+ |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 16, 2024
Register LLVM handlers for bad-alloc / OOM LLVM's default bad-alloc handler may throw if exceptions are enabled, and `operator new` isn't hooked at all by default. Now we register our own handler that prints a message similar to fatal errors, then aborts. We also call the function that registers the C++ `std::new_handler`. Fixes rust-lang#121305 Cc llvm/llvm-project#85281 r? `@nikic`
|
The job Click to see the possible cause of the failure (guessed by this bot) |
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
|
"Connection reset" in remote-test-client @bors retry |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Mar 17, 2024
Register LLVM handlers for bad-alloc / OOM LLVM's default bad-alloc handler may throw if exceptions are enabled, and `operator new` isn't hooked at all by default. Now we register our own handler that prints a message similar to fatal errors, then aborts. We also call the function that registers the C++ `std::new_handler`. Fixes rust-lang#121305 Cc llvm/llvm-project#85281 r? `@nikic`
This was referenced Mar 17, 2024
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 17, 2024
…iaskrgr Rollup of 5 pull requests Successful merges: - rust-lang#119411 (Add as_(mut_)ptr and as_(mut_)slice to raw array pointers) - rust-lang#122248 (Respect stage0 sysroot when compiling rmake.rs with COMPILETEST_FORCE_STAGE0) - rust-lang#122295 (mir-opt: always run tests for the current target) - rust-lang#122574 (Register LLVM handlers for bad-alloc / OOM) - rust-lang#122608 (Move check-cfg diagnostic logic into a separate file) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 17, 2024
Rollup merge of rust-lang#122574 - cuviper:llvm-oom, r=nikic Register LLVM handlers for bad-alloc / OOM LLVM's default bad-alloc handler may throw if exceptions are enabled, and `operator new` isn't hooked at all by default. Now we register our own handler that prints a message similar to fatal errors, then aborts. We also call the function that registers the C++ `std::new_handler`. Fixes rust-lang#121305 Cc llvm/llvm-project#85281 r? ``@nikic``
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LLVM's default bad-alloc handler may throw if exceptions are enabled,
and
operator newisn't hooked at all by default. Now we register ourown handler that prints a message similar to fatal errors, then aborts.
We also call the function that registers the C++
std::new_handler.Fixes #121305
Cc llvm/llvm-project#85281
r? @nikic