-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid noop rewrite of issues.txt #122838
Merged
bors
merged 1 commit into
rust-lang:master
from
workingjubilee:less-catholic-blessings-to-prevent-incremental-protests
Mar 22, 2024
Merged
Avoid noop rewrite of issues.txt #122838
bors
merged 1 commit into
rust-lang:master
from
workingjubilee:less-catholic-blessings-to-prevent-incremental-protests
Mar 22, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
A-testsuite
Area: The testsuite used to check the correctness of rustc
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
T-bootstrap
Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
labels
Mar 21, 2024
workingjubilee
changed the title
Avoid rewriting issues.txt
Avoid rewriting issues.txt on noop
Mar 21, 2024
workingjubilee
force-pushed
the
less-catholic-blessings-to-prevent-incremental-protests
branch
from
March 21, 2024 20:02
61a9b71
to
c00920c
Compare
workingjubilee
changed the title
Avoid rewriting issues.txt on noop
Avoid noop rewrite of issues.txt
Mar 21, 2024
This can trigger incremental rebuilds since incr doesn't realize nothing changed.
thx |
bors
added
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
and removed
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
labels
Mar 21, 2024
jhpratt
added a commit
to jhpratt/rust
that referenced
this pull request
Mar 21, 2024
…ings-to-prevent-incremental-protests, r=matthiaskrgr Avoid noop rewrite of issues.txt Fixes rust-lang#122834 r? `@matthiaskrgr`
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Mar 21, 2024
…ings-to-prevent-incremental-protests, r=matthiaskrgr Avoid noop rewrite of issues.txt Fixes rust-lang#122834 r? ``@matthiaskrgr``
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 21, 2024
Rollup of 6 pull requests Successful merges: - rust-lang#121881 (std::net: adding acceptfilter feature for netbsd/freebsd.) - rust-lang#122817 (Doc Guarantee: BTree(Set|Map): `IntoIter` Iterate in Sorted by key Order) - rust-lang#122829 (Implement `FusedIterator` for `gen` block) - rust-lang#122831 (make failure logs less verbose) - rust-lang#122837 (add test for rust-lang#122549) - rust-lang#122838 (Avoid noop rewrite of issues.txt) r? `@ghost` `@rustbot` modify labels: rollup
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 22, 2024
…iaskrgr Rollup of 11 pull requests Successful merges: - rust-lang#121881 (std::net: adding acceptfilter feature for netbsd/freebsd.) - rust-lang#122817 (Doc Guarantee: BTree(Set|Map): `IntoIter` Iterate in Sorted by key Order) - rust-lang#122826 (Add tests for shortcomings of associated type bounds) - rust-lang#122829 (Implement `FusedIterator` for `gen` block) - rust-lang#122831 (make failure logs less verbose) - rust-lang#122837 (add test for rust-lang#122549) - rust-lang#122838 (Avoid noop rewrite of issues.txt) - rust-lang#122841 (add 2 more tests for issues fixed by rust-lang#122749) - rust-lang#122843 (Add a never type option to make diverging blocks `()`) - rust-lang#122844 (add test for ice "cannot relate region: LUB(ReErased, ReError)") - rust-lang#122845 (Clippy subtree update) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 22, 2024
Rollup merge of rust-lang#122838 - workingjubilee:less-catholic-blessings-to-prevent-incremental-protests, r=matthiaskrgr Avoid noop rewrite of issues.txt Fixes rust-lang#122834 r? ```@matthiaskrgr```
workingjubilee
deleted the
less-catholic-blessings-to-prevent-incremental-protests
branch
May 5, 2024 02:11
workingjubilee
restored the
less-catholic-blessings-to-prevent-incremental-protests
branch
May 5, 2024 02:14
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
A-testsuite
Area: The testsuite used to check the correctness of rustc
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
T-bootstrap
Relevant to the bootstrap subteam: Rust's build system (x.py and src/bootstrap)
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #122834
r? @matthiaskrgr