add a couple more tests #122888
add a couple more tests #122888
Conversation
…(|r| !r.iter().any(|sc| sc.chr == \'\\t\')) with edition 2021 Fixes rust-lang#105210
|
r? @wesleywiser rustbot has assigned @wesleywiser. Use |
rustbot
added
S-waiting-on-review
| @@ -1,3 +1,8 @@ | |||
| // -Zunstable-options added as test for ICE #97725 (left == right)` | |||
There was a problem hiding this comment.
How does -Zunstable-options change behavior of this test?
There was a problem hiding this comment.
I assume the thing that causes that test to fail is not -Znunstable-options, but just debug assertions. We don't test those in CI afaict.
There was a problem hiding this comment.
It would have caught the original ice which is reason enough to add it imo.
I do run x.py test with debug assertions from time to time.
There was a problem hiding this comment.
No, I am asking why you believe -Zunstable-options would have caught the original ICE? -Zunstable-options afaict does nothing on its own -- it's required to pass other unstable flags, but it doesn't do anything behavioral on its own.
There was a problem hiding this comment.
I have been reporting several ices where -Zunstable-options was crucial to reproducing the ICE, with no other flags being involved.
https://github.com/rust-lang/rust/issues?q=is%3Aissue+%22-Zunstable-options%22++author%3Amatthiaskrgr+
As to why that happens, no idea 🤷
| @@ -0,0 +1,10 @@ | |||
| // ICE #105210 self.lines.iter().all(|r| !r.iter().any(|sc| sc.chr == \'\\t\')) | |||
| // ignore-tidy-tab | |||
There was a problem hiding this comment.
I like to have some context in the test what the ice looked like
There was a problem hiding this comment.
No, I mean ignore-tidy-tab.
There was a problem hiding this comment.
Ah lol.
The original repro needed a tab on a very specific place for some reason 🐙
while reducing the ice would go away if I replaced the tab with a space
|
ok then @bors r+ rollup |
bors
added
S-waiting-on-bors
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#114009 (compiler: allow transmute of ZST arrays with generics) - rust-lang#122195 (Note that the caller chooses a type for type param) - rust-lang#122651 (Suggest `_` for missing generic arguments in turbofish) - rust-lang#122784 (Add `tag_for_variant` query) - rust-lang#122839 (Split out `PredicatePolarity` from `ImplPolarity`) - rust-lang#122873 (Merge my contributor emails into one using mailmap) - rust-lang#122885 (Adjust better spastorino membership to triagebot's adhoc_groups) - rust-lang#122888 (add a couple more tests) r? `@ghost` `@rustbot` modify labels: rollup
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#114009 (compiler: allow transmute of ZST arrays with generics) - rust-lang#122195 (Note that the caller chooses a type for type param) - rust-lang#122651 (Suggest `_` for missing generic arguments in turbofish) - rust-lang#122784 (Add `tag_for_variant` query) - rust-lang#122839 (Split out `PredicatePolarity` from `ImplPolarity`) - rust-lang#122873 (Merge my contributor emails into one using mailmap) - rust-lang#122885 (Adjust better spastorino membership to triagebot's adhoc_groups) - rust-lang#122888 (add a couple more tests) r? `@ghost` `@rustbot` modify labels: rollup
Rollup merge of rust-lang#122888 - matthiaskrgr:evenmoretests, r=compiler-errors add a couple more tests
…iaskrgr Rollup of 8 pull requests Successful merges: - rust-lang#114009 (compiler: allow transmute of ZST arrays with generics) - rust-lang#122195 (Note that the caller chooses a type for type param) - rust-lang#122651 (Suggest `_` for missing generic arguments in turbofish) - rust-lang#122784 (Add `tag_for_variant` query) - rust-lang#122839 (Split out `PredicatePolarity` from `ImplPolarity`) - rust-lang#122873 (Merge my contributor emails into one using mailmap) - rust-lang#122885 (Adjust better spastorino membership to triagebot's adhoc_groups) - rust-lang#122888 (add a couple more tests) r? `@ghost` `@rustbot` modify labels: rollup
No description provided.