Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 8 pull requests #122959

Closed
wants to merge 32 commits into from

Commits on Mar 12, 2024

  1. Configuration menu
    Copy the full SHA
    d3299af View commit details
    Browse the repository at this point in the history

Commits on Mar 17, 2024

  1. Handle str literals written with ' lexed as lifetime

    Given `'hello world'` and `'1 str', provide a structured suggestion for a valid string literal:
    
    ```
    error[E0762]: unterminated character literal
      --> $DIR/lex-bad-str-literal-as-char-3.rs:2:26
       |
    LL |     println!('hello world');
       |                          ^^^^
       |
    help: if you meant to write a `str` literal, use double quotes
       |
    LL |     println!("hello world");
       |              ~           ~
    ```
    ```
    error[E0762]: unterminated character literal
      --> $DIR/lex-bad-str-literal-as-char-1.rs:2:20
       |
    LL |     println!('1 + 1');
       |                    ^^^^
       |
    help: if you meant to write a `str` literal, use double quotes
       |
    LL |     println!("1 + 1");
       |              ~     ~
    ```
    
    Fix rust-lang#119685.
    estebank committed Mar 17, 2024
    Configuration menu
    Copy the full SHA
    982918f View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    4a10b01 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    999a0dc View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    6f388ef View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    ea1883d View commit details
    Browse the repository at this point in the history
  6. fix rustdoc test

    estebank committed Mar 17, 2024
    Configuration menu
    Copy the full SHA
    f4d30b1 View commit details
    Browse the repository at this point in the history

Commits on Mar 19, 2024

  1. Configuration menu
    Copy the full SHA
    f4adb1e View commit details
    Browse the repository at this point in the history

Commits on Mar 22, 2024

  1. Configuration menu
    Copy the full SHA
    2624e91 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    fbf21c5 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    1fcf2ea View commit details
    Browse the repository at this point in the history
  4. Failing test

    compiler-errors committed Mar 22, 2024
    Configuration menu
    Copy the full SHA
    da8a39a View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    78ebb93 View commit details
    Browse the repository at this point in the history

Commits on Mar 23, 2024

  1. add test for rust-lang#99945

    matthiaskrgr committed Mar 23, 2024
    Configuration menu
    Copy the full SHA
    12e3629 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    2f9a240 View commit details
    Browse the repository at this point in the history
  3. add test for rust-lang#104779 opaque types, patterns and subtyping IC…

    …E: IndexMap: key not found
    
    Fixes rust-lang#104779
    matthiaskrgr committed Mar 23, 2024
    Configuration menu
    Copy the full SHA
    e54bff7 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    f1f287f View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    f8aeac8 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    cc422ce View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    f2bc9c5 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    368bfb2 View commit details
    Browse the repository at this point in the history
  9. address review feedback

    matthiaskrgr committed Mar 23, 2024
    Configuration menu
    Copy the full SHA
    9aea37d View commit details
    Browse the repository at this point in the history
  10. Add test in higher-ranked

    Luv-Ray committed Mar 23, 2024
    Configuration menu
    Copy the full SHA
    246f746 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    188c46a View commit details
    Browse the repository at this point in the history
  12. Rollup merge of rust-lang#116016 - jhpratt:kill-rustc-serialize, r=dt…

    …olnay
    
    Soft-destabilize `RustcEncodable` & `RustcDecodable`, remove from prelude in next edition
    
    cc rust-lang/libs-team#272
    
    Any use of `RustcEncodable` and `RustcDecodable` now triggers a deny-by-default lint. The derives have been removed from the 2024 prelude. I specifically chose **not** to document this in the module-level documentation, as the presence in existing preludes is not documented (which I presume is intentional).
    
    This does not implement the proposed change for `rustfix`, which I will be looking into shortly.
    
    With regard to the items in the preludes being stable, this should not be an issue because rust-lang#15702 has been resolved.
    
    r? libs-api
    matthiaskrgr committed Mar 23, 2024
    Configuration menu
    Copy the full SHA
    d959730 View commit details
    Browse the repository at this point in the history
  13. Rollup merge of rust-lang#121281 - kadiwa4:test_103626, r=estebank,lcnr

    regression test for rust-lang#103626
    
    I don't know what a descriptive filename for this would be.
    
    Fixes rust-lang#103626
    matthiaskrgr committed Mar 23, 2024
    Configuration menu
    Copy the full SHA
    e07a5aa View commit details
    Browse the repository at this point in the history
  14. Rollup merge of rust-lang#122168 - compiler-errors:inline-coroutine-b…

    …ody-validation, r=cjgillot
    
    Fix validation on substituted callee bodies in MIR inliner
    
    When inlining a coroutine, we will substitute the MIR body with the args of the call. There is code in the MIR validator that attempts to prevent query cycles, and will use the coroutine body directly when it detects that's the body that's being validated. That means that when inlining a coroutine body that has been substituted, it may no longer be parameterized over the original args of the coroutine, which will lead to substitution ICEs.
    
    Fixes rust-lang#119064
    matthiaskrgr committed Mar 23, 2024
    Configuration menu
    Copy the full SHA
    d0e27af View commit details
    Browse the repository at this point in the history
  15. Rollup merge of rust-lang#122217 - estebank:issue-119685, r=fmease

    Handle str literals written with `'` lexed as lifetime
    
    Given `'hello world'` and `'1 str', provide a structured suggestion for a valid string literal:
    
    ```
    error[E0762]: unterminated character literal
      --> $DIR/lex-bad-str-literal-as-char-3.rs:2:26
       |
    LL |     println!('hello world');
       |                          ^^^^
       |
    help: if you meant to write a `str` literal, use double quotes
       |
    LL |     println!("hello world");
       |              ~           ~
    ```
    ```
    error[E0762]: unterminated character literal
      --> $DIR/lex-bad-str-literal-as-char-1.rs:2:20
       |
    LL |     println!('1 + 1');
       |                    ^^^^
       |
    help: if you meant to write a `str` literal, use double quotes
       |
    LL |     println!("1 + 1");
       |              ~     ~
    ```
    
    Fix rust-lang#119685.
    matthiaskrgr committed Mar 23, 2024
    Configuration menu
    Copy the full SHA
    08bb35e View commit details
    Browse the repository at this point in the history
  16. Rollup merge of rust-lang#122379 - RalfJung:int2ptr-transmute, r=m-ou-se

    transmute: caution against int2ptr transmutation
    
    This came up in rust-lang#121282.
    Cc ``@saethlin`` ``@scottmcm``
    
    Eventually we'll add a proper description of provenance that we can reference, but that's a bunch of work and it's unclear who will have the time to do that when. Meanwhile, let's at least do what we can without mentioning provenance explicitly.
    matthiaskrgr committed Mar 23, 2024
    Configuration menu
    Copy the full SHA
    f68a0f1 View commit details
    Browse the repository at this point in the history
  17. Rollup merge of rust-lang#122907 - compiler-errors:uniquify-reerror, …

    …r=lcnr
    
    Uniquify `ReError` on input mode in canonicalizer
    
    See test descr
    
    Fixes rust-lang#122861
    
    r? lcnr
    matthiaskrgr committed Mar 23, 2024
    Configuration menu
    Copy the full SHA
    88574e1 View commit details
    Browse the repository at this point in the history
  18. Rollup merge of rust-lang#122942 - Luv-Ray:master, r=lcnr

    Add test in higher ranked subtype
    
    I'm a beginner in this repository, and there are some things I'm not sure about:
    
    - Is it okay that there is a warning:
    ```
    rustc_infer::infer::relate::generalize may incompletely handle alias type: AliasTy { args: [?1t, '^0.Named(DefId(0:15 ~ structually_relate_aliases[de75]::{impl#1}::'a), "'a")], def_id: DefId(0:5 ~ structually_relate_aliases[de75]::ToUnit::Unit) }
    ```
    - Is it okay that there are two duplicate errors in the same line?
    - Did I put the test in the right place?
    
    Any suggestions would be appreciated.
    
    Fixes rust-lang#121649
    matthiaskrgr committed Mar 23, 2024
    Configuration menu
    Copy the full SHA
    35310b7 View commit details
    Browse the repository at this point in the history
  19. Configuration menu
    Copy the full SHA
    5f5362d View commit details
    Browse the repository at this point in the history