-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Subtree update of rust-analyzer
#122981
Closed
Closed
Subtree update of rust-analyzer
#122981
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
internal: Sync from downstream
internal: remove redundant clone()s
fix: Ignore some warnings if they originate from within macro expansions These tend to be annoying noise as we can't handle `allow`s for them properly for the time being.
Bump dependencies and use in-tree `rustc_pattern_analysis` One last `pattern_analysis` API change. I don't have any more planned! So we can now use the in-tree version when available.
fix: handle attributes when typing curly bracket fix rust-lang#16848. When inserting a `{`, if it is identified that the front part of `expr` is `attr`, we consider it as inserting `{}` around the entire `expr` (excluding the attr part).
…illa Fix panic with impl trait associated types in where clause Not sure if this is the correct fix, but the tests are green :') Fixes rust-lang#16823
… r=Veykril Refactor extension to support arbitrary shell command runnables Currently, the extension assumes that all runnables invoke cargo. Arguments are sometimes full CLI arguments, and sometimes arguments passed to a cargo subcommand. Refactor the extension so that tasks are just a `program` and a list of strings `args`, and rename `CargoTask` to `RustTask` to make it generic. (This was factored out of rust-lang#16135 and tidied.)
fix: Make inlay hint resolving work better for inlays targetting the same position
fix: Fix projects depending on `rustc_private` hanging If loading the root fails, we'll hang up in this loop as we never inserted the entry that asserts we already visited a package. This fixes that Fixes rust-lang/rust-analyzer#16902
…, r=Veykril Have Derive Attribute share a token tree with it's proc macros. The goal of this PR is to stop creating a token tree for each derive proc macro. This is done by giving the derive proc macros an id to its parent derive element. From running the analysis stat on the rust analyzer project I did see a small memory decrease. ``` Inference: 42.80s, 362ginstr, 591mb MIR lowering: 8.67s, 67ginstr, 291mb Mir failed bodies: 18 (0%) Data layouts: 85.81ms, 609minstr, 8mb Failed data layouts: 135 (6%) Const evaluation: 440.57ms, 5235minstr, 13mb Failed const evals: 1 (0%) Total: 64.16s, 552ginstr, 1731mb ``` After Change ``` Inference: 40.32s, 340ginstr, 593mb MIR lowering: 7.95s, 62ginstr, 292mb Mir failed bodies: 18 (0%) Data layouts: 87.97ms, 591minstr, 8mb Failed data layouts: 135 (6%) Const evaluation: 433.38ms, 5226minstr, 14mb Failed const evals: 1 (0%) Total: 60.49s, 523ginstr, 1680mb ``` Currently this breaks the expansion for the actual derive attribute. ## TODO - [x] Pick a better name for the function `smart_macro_arg`
internal: Remove span trait
fix: Some file watching related vfs fixes Fixes rust-lang/rust-analyzer#15554, additionally it seems that client side file watching was broken on windows this entire time, this PR switches `DidChangeWatchedFilesRegistrationOptions` to use relative glob patterns which do work on windows in VSCode.
fix: Don't assert paths being utf8 when filtering them in the watcher Closes rust-lang/rust-analyzer#16914
fix: handle self::super when lowering UseTree fix rust-lang#16800.
internal: Rename ProcMacroKind::FuncLike to Bang
fix: Rename `func_like` to `FuncLike` Should fix rust-lang#16926. Please check the issue for more information.
internal: Build x86_64-unknown-linux-gnu releases on Rocky Linux 8
internal: Bump release actions and Node
rust-analyzer is developed in its own repository. If possible, consider making this change to rust-lang/rust-analyzer instead. cc @rust-lang/rust-analyzer |
rustbot
added
the
S-waiting-on-review
Status: Awaiting review from the assignee but also interested parties.
label
Mar 24, 2024
The job Click to see the possible cause of the failure (guessed by this bot)
|
@Nadrieril I think I'm gonna let you sort this one out. The two |
bors
added a commit
to rust-lang/rust-analyzer
that referenced
this pull request
Mar 25, 2024
Revert to the crates.io version of rustc_pattern_analysis The API hasn't fully settled yet, and there's an extra wrinkle with `IdxContainer` which blocked the [subtree update](rust-lang/rust#122981). Let's just keep using the crates.io version for a bit longer. r? `@lnicola`
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
r? ghost