-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add support for Arm64EC to the Standard Library #123144
Conversation
rustbot has assigned @GuillaumeGomez. Use |
...I'm confused why such a pervasive library change assigned someone from docs? Rustbot? You okay over there? |
I did change some docs, so 🤷 |
Apart from my nits, docs changes look good. 😉 However, please assign someone else for the final approval. |
r? libs |
fdb14ac
to
f01c81c
Compare
You can override definitions by putting them in |
Submitted a PR to add Arm64EC support in windows-rs: microsoft/windows-rs#2957 |
@rustbot blocked Need to update windows-rs |
These commits modify the If this was unintentional then you should revert the changes before this PR is merged. Some changes occurred in src/doc/rustc/src/platform-support cc @Nilstrieb |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The libs changes look good to me, though I've not tested it.
Thanks! Sounds like the only piece left to review is the compiler changes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Compiler changes look good to me
@bors r=GuillaumeGomez,ChrisDenton,wesleywiser |
☀️ Test successful - checks-actions |
Finished benchmarking commit (c5de414): comparison URL. Overall result: no relevant changes - no action needed@rustbot label: -perf-regression Instruction countThis benchmark run did not return any relevant results for this metric. Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesThis benchmark run did not return any relevant results for this metric. Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 676.875s -> 677.567s (0.10%) |
Adds the final pieces so that the standard library can be built for arm64ec-pc-windows-msvc (initially added in #119199)
windows-sys
to 0.56.0, which adds support for Arm64EC.isEC
parameter for LLVM'swriteArchive
function.#![feature(asm_experimental_arch)]
to library crates where Arm64EC inline assembly is used, as it is currently unstable.