Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid ICEing without the pattern_types feature gate #123648

Merged
merged 2 commits into from
Apr 9, 2024
Merged

Avoid ICEing without the pattern_types feature gate #123648

merged 2 commits into from
Apr 9, 2024

Conversation

oli-obk
Copy link
Contributor

@oli-obk oli-obk commented Apr 8, 2024

fixes #123643

@rustbot
Copy link
Collaborator

rustbot commented Apr 8, 2024

r? @pnkfelix

rustbot has assigned @pnkfelix.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 8, 2024
@rustbot
Copy link
Collaborator

rustbot commented Apr 8, 2024

HIR ty lowering was modified

cc @fmease

@compiler-errors
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Apr 8, 2024

📌 Commit 24ee9b9 has been approved by compiler-errors

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 8, 2024
@matthiaskrgr matthiaskrgr mentioned this pull request Apr 9, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 9, 2024
@bors
Auto merge of rust-lang#123663 - matthiaskrgr:rollup-1qnj9j3, r=matth…
86b603c 
…iaskrgr

Rollup of 9 pull requests

Successful merges:

 - rust-lang#122768 (Use the more informative generic type inference failure error on method calls on raw pointers)
 - rust-lang#123620 (sanitizers: Create the rustc_sanitizers crate)
 - rust-lang#123624 ([rustdoc] [GUI tests] Make theme switching closer to reality)
 - rust-lang#123636 (Update books)
 - rust-lang#123647 (rustdoc: slightly clean up the synthesis of blanket impls)
 - rust-lang#123648 (Avoid ICEing without the pattern_types feature gate)
 - rust-lang#123649 (KCFI: Use legal charset in shim encoding)
 - rust-lang#123652 (Fix UI tests with dist-vendored dependencies)
 - rust-lang#123655 (Remove unimplemented!() from BinOp::ty() function)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 727c31a into rust-lang:master Apr 9, 2024
11 checks passed
@rustbot rustbot added this to the 1.79.0 milestone Apr 9, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Apr 9, 2024
@rust-timer
Unrolled build for rust-lang#123648
9fd5848 
Rollup merge of rust-lang#123648 - oli-obk:pattern_types_syntax, r=compiler-errors

Avoid ICEing without the pattern_types feature gate

fixes  rust-lang#123643
@fmease fmease added the F-pattern_types `#![feature(pattern_types)]` label Apr 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@pnkfelix pnkfelix

Labels
F-pattern_types `#![feature(pattern_types)]` S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
pattern types
Status: Done
Milestone
1.79.0
Development

Successfully merging this pull request may close these issues.

patterns: wrong tracking issue?
6 participants
@oli-obk @rustbot @compiler-errors @bors @pnkfelix @fmease