Disable assert_unsafe_precondition to measure compile-time cost

[saethlin]

r? ghost

[saethlin]

@bors try @rust-timer queue

[bors]

⌛ Trying commit 62333ec with merge 754b460...

[bors]

💔 Test failed - checks-actions

[saethlin]

@bors try @rust-timer queue

[bors]

⌛ Trying commit fbf9acf with merge 45b300c...

[bors]

☀️ Try build successful - checks-actions
Build commit: 45b300c (45b300c6c1ec060f721630f74efbb9ff96a6a727)

[rust-timer]

Finished benchmarking commit (45b300c): comparison URL.

Overall result: ❌✅ regressions and improvements - ACTION NEEDED

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

Next Steps: If you can justify the regressions found in this try perf run, please indicate this with @rustbot label: +perf-regression-triaged along with sufficient written justification. If you cannot justify the regressions please fix the regressions and do another perf run. If the next run shows neutral or positive results, the label will be automatically removed.

@bors rollup=never
@rustbot label: -S-waiting-on-perf +perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.8%	[0.3%, 2.3%]	11
Regressions ❌ (secondary)	2.2%	[0.3%, 7.3%]	4
Improvements ✅ (primary)	-0.8%	[-2.3%, -0.2%]	32
Improvements ✅ (secondary)	-1.5%	[-6.5%, -0.2%]	18
All ❌✅ (primary)	-0.4%	[-2.3%, 2.3%]	43

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	4.0%	[0.6%, 10.3%]	4
Regressions ❌ (secondary)	4.0%	[3.4%, 4.7%]	2
Improvements ✅ (primary)	-2.5%	[-3.6%, -1.1%]	5
Improvements ✅ (secondary)	-2.5%	[-2.5%, -2.5%]	1
All ❌✅ (primary)	0.4%	[-3.6%, 10.3%]	9

Cycles

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	1.4%	[1.0%, 2.0%]	3
Regressions ❌ (secondary)	-	-	0
Improvements ✅ (primary)	-1.8%	[-2.6%, -1.1%]	11
Improvements ✅ (secondary)	-4.5%	[-7.0%, -3.1%]	4
All ❌✅ (primary)	-1.1%	[-2.6%, 2.0%]	14

Binary size

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

	mean	range	count
Regressions ❌ (primary)	0.7%	[0.0%, 4.7%]	53
Regressions ❌ (secondary)	0.6%	[0.0%, 0.8%]	42
Improvements ✅ (primary)	-1.1%	[-4.0%, -0.0%]	51
Improvements ✅ (secondary)	-2.6%	[-5.8%, -0.1%]	21
All ❌✅ (primary)	-0.2%	[-4.0%, 4.7%]	104

Bootstrap: 672.287s -> 670.092s (-0.33%)
Artifact size: 318.40 MiB -> 318.55 MiB (0.05%)

[saethlin]

@rust-lang/wg-compiler-performance this is the measurement I promised in #120863 (comment). In the above perf report green is bad, because it indicates that turning off the checks makes compilation measurably faster.

I'm going to use this PR to look for more things like #123835 and periodically re-take the measurement.

[saethlin]

@bors try @rust-timer queue

[rust-timer]

Awaiting bors try build completion.

@rustbot label: +S-waiting-on-perf

[saethlin]

Oh I see. I did the thing where I can't reopen this because I force-pushed without reopening. Ah well.