Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tweak value suggestions in borrowck and hir_analysis #123704

Merged
merged 3 commits into from
Apr 11, 2024
Merged

Tweak value suggestions in borrowck and hir_analysis #123704

merged 3 commits into from
Apr 11, 2024

Commits on Apr 9, 2024

  1. Tweak value suggestions in borrowck and hir_analysis 

    Unify the output of `suggest_assign_value` and `ty_kind_suggestion`.

Ideally we'd make these a single function, but doing so would likely require modify the crate dependency tree.
    @estebank
    estebank committed Apr 9, 2024
    Configuration menu
    Copy the full SHA
    a983dd8 View commit details
    Browse the repository at this point in the history

Commits on Apr 10, 2024

  1. Handle more cases of value suggestions

    @estebank
    estebank committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    e17388b View commit details
    Browse the repository at this point in the history

  2. Handle more cases of "values to suggest" given a type 

    Add handling for `String`, `Box`, `Option` and `Result`.
    @estebank
    estebank committed Apr 10, 2024
    Configuration menu
    Copy the full SHA
    1eda056 View commit details
    Browse the repository at this point in the history