Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deduplicate some function implementations between the parser and AST/HIR #123777

Merged
merged 2 commits into from
Apr 11, 2024
Merged

Deduplicate some function implementations between the parser and AST/HIR #123777

merged 2 commits into from
Apr 11, 2024

Conversation

oli-obk
Copy link
Contributor

@oli-obk oli-obk commented Apr 11, 2024

These functions already existed on parser binops, so just convert back to them back and invoke the equivalent method.

@rustbot
Copy link
Collaborator

rustbot commented Apr 11, 2024

r? @pnkfelix

rustbot has assigned @pnkfelix.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 11, 2024
@jieyouxu
Copy link
Member

Thanks!
r? jieyouxu
@bors r+ rollup

@bors
Copy link
Contributor

bors commented Apr 11, 2024

📌 Commit 0c8aad6 has been approved by jieyouxu

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 11, 2024
@matthiaskrgr matthiaskrgr mentioned this pull request Apr 11, 2024
Merged
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 11, 2024
@bors
Auto merge of rust-lang#123814 - matthiaskrgr:rollup-lxn0t4t, r=matth…
616a8f8 
…iaskrgr

Rollup of 5 pull requests

Successful merges:

 - rust-lang#123459 (Correctly handle inlining of doc hidden foreign items)
 - rust-lang#123740 (Reduce Size of `ModifierInfo`)
 - rust-lang#123770 (Correct broken link in core::pin doc)
 - rust-lang#123777 (Deduplicate some function implementations between the parser and AST/HIR)
 - rust-lang#123808 (codegen tests: Tolerate `nuw` `nsw` on `trunc`)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 08ebea2 into rust-lang:master Apr 11, 2024
11 checks passed
@rustbot rustbot added this to the 1.79.0 milestone Apr 11, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Apr 11, 2024
@rust-timer
Unrolled build for rust-lang#123777
9c95245 
Rollup merge of rust-lang#123777 - oli-obk:operator_cleanup, r=jieyouxu

Deduplicate some function implementations between the parser and AST/HIR

These functions already existed on parser binops, so just convert back to them back and invoke the equivalent method.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@jieyouxu jieyouxu

Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Milestone
1.79.0
Development

Successfully merging this pull request may close these issues.
5 participants
@oli-obk @rustbot @jieyouxu @bors @pnkfelix