Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix VecDeque::shrink_to UB when handle_alloc_error unwinds. #123803

Merged
merged 2 commits into from
May 26, 2024
Merged

Fix VecDeque::shrink_to UB when handle_alloc_error unwinds. #123803

merged 2 commits into from
May 26, 2024

Commits on May 7, 2024

  1. Fix VecDeque::shrink_to UB when handle_alloc_error unwinds. 

    Luckily it's comparatively simple to just restore the `VecDeque` into a valid state on unwinds.
    @Sp00ph
    Sp00ph committed May 7, 2024
    Configuration menu
    Copy the full SHA
    ffe8510 View commit details
    Browse the repository at this point in the history

  2. Move test_shrink_to_unwind to its own file. 

    This way, no other test can be tripped up by `test_shrink_to_unwind` changing the alloc error hook.
    @Sp00ph
    Sp00ph committed May 7, 2024
    Configuration menu
    Copy the full SHA
    5cb53bc View commit details
    Browse the repository at this point in the history