-
Notifications
You must be signed in to change notification settings - Fork 13k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 4 pull requests #123884
Rollup of 4 pull requests #123884
Conversation
Mailmap only allows one remapping per line, so @pietroalbini wasn't getting grouped correctly. Fix this.
Avoid more NonNull-raw-NonNull roundtrips in Vec r? the8472 The standard library in general has a lot of these round-trips from niched types to their raw innards and back. Such round-trips have overhead in debug builds since rust-lang#120594. I removed some such round-trips in that initial PR and I've been meaning to come back and hunt down more such examples (this is the last item on rust-lang#120848).
… r=jhpratt Stabilize (const_)slice_ptr_len and (const_)slice_ptr_is_empty_nonnull Stabilized API: ```rust impl<T> *mut [T] { pub const fn len(self) -> usize; pub const fn is_empty(self) -> bool; } impl<T> *const [T] { pub const fn len(self) -> usize; pub const fn is_empty(self) -> bool; } impl<T> NonNull<[T]> { pub const fn is_empty(self) -> bool; } ``` FCP completed in tracking issue: rust-lang#71146
Fix Pietro's entry in the mailmap Mailmap only allows one remapping per line, so `@pietroalbini` wasn't getting grouped correctly. Fix this.
Merge cuviper in the mailmap These emails are associated with my GitHub account already, but I might as well combine my activity for stuff like the Thanks page too.
@bors r+ rollup=never p=4 |
@bors p=4 |
☀️ Test successful - checks-actions |
📌 Perf builds for each rolled up PR:
previous master: 6cfd80942e In the case of a perf regression, run the following command for each PR you suspect might be the cause: |
Finished benchmarking commit (59c38c0): comparison URL. Overall result: ❌✅ regressions and improvements - ACTION NEEDEDNext Steps: If you can justify the regressions found in this perf run, please indicate this with @rustbot label: +perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)ResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Bootstrap: 674.576s -> 675.861s (0.19%) |
The single regression was immediately reverted, the rest were small improvements. @rustbot label: +perf-regression-triaged |
Successful merges:
r? @ghost
@rustbot modify labels: rollup
Create a similar rollup