Migrate some diagnostics in rustc_resolve to session diagnostic
#123896
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
jieyouxu
reviewed
Apr 15, 2024
There was a problem hiding this comment.
Looks good to me in general, just two places where EDIT: tool_only_span_suggestion was converted into subdiagnostic() which I believe changes the diagnostic output?style = "tool-only" was specified.
|
The conversions seem correct to me (I didn't try to match the diagnostic messages character-by-character, but the transformations seem correct). Since this PR doesn't touch diagnostic infra, I'm going to steal the review and approve it. Thanks for the PR! |
bors
added
S-waiting-on-bors
|
I'll link to this PR in the Diagnostic Translation tracking issue (#100717) |
jieyouxu
added a commit
to jieyouxu/rust
that referenced
this pull request
Apr 15, 2024
…n-diagnostic, r=jieyouxu Migrate some diagnostics in `rustc_resolve` to session diagnostic Hello, I migrated some diagnostics in `rustc_resolve` to session diagnostic. r? `@davidtwco`
This was referenced Apr 15, 2024
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 15, 2024
Rollup of 12 pull requests Successful merges: - rust-lang#123423 (Distribute LLVM bitcode linker as a preview component) - rust-lang#123548 (libtest: also measure time in Miri) - rust-lang#123666 (Fix some typos in doc) - rust-lang#123864 (Remove a HACK by instead inferring opaque types during expected/formal type checking) - rust-lang#123896 (Migrate some diagnostics in `rustc_resolve` to session diagnostic) - rust-lang#123919 (builtin-derive: tag → discriminant) - rust-lang#123922 (Remove magic constants when using `base_n`.) - rust-lang#123931 (Don't leak unnameable types in `-> _` recover) - rust-lang#123933 (move the LargeAssignments lint logic into its own file) - rust-lang#123934 (`rustc_data_structures::graph` mini refactor) - rust-lang#123941 (Fix UB in LLVM FFI when passing zero or >1 bundle) - rust-lang#123957 (disable create_dir_all_bare test on all(miri, windows)) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 15, 2024
Rollup merge of rust-lang#123896 - JeanCASPAR:rustc_resolve-to-session-diagnostic, r=jieyouxu Migrate some diagnostics in `rustc_resolve` to session diagnostic Hello, I migrated some diagnostics in `rustc_resolve` to session diagnostic. r? ``@davidtwco``
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello, I migrated some diagnostics in
rustc_resolveto session diagnostic.r? @davidtwco