Subtype predicates only exist on inference types, so we can allow them to register opaque types within them. #123979
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
S-waiting-on-review
|
@rustbot author |
rustbot
added
S-waiting-on-author
…m to register opaque types within them.
oli-obk
force-pushed
the
define_opaque_types7
branch
from
ba2072b
to
82e7773
Compare
oli-obk
added
S-waiting-on-review
compiler-errors
approved these changes
Apr 16, 2024
|
@bors r+ |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 16, 2024
…llaumeGomez Rollup of 7 pull requests Successful merges: - rust-lang#122811 (Move `SourceMap` initialization) - rust-lang#123512 (Match ergonomics 2024: Implement eat-one-layer) - rust-lang#123811 (Use queue-based `RwLock` on more platforms) - rust-lang#123859 (Remove uneeded clones now that TrustedStep implies Copy) - rust-lang#123979 (Subtype predicates only exist on inference types, so we can allow them to register opaque types within them.) - rust-lang#124016 (Outline default query and hook provider function implementations) - rust-lang#124023 (Allow workproducts without object files.) r? `@ghost` `@rustbot` modify labels: rollup
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 16, 2024
Rollup merge of rust-lang#123979 - oli-obk:define_opaque_types7, r=compiler-errors Subtype predicates only exist on inference types, so we can allow them to register opaque types within them. We were unable to come up with an example where this could be reached (subtype predicates with either side not being an infer var gets consumed during any `select_where_possible` invocation, of which we have a lot in typeck). To ensure we don't silently accept new behaviour in case we missed a situation where this could occur, I have added an assert that prevents opaque types from having their hidden type constrained. r? `@compiler-errors`
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
May 24, 2024
…-errors Revert problematic opaque type change fixes rust-lang#124891 fixes rust-lang#125192 reverts rust-lang#123979
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
May 24, 2024
…-errors Revert problematic opaque type change fixes rust-lang#124891 fixes rust-lang#125192 reverts rust-lang#123979
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 24, 2024
Rollup merge of rust-lang#125489 - oli-obk:revert_stuff_2, r=compiler-errors Revert problematic opaque type change fixes rust-lang#124891 fixes rust-lang#125192 reverts rust-lang#123979
c4rrao
pushed a commit
to Vudvud/rust
that referenced
this pull request
May 25, 2024
Add a fast-path to `Debug` ASCII `&str` Instead of going through the `EscapeDebug` machinery, we can just skip over ASCII chars that don’t need any escaping. Introduce printable-ASCII fast-path for `impl Debug for str` Instead of having a single loop that works on utf-8 `char`s, this splits the implementation into a loop that quickly skips over printable ASCII, falling back to per-char iteration for other chunks. Switch to primarily using `&str` Surprisingly, benchmarks have shown that using `&str` instead of `&[u8]` with some `unsafe` code is actually faster. Process a single not-ASCII-printable `char` per iteration This avoids having to collect a non-ASCII-printable run before processing it. std: simplify key-based thread locals std: clean up the TLS implementation Make clamp inline Run rustfmt on files that need it. Somehow these files aren't properly formatted. By default `x fmt` and `x tidy` only check files that have changed against master, so if an ill-formatted file somehow slips in it can stay that way as long as it doesn't get modified(?) I found these when I ran `x fmt` explicitly on every `.rs` file in the repo, while working on rust-lang/compiler-team#750. Fix the dead link in the bootstrap README Notify kobzol after changes to `opt-dist` Revert "Rollup merge of rust-lang#123979 - oli-obk:define_opaque_types7, r=compiler-errors" This reverts commit f939d1f, reversing changes made to 183c706. Add regression tests Only suppress binop error in favor of semicolon suggestion if we're in an assignment statement compiler: const_eval/transform/validate.rs -> mir_transform/validate.rs compiler: unnest rustc_const_eval::check_consts clippy: unnest check_consts miri: receive the blessings of validate.rs Migrate `run-make/rustdoc-with-output-dir-option` to `rmake.rs` Fix some SIMD intrinsics documentation Actually just remove the special case altogether rustdoc-json: Add test for keywords with `--document-private-items` tag more stuff with `WG-trait-system-refactor` Warn/error on self ctor from outer item in inner item (Mostly) revert "Account for type param from other item in `note_and_explain`" This mostly reverts commit 7449478. It also removes an `opt_param_at` that really is unnecessary given our ICE policy for malformed intrinsics. Update cargo use posix_memalign on most Unix targets fix typo Co-authored-by: Jubilee <46493976+workingjubilee@users.noreply.github.com> Fail relating constants of different types Use regular type equating instead of a custom query Bump bootstrap compiler to the latest beta compiler Remove now outdated comment since we bumped stage0 Stop using the avx512er and avx512pf x86 target features They are no longer supported by LLVM 19. Fixes rust-lang#125492 remove proof tree formatter, make em shallow Don't eagerly monomorphize drop for types that are impossible to instantiate Better ICE message for unresolved upvars Structurally resolve before builtin_index in EUV Add manual Sync impl for ReentrantLockGuard Fixes: rust-lang#125526
jieyouxu
added a commit
to jieyouxu/rust
that referenced
this pull request
Jun 19, 2024
…-errors Allow constraining opaque types during subtyping in the trait system Previous attempt: rust-lang#123979 Sometimes we don't immediately perform subtyping, but instead register a subtyping obligation and solve that obligation when its inference variables become resolved. Unlike immediate subtyping, we currently do not allow registering hidden types for opaque types. This PR also allows that.
fmease
added a commit
to fmease/rust
that referenced
this pull request
Jun 19, 2024
…-errors Allow constraining opaque types during subtyping in the trait system Previous attempt: rust-lang#123979 Sometimes we don't immediately perform subtyping, but instead register a subtyping obligation and solve that obligation when its inference variables become resolved. Unlike immediate subtyping, we currently do not allow registering hidden types for opaque types. This PR also allows that.
rust-timer
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jun 19, 2024
Rollup merge of rust-lang#125447 - oli-obk:eq_opaque_pred, r=compiler-errors Allow constraining opaque types during subtyping in the trait system Previous attempt: rust-lang#123979 Sometimes we don't immediately perform subtyping, but instead register a subtyping obligation and solve that obligation when its inference variables become resolved. Unlike immediate subtyping, we currently do not allow registering hidden types for opaque types. This PR also allows that.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We were unable to come up with an example where this could be reached (subtype predicates with either side not being an infer var gets consumed during any
select_where_possibleinvocation, of which we have a lot in typeck). To ensure we don't silently accept new behaviour in case we missed a situation where this could occur, I have added an assert that prevents opaque types from having their hidden type constrained.r? @compiler-errors