Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

has_typeck_results doesnt need to be a query #123992

Merged
merged 1 commit into from
Apr 23, 2024

Conversation

compiler-errors
Copy link
Member

self-explanatory

@rustbot
Copy link
Collaborator

rustbot commented Apr 15, 2024

r? @lcnr

rustbot has assigned @lcnr.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 15, 2024
@rustbot
Copy link
Collaborator

rustbot commented Apr 15, 2024

Some changes occurred in src/tools/clippy

cc @rust-lang/clippy

@jackh726
Copy link
Member

r=me whether or not you want to check perf

@compiler-errors
Copy link
Member Author

extremely doubt that this will be negative, but yeah, that's a good thing to check

@bors try @rust-timer queue

@rust-timer

This comment has been minimized.

@rustbot rustbot added the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Apr 15, 2024
@compiler-errors compiler-errors assigned jackh726 and unassigned lcnr Apr 15, 2024
@bors
Copy link
Contributor

bors commented Apr 15, 2024

⌛ Trying commit ac77e35 with merge 3b171da...

bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 15, 2024
…s, r=<try>

`has_typeck_results` doesnt need to be a query

self-explanatory
@bors
Copy link
Contributor

bors commented Apr 16, 2024

☀️ Try build successful - checks-actions
Build commit: 3b171da (3b171da67e7c0df8d67b3c3b0e87667363f89749)

@rust-timer

This comment has been minimized.

@rust-timer
Copy link
Collaborator

Finished benchmarking commit (3b171da): comparison URL.

Overall result: ❌ regressions - no action needed

Benchmarking this pull request likely means that it is perf-sensitive, so we're automatically marking it as not fit for rolling up. While you can manually mark this PR as fit for rollup, we strongly recommend not doing so since this PR may lead to changes in compiler perf.

@bors rollup=never
@rustbot label: -S-waiting-on-perf -perf-regression

Instruction count

This is a highly reliable metric that was used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
0.6% [0.2%, 1.0%] 2
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Max RSS (memory usage)

Results

This is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.

mean range count
Regressions ❌
(primary)
- - 0
Regressions ❌
(secondary)
4.9% [4.9%, 4.9%] 1
Improvements ✅
(primary)
- - 0
Improvements ✅
(secondary)
- - 0
All ❌✅ (primary) - - 0

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 678.486s -> 678.725s (0.04%)
Artifact size: 315.96 MiB -> 316.01 MiB (0.01%)

@rustbot rustbot removed the S-waiting-on-perf Status: Waiting on a perf run to be completed. label Apr 16, 2024
@compiler-errors
Copy link
Member Author

@bors r=jackh726

@bors
Copy link
Contributor

bors commented Apr 16, 2024

📌 Commit ac77e35 has been approved by jackh726

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 16, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 17, 2024
…s, r=jackh726

`has_typeck_results` doesnt need to be a query

self-explanatory
@bors
Copy link
Contributor

bors commented Apr 17, 2024

⌛ Testing commit ac77e35 with merge a98f53e...

@bors
Copy link
Contributor

bors commented Apr 17, 2024

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 17, 2024
@rust-log-analyzer

This comment has been minimized.

@compiler-errors
Copy link
Member Author

huh???

@compiler-errors
Copy link
Member Author

ah, rebase

@bors r=jackh726

@bors
Copy link
Contributor

bors commented Apr 18, 2024

📌 Commit 3c4e2ae has been approved by jackh726

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 18, 2024
@rust-log-analyzer

This comment has been minimized.

@compiler-errors
Copy link
Member Author

@bors r-

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 18, 2024
@compiler-errors
Copy link
Member Author

whoops forgot to reapprove after formatting

@bors r=jackh726

@bors
Copy link
Contributor

bors commented Apr 22, 2024

📌 Commit 6abf1aa has been approved by jackh726

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Apr 22, 2024
@bors
Copy link
Contributor

bors commented Apr 22, 2024

⌛ Testing commit 6abf1aa with merge 7472607...

bors added a commit to rust-lang-ci/rust that referenced this pull request Apr 22, 2024
…s, r=jackh726

`has_typeck_results` doesnt need to be a query

self-explanatory
@rust-log-analyzer
Copy link
Collaborator

The job x86_64-gnu-aux failed! Check out the build log: (web) (plain)

Click to see the possible cause of the failure (guessed by this bot)

@bors
Copy link
Contributor

bors commented Apr 22, 2024

💔 Test failed - checks-actions

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Apr 22, 2024
@compiler-errors
Copy link
Member Author

wtf ci

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 22, 2024
@bors
Copy link
Contributor

bors commented Apr 23, 2024

⌛ Testing commit 6abf1aa with merge a77f76e...

@bors
Copy link
Contributor

bors commented Apr 23, 2024

☀️ Test successful - checks-actions
Approved by: jackh726
Pushing a77f76e to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Apr 23, 2024
@bors bors merged commit a77f76e into rust-lang:master Apr 23, 2024
13 checks passed
@rustbot rustbot added this to the 1.79.0 milestone Apr 23, 2024
@rust-timer
Copy link
Collaborator

Finished benchmarking commit (a77f76e): comparison URL.

Overall result: no relevant changes - no action needed

@rustbot label: -perf-regression

Instruction count

This benchmark run did not return any relevant results for this metric.

Max RSS (memory usage)

This benchmark run did not return any relevant results for this metric.

Cycles

This benchmark run did not return any relevant results for this metric.

Binary size

This benchmark run did not return any relevant results for this metric.

Bootstrap: 674.396s -> 675.73s (0.20%)
Artifact size: 315.53 MiB -> 315.48 MiB (-0.02%)

flip1995 pushed a commit to flip1995/rust that referenced this pull request May 2, 2024
…s, r=jackh726

`has_typeck_results` doesnt need to be a query

self-explanatory
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants