Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sync ar_archive_writer to LLVM 18.1.3 #124033

Merged
merged 3 commits into from
Jul 17, 2024

Conversation

bjorn3
Copy link
Member

@bjorn3 bjorn3 commented Apr 16, 2024

From LLVM 15.0.0-rc3. This adds support for COFF archives containing Arm64EC object files and has various fixes for AIX big archive files.

@rustbot
Copy link
Collaborator

rustbot commented Apr 16, 2024

r? @davidtwco

rustbot has assigned @davidtwco.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Apr 16, 2024
@rustbot
Copy link
Collaborator

rustbot commented Apr 16, 2024

Some changes occurred in compiler/rustc_codegen_gcc

cc @antoyo, @GuillaumeGomez

These commits modify the Cargo.lock file. Unintentional changes to Cargo.lock can be introduced when switching branches and rebasing PRs.

If this was unintentional then you should revert the changes before this PR is merged.
Otherwise, you can ignore this comment.

@bjorn3
Copy link
Member Author

bjorn3 commented Apr 16, 2024

rust-lang/ar_archive_writer#14 is the only change from 0.2.0. cc @dpaoliello

@rust-log-analyzer

This comment has been minimized.

@bors

This comment was marked as resolved.

@bjorn3 bjorn3 force-pushed the ar_archive_writer_0_3_0 branch from 32ded4b to d3f6a7e Compare April 17, 2024 19:34
@rust-log-analyzer

This comment has been minimized.

Copy link
Member

@davidtwco davidtwco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

r=me with these comments resolved

compiler/rustc_codegen_ssa/src/back/archive.rs Outdated Show resolved Hide resolved
@bors

This comment was marked as resolved.

@apiraino
Copy link
Contributor

apiraino commented Jul 4, 2024

I think there are a few small nits and a rebase but then we should be good to go!

@rustbot author

@rustbot rustbot added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 4, 2024
From LLVM 15.0.0-rc3. This adds support for COFF archives containing
Arm64EC object files and has various fixes for AIX big archive files.
@bjorn3 bjorn3 force-pushed the ar_archive_writer_0_3_0 branch from d3f6a7e to 58e5514 Compare July 7, 2024 16:57
@klensy
Copy link
Contributor

klensy commented Jul 7, 2024

Yay, 4 object versions.

@bjorn3 bjorn3 force-pushed the ar_archive_writer_0_3_0 branch from b0c41a8 to cd3f2f6 Compare July 7, 2024 17:09
@bjorn3
Copy link
Member Author

bjorn3 commented Jul 7, 2024

Yay, 4 object versions.

Yeah

@bjorn3
Copy link
Member Author

bjorn3 commented Jul 7, 2024

@rustbot ready

@rustbot rustbot added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 7, 2024
@davidtwco
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Jul 16, 2024

📌 Commit cd3f2f6 has been approved by davidtwco

It is now in the queue for this repository.

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jul 16, 2024
bors added a commit to rust-lang-ci/rust that referenced this pull request Jul 16, 2024
Rollup of 7 pull requests

Successful merges:

 - rust-lang#124033 (Sync ar_archive_writer to LLVM 18.1.3)
 - rust-lang#126699 (Delegation: support coercion for target expression)
 - rust-lang#126762 (Deny keyword lifetimes pre-expansion)
 - rust-lang#126967 (Promote the `wasm32-wasip2` target to Tier 2)
 - rust-lang#127390 (Migrate `raw-dylib-inline-cross-dylib` and `raw-dylib-custom-dlltool` `run-make` tests to rmake)
 - rust-lang#127501 (Invert infer `error_reporting` mod struture)
 - rust-lang#127816 (Update method name to reflect changes to its internals)

r? `@ghost`
`@rustbot` modify labels: rollup
@bors bors merged commit 63f239c into rust-lang:master Jul 17, 2024
6 checks passed
@rustbot rustbot added this to the 1.81.0 milestone Jul 17, 2024
rust-timer added a commit to rust-lang-ci/rust that referenced this pull request Jul 17, 2024
Rollup merge of rust-lang#124033 - bjorn3:ar_archive_writer_0_3_0, r=davidtwco

Sync ar_archive_writer to LLVM 18.1.3

From LLVM 15.0.0-rc3. This adds support for COFF archives containing Arm64EC object files and has various fixes for AIX big archive files.
@bjorn3 bjorn3 deleted the ar_archive_writer_0_3_0 branch July 17, 2024 09:16
bjorn3 pushed a commit to bjorn3/rust that referenced this pull request Aug 9, 2024
…davidtwco

Sync ar_archive_writer to LLVM 18.1.3

From LLVM 15.0.0-rc3. This adds support for COFF archives containing Arm64EC object files and has various fixes for AIX big archive files.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants