Remove libc from more tests #124072
Merged
Remove libc from more tests #124072
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @davidtwco rustbot has assigned @davidtwco. Use |
rustbot
added
S-waiting-on-review
|
Thanks for the cleanups 💚 |
bors
added
S-waiting-on-bors
matthiaskrgr
added a commit
to matthiaskrgr/rust
that referenced
this pull request
Apr 18, 2024
…=jieyouxu Remove libc from more tests The goal here is to trim down the number of tests that depend on libc from the sysroot to make rust-lang#123938 more plausible. This PR is a few simple cases that I missed in rust-lang#123943.
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Apr 18, 2024
…iaskrgr Rollup of 6 pull requests Successful merges: - rust-lang#124041 (Fix copy path button) - rust-lang#124047 (Match ergonomics 2024: miscellaneous code cleanups) - rust-lang#124064 (Move confusing comment about otherwise blocks in `lower_match_tree`) - rust-lang#124072 (Remove libc from more tests) - rust-lang#124090 (llvm: update riscv target feature to match LLVM 19) - rust-lang#124100 (fix: make `str::from_raw_parts_mut` `mut`) r? `@ghost` `@rustbot` modify labels: rollup
bors
added
S-waiting-on-author
|
Oops, sorry |
bors
added
S-waiting-on-bors
|
☀️ Test successful - checks-actions |
|
Finished benchmarking commit (0e15f5e): comparison URL. Overall result: ✅ improvements - no action needed@rustbot label: -perf-regression Instruction countThis is a highly reliable metric that was used to determine the overall result at the top of this comment.
Max RSS (memory usage)This benchmark run did not return any relevant results for this metric. CyclesResultsThis is a less reliable metric that may be of interest but was not used to determine the overall result at the top of this comment.
Binary sizeThis benchmark run did not return any relevant results for this metric. Bootstrap: 677.567s -> 676.731s (-0.12%) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal here is to trim down the number of tests that depend on libc from the sysroot to make #123938 more plausible.
This PR is a few simple cases that I missed in #123943.