Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 9 pull requests #124084

Merged
merged 21 commits into from
Apr 17, 2024
Merged

Rollup of 9 pull requests #124084

merged 21 commits into from
Apr 17, 2024

Commits on Mar 8, 2024

  1. Document overrides of clone_from()

    Specifically, when an override doesn't just forward to an inner type,
    document the behavior and that it's preferred over simply assigning
    a clone of source. Also, change instances where the second parameter is
    "other" to "source".
    coolreader18 committed Mar 8, 2024
    1 Configuration menu
    Copy the full SHA
    c0e913f View commit details
    Browse the repository at this point in the history

Commits on Apr 16, 2024

  1. Configuration menu
    Copy the full SHA
    8f3d7fe View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    8bbaeee View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    20414b8 View commit details
    Browse the repository at this point in the history

Commits on Apr 17, 2024

  1. Stabilize const_io_structs

    slanterns committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    b7f4332 View commit details
    Browse the repository at this point in the history
  2. Address comments

    coolreader18 committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    87db7c3 View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    9e239bd View commit details
    Browse the repository at this point in the history
  4. interpret: rename base_pointer -> root_pointer

    also in Miri, "base tag" -> "root tag"
    RalfJung committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    ae7b07f View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    182698f View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    66a73f0 View commit details
    Browse the repository at this point in the history
  7. Use the default file permissions when writing

    static libraries with ar_archive_writer
    
    Fixes rust-lang#107495
    bjorn3 committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    297fceb View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    6298d8f View commit details
    Browse the repository at this point in the history
  9. Rollup merge of rust-lang#116957 - fmease:meta-notify-rustdoc-zulip-o…

    …n-backport-nominations, r=GuillaumeGomez
    
    meta: notify #t-rustdoc Zulip stream on backport nominations
    
    In July '23, it was decided to handle rustdoc-specific backport nominations in t-rustdoc meetings going forward ([Zulip announcement](https://rust-lang.zulipchat.com/#narrow/stream/266220-t-rustdoc/topic/T-rustdoc.20backports/near/374828518)). However, t-rustdoc meetings are far too infrequent for them to address nominations on time (contrary to the weekly t-compiler meetings).
    
    Hence GuillaumeGomez and I came to the conclusion that {beta,stable}-nominated rustdoc PRs should be dealt with on a case by case basis, e.g. on Zulip.
    
    This PR attempts to partially automate this process. ~~Sadly, `triagebot` is not quite as flexible has I've hoped. Blocked on `triagebot` improvements (see the `FIXME`s in this PR).~~ (Fixed in rust-lang/triagebot#1791).
    
    r? GuillaumeGomez
    matthiaskrgr committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    d7d1070 View commit details
    Browse the repository at this point in the history
  10. Rollup merge of rust-lang#122201 - coolreader18:doc-clone_from, r=dto…

    …lnay
    
    Document overrides of `clone_from()` in core/std
    
    As mentioned in rust-lang#96979 (comment)
    
    Specifically, when an override doesn't just forward to an inner type, document the behavior and that it's preferred over simply assigning a clone of source. Also, change instances where the second parameter is "other" to "source".
    
    I reused some of the wording over and over for similar impls, but I'm not sure that the wording is actually *good*. Would appreciate feedback about that.
    
    Also, now some of these seem to provide pretty specific guarantees about behavior (e.g. will reuse the exact same allocation iff the len is the same), but I was basing it off of the docs for [`Box::clone_from`](https://doc.rust-lang.org/1.75.0/std/boxed/struct.Box.html#method.clone_from-1) - I'm not sure if providing those strong guarantees is actually good or not.
    matthiaskrgr committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    21deaed View commit details
    Browse the repository at this point in the history
  11. Rollup merge of rust-lang#122723 - bjorn3:archive_writer_fixes, r=nne…

    …thercote
    
    Use same file permissions for ar_archive_writer as the LLVM archive writer
    
    This is required to switch to ar_archive_writer in the future without regressions. In addition to this PR support for reading thin archives needs to be added (rust-lang#107407) to fix all known regressions.
    
    Fixes rust-lang#107495
    matthiaskrgr committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    d5258af View commit details
    Browse the repository at this point in the history
  12. Rollup merge of rust-lang#124030 - RalfJung:adjust_alloc_base_pointer…

    …, r=oli-obk
    
    interpret: pass MemoryKind to adjust_alloc_base_pointer
    
    Another puzzle piece for rust-lang/miri#3475.
    
    The 2nd commit renames base_pointer -> root_pointer; that's how Tree Borrows already calls them and I think the term is more clear than "base pointer". In particular, this distinguishes it from "base address", since a root pointer can point anywhere into an allocation, not just its base address.
    
    rust-lang#124018 has been rolled up already so I couldn't add it there any more.
    
    r? ```@oli-obk```
    matthiaskrgr committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    6388167 View commit details
    Browse the repository at this point in the history
  13. Rollup merge of rust-lang#124037 - compiler-errors:dont-parent-body, …

    …r=michaelwoerister
    
    Don't ascend into parent bodies when collecting stmts for possible return suggestion
    
    Fixes rust-lang#124022
    matthiaskrgr committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    72ff1a3 View commit details
    Browse the repository at this point in the history
  14. Rollup merge of rust-lang#124049 - slanterns:const_io_structs_stabili…

    …ze, r=jhpratt
    
    Stabilize `const_io_structs`
    
    This PR stabilizes `const_io_structs`.
    
    Tracking issue: rust-lang#78812.
    Implementation PR: rust-lang#78811.
    
    FCPs already completed in the tracking issue.
    
    Closes rust-lang#78812.
    
    ```@rustbot``` label: +T-libs-api
    
    r? libs-api
    matthiaskrgr committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    8f3fd93 View commit details
    Browse the repository at this point in the history
  15. Rollup merge of rust-lang#124062 - allgoewer:fish-fight, r=oli-obk

    Add another expression to weird-exprs.rs
    
    I'm almost feeling bad for this but I decided I don't.
    Feel free to close if you don't approve.
    matthiaskrgr committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    abac22f View commit details
    Browse the repository at this point in the history
  16. Rollup merge of rust-lang#124066 - oli-obk:define_opaque_types7, r=co…

    …mpiler-errors
    
    Don't error on subtyping of equal types
    
    fixes rust-lang#124054 🤦
    fixes rust-lang#124075
    fixes rust-lang#124079
    
    r? `@compiler-errors`
    matthiaskrgr committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    116c0f7 View commit details
    Browse the repository at this point in the history
  17. Rollup merge of rust-lang#124073 - saethlin:rust-get-test-int, r=wesl…

    …eywiser
    
    Remove libc from rust_get_test_int uses
    
    `rust_test_helpers.c` has a few unfortunate signatures which have made some of our UI tests _technically_ need the `libc` crate. This is my attempt to evict the need of `libc` for `rust_get_test_int`.
    
    I've deleted `tests/ui/abi/foreign/foreign-no-abi.rs` because the test was originally written to check that `native mod` will compile without an ABI specifier. `native mod` was removed years before 1.0 and the test hasn't checked for anything for a long time.
    matthiaskrgr committed Apr 17, 2024
    Configuration menu
    Copy the full SHA
    abbe0d0 View commit details
    Browse the repository at this point in the history