Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

std::thread: follow-up #123913 removing unsafe on success for glibc. #124095

Closed
wants to merge 1 commit into from

Conversation

devnexen
Copy link
Contributor

@devnexen devnexen commented Apr 17, 2024

follow up #123913

@rustbot
Copy link
Collaborator

rustbot commented Apr 17, 2024

r? @m-ou-se

rustbot has assigned @m-ou-se.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added O-unix Operating system: Unix-like S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue. labels Apr 17, 2024
@Noratrieb
Copy link
Member

hm, this is needed for unsafe_op_in_unsafe_fn, right? why does this not fail to compile 🤔, CI builders should be building this

@RalfJung
Copy link
Member

CI builders should be building this

Should they? That lint is denied in alloc/src/lib.rs, but in std it's only denied in some modules and sys::pal is not one of them.

@RalfJung
Copy link
Member

RalfJung commented May 12, 2024

follow up #123913

That's a rollup. Which of the PRs in there do you mean?

I don't think we should do this. Instead we should set deny(unsafe_op_in_unsafe_fn) in more and more places.

@devnexen
Copy link
Contributor Author

I was not aware of this new lint, makes sense now.

@devnexen devnexen closed this May 12, 2024
@RalfJung
Copy link
Member

Here's the issue for using this lint in std: #73904.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
O-unix Operating system: Unix-like S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. T-libs Relevant to the library team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants